From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Tudor.Ambarus@microchip.com
Cc: kamel.bouhara@bootlin.com, Ludovic.Desroches@microchip.com,
linux-arm-kernel@lists.infradead.org,
thomas.petazzoni@bootlin.com
Subject: Re: [PATCH v5] soc: at91: Add Atmel SFR SN (Serial Number) support
Date: Fri, 4 Oct 2019 17:10:39 +0200 [thread overview]
Message-ID: <20191004151039.GA4106@piout.net> (raw)
In-Reply-To: <2d7083bf-c21e-af95-69d8-640aa08d8964@microchip.com>
On 04/10/2019 15:04:59+0000, Tudor.Ambarus@microchip.com wrote:
>
>
> On 10/04/2019 06:00 PM, Alexandre Belloni wrote:
> >> The code looks good, with this fixed one can add:
> >> Tested-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> >> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> >>
> >> As I told in v3, I have some doubts on the use cases for this driver, but let's
> >> see what the at91 folks think.
> >>
> > There is already at least one microchip customer using it so I'm going
> > to apply it.
>
> This is not an use case.
this avoids adding a ds2401 for example to get a unique serial number on
the board and reduces production cost because there is no eeprom to
write as the SN is already on the SoC.
If you are not convinced, maybe you should ask your hardware designers
why they added this feature (I guess the answer is customer request).
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-04 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 14:12 [PATCH v5] soc: at91: Add Atmel SFR SN (Serial Number) support Kamel Bouhara
2019-10-04 14:54 ` Tudor.Ambarus
2019-10-04 15:00 ` Alexandre Belloni
2019-10-04 15:04 ` Tudor.Ambarus
2019-10-04 15:10 ` Alexandre Belloni [this message]
2019-10-04 15:16 ` Tudor.Ambarus
2019-10-04 15:25 ` Nicolas.Ferre
2019-11-01 7:13 ` Alexander Dahl
2019-11-05 17:29 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004151039.GA4106@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=kamel.bouhara@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).