From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85059C47404 for ; Sun, 6 Oct 2019 00:32:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 580A6222C8 for ; Sun, 6 Oct 2019 00:32:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UpyiTi2t"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="D6LxZ1Qu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 580A6222C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ym4f9JdT9YI4pz3TaeBXD3Bm5JyIS3kgE3RwFcXLSQM=; b=UpyiTi2tnhxPXQ xhDhSTX7ge2+bv7I9Xx1hRQ4p6b7RZcqClti1U2RWrKxFQXwjgslpp9dpe/TMfMoYrVJ1d2Pz4YxZ n52p65Md2ATufHw6DqIfKYDqUqGHiLbNl7rXe+Gd4exHBkyOWlqN9AMQ1+gaLNPhrKHAVSr1sscsq TotkZoSUWU9HIzu7BhM29bpqL7aGOE7DFJpvL7zhmcSD8H6ZlWtdSdNBs4LZa6sFVOFpW2kIy8SjP 5Gdmy/VGe7xr4kwgJQuoRBeBZmimD8zQKhZbY6dK/fSFh7sMgPfXXemY+2+UOFoS8aTn4/oom5Rds Ciw8/SW7pWiaC0GIXuNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGuTo-0008Iv-Lm; Sun, 06 Oct 2019 00:32:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGuTk-0008IL-GJ for linux-arm-kernel@lists.infradead.org; Sun, 06 Oct 2019 00:32:55 +0000 Received: from dragon (li937-157.members.linode.com [45.56.119.157]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A0FD222BE; Sun, 6 Oct 2019 00:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570321971; bh=yVSCUoI+lseGFR4IYqnIN8StTXuL1oZ1vQrmfXipRHY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D6LxZ1QuFoDIl516K2GCTZjZv4BnFdsxk8Jr9cmMguCqq9nIc8ryLQiLOhy36x0jN KTPJ1AP5u5xqnbnHmec2+YhpaeZ+PD2x2/BFKC/Q3/sudiUIkJ9IGGUiSuqIVXuoP5 B0gOzu0wn+PcBb+I+UZrNS6/EFatxXtZ3hK81bmo= Date: Sun, 6 Oct 2019 08:32:27 +0800 From: Shawn Guo To: Anson Huang Subject: Re: [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding Message-ID: <20191006003225.GD7150@dragon> References: <1567519424-32271-1-git-send-email-Anson.Huang@nxp.com> <20190922161415.GD1999@bug> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191005_173252_587992_8C0A48B7 X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "ulf.hansson@linaro.org" , Jacky Bai , "catalin.marinas@arm.com" , Peng Fan , "stefan@agner.ch" , "bjorn.andersson@linaro.org" , Pavel Machek , Leonard Crestez , "will@kernel.org" , "festevam@gmail.com" , "yuehaibing@huawei.com" , "marcin.juszkiewicz@linaro.org" , "jagan@amarulasolutions.com" , "linux-input@vger.kernel.org" , "ronald@innovation.ch" , dl-linux-imx , "devicetree@vger.kernel.org" , "arnd@arndb.de" , "s.hauer@pengutronix.de" , "mripard@kernel.org" , "m.felsch@pengutronix.de" , "robh+dt@kernel.org" , "tglx@linutronix.de" , "andriy.shevchenko@linux.intel.com" , Daniel Baluta , "linux-arm-kernel@lists.infradead.org" , Aisheng Dong , Andy Duan , "gregkh@linuxfoundation.org" , "dmitry.torokhov@gmail.com" , "linux-kernel@vger.kernel.org" , "dinguyen@kernel.org" , "kernel@pengutronix.de" , "olof@lixom.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 23, 2019 at 02:34:07AM +0000, Anson Huang wrote: > Hi, Pavel > > > Subject: Re: [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding > > > > On Tue 2019-09-03 10:03:40, Anson Huang wrote: > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > > > controller, the system controller is in charge of system power, clock > > > and power key event etc. management, Linux kernel has to communicate > > > with system controller via MU (message unit) IPC to get power key > > > event, add binding doc for i.MX system controller power key driver. > > > > > > Signed-off-by: Anson Huang > > > --- > > > Changes since V1: > > > - remove "wakeup-source" property, as it is NOT needed for SCU > > interrupt; > > > - remove "status" in example. > > > --- > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 14 > > ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > index c149fad..f93e2e4 100644 > > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > @@ -157,6 +157,15 @@ Required properties: > > > Optional properties: > > > - timeout-sec: contains the watchdog timeout in seconds. > > > > > > +Power key bindings based on SCU Message Protocol > > > +------------------------------------------------------------ > > > + > > > +Required properties: > > > +- compatible: should be: > > > + "fsl,imx8qxp-sc-pwrkey" > > > + followed by "fsl,imx-sc-pwrkey"; > > > +- linux,keycodes: See > > > +Documentation/devicetree/bindings/input/keys.txt > > > > Note you have keycode_s_ here, but keycode in the example and in the dts > > patch. > > NOT quite understand your point, could you please provide more details? The property being used in driver, DTS, and DT example in the bindings are all 'linux,keycode' rather than 'linux,keycodes'. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel