From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, Linux-imx@nxp.com, kernel@pengutronix.de,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source
Date: Sun, 6 Oct 2019 16:32:35 +0800 [thread overview]
Message-ID: <20191006083233.GB7150@dragon> (raw)
In-Reply-To: <1568622549-15819-1-git-send-email-Anson.Huang@nxp.com>
On Mon, Sep 16, 2019 at 04:29:09PM +0800, Anson Huang wrote:
> i.MX7S/D's GPT ipg clock should be from GPT clock root and
> controlled by CCM's GPT CCGR, using correct clock source for
> GPT ipg clock instead of IMX7D_CLK_DUMMY.
So both 'ipg' and 'per' clock are coming from GPT root clock?
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
It looks like a fix, so do we need a Fixes tag here?
Shawn
> ---
> arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 710f850..e2e604d 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -448,7 +448,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302d0000 0x10000>;
> interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT1_ROOT_CLK>,
> <&clks IMX7D_GPT1_ROOT_CLK>;
> clock-names = "ipg", "per";
> };
> @@ -457,7 +457,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302e0000 0x10000>;
> interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT2_ROOT_CLK>,
> <&clks IMX7D_GPT2_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> @@ -467,7 +467,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302f0000 0x10000>;
> interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT3_ROOT_CLK>,
> <&clks IMX7D_GPT3_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> @@ -477,7 +477,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x30300000 0x10000>;
> interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT4_ROOT_CLK>,
> <&clks IMX7D_GPT4_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-06 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 8:29 [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source Anson Huang
2019-10-06 8:32 ` Shawn Guo [this message]
2019-10-07 0:45 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006083233.GB7150@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).