From: kbuild test robot <lkp@intel.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com, kbuild-all@01.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 1/3] net: stmmac: Fallback to VLAN Perfect filtering if HASH is not available
Date: Mon, 7 Oct 2019 05:50:44 +0800 [thread overview]
Message-ID: <201910070529.LpPdh7OD%lkp@intel.com> (raw)
In-Reply-To: <3504067666a0cee6ecf636cf30081b09a6b79710.1570360411.git.Jose.Abreu@synopsys.com>
Hi Jose,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Jose-Abreu/net-stmmac-Improvements-for-next/20191007-013324
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-rc1-42-g38eda53-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:2> *ioaddr @@ got void [noderef] <asn:2> *ioaddr @@
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: sparse: expected void [noderef] <asn:2> *ioaddr
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: sparse: got struct mac_device_info *hw
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4224:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [assigned] [usertype] vid @@ got short [assigned] [usertype] vid @@
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4224:21: sparse: expected unsigned short [assigned] [usertype] vid
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4224:21: sparse: got restricted __le16 [usertype]
vim +4224 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
4206
4207 static int stmmac_vlan_update(struct stmmac_priv *priv, bool is_double)
4208 {
4209 u32 crc, hash = 0;
4210 int count = 0;
4211 u16 vid = 0;
4212
4213 for_each_set_bit(vid, priv->active_vlans, VLAN_N_VID) {
4214 __le16 vid_le = cpu_to_le16(vid);
4215 crc = bitrev32(~stmmac_vid_crc32_le(vid_le)) >> 28;
4216 hash |= (1 << crc);
4217 count++;
4218 }
4219
4220 if (!priv->dma_cap.vlhash) {
4221 if (count > 2) /* VID = 0 always passes filter */
4222 return -EOPNOTSUPP;
4223
> 4224 vid = cpu_to_le16(vid);
4225 hash = 0;
4226 }
4227
4228 return stmmac_update_vlan_hash(priv, priv->hw, hash, vid, is_double);
4229 }
4230
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-06 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 11:17 [PATCH net-next 0/3] net: stmmac: Improvements for -next Jose Abreu
2019-10-06 11:17 ` [PATCH net-next 1/3] net: stmmac: Fallback to VLAN Perfect filtering if HASH is not available Jose Abreu
2019-10-06 21:50 ` kbuild test robot [this message]
2019-10-06 11:17 ` [PATCH net-next 2/3] net: stmmac: selftests: Add tests for VLAN Perfect Filtering Jose Abreu
2019-10-06 11:17 ` [PATCH net-next 3/3] net: stmmac: Implement L3/L4 Filters in GMAC4+ Jose Abreu
2019-10-06 16:47 ` [PATCH net-next 0/3] net: stmmac: Improvements for -next David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910070529.LpPdh7OD%lkp@intel.com \
--to=lkp@intel.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).