From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 400ABC47404 for ; Mon, 7 Oct 2019 04:41:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F1F620867 for ; Mon, 7 Oct 2019 04:41:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h1rwdQs4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="ddc/42Lj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F1F620867 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5hkLhuojgRE7B9MMByHmgj8es8E4/+2OrgznBRW6G7c=; b=h1rwdQs4VQt9S8 hlwukiAwUkx8MGymp1BRT8OFF2WxI4XadGJ3SlYbqoUMzUCumJy7Ivs+8oKRumhufWvbsJBHqqdRR klKD9MdQ5AWLXLexH6oqv72DyD7lAEa+29JT4DQwC0MQeiQRpA3Fwdw91dIji5/HKDBbkIqnfAWcR yyhlZ/7QQJBkEXlaPnU6yJqE3Ap87sSLP6jIHaQPonR0fld+iZmos2WzjhswFTkPlQiw2Nbd4373H zJN1OsDAc8e85VqnTFmUdTfbI2k3vmLwBmbOGhmNSViGnXj7sGisIjNW81Rl+0IJkDxh7GSYzaPWZ Qfj85CJJokwjbFC528+Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHKpM-0002RS-N6; Mon, 07 Oct 2019 04:40:56 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHKpJ-0002R0-Rk for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2019 04:40:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XIkkXOn84faRoqcKhr8x/joSlFB/KtZXrqxZQ1zMgLc=; b=ddc/42LjsSZUwkJQodE8URGFnh xtrta8+baKq6fdcZXgVkQLdRu6kh+0R7VuC8KOfskrqQnIJEkNMWcV6MTeBpwEbRrPRXAUoBlgHVm K9iIozKZEdbbQ3/2Y33fNI/s6P0rf7yRztaae3dMdyRi9U24/VwxYbFgGV7+ZTwnJ05g=; Received: from p200300ccff0a88001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff0a:8800:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHKp3-0006vp-II; Mon, 07 Oct 2019 06:40:42 +0200 Date: Mon, 7 Oct 2019 06:40:35 +0200 From: Andreas Kemnade To: Laurent Pinchart Subject: Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes Message-ID: <20191007064035.72016c78@aktux> In-Reply-To: <20191006223958.67725fdf@aktux> References: <20191003165539.50318-1-tony@atomide.com> <03ca02c1-2816-17cd-03fd-5b72e5d0ec96@ti.com> <39E48EC6-65FE-419B-BBE8-E72CB44B517D@goldelico.com> <20191006145348.GD4740@pendragon.ideasonboard.com> <20191006223958.67725fdf@aktux> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191006_214054_195597_F858EEA9 X-CRM114-Status: GOOD ( 21.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Discussions about the Letux Kernel , Tony Lindgren , Jyri Sarha , Tomi Valkeinen , Linux-OMAP , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 6 Oct 2019 22:39:58 +0200 Andreas Kemnade wrote: > On Sun, 6 Oct 2019 17:53:48 +0300 > Laurent Pinchart wrote: > > > Hi Nikolaus, > > > > On Sat, Oct 05, 2019 at 12:50:37PM +0200, H. Nikolaus Schaller wrote: > > > > Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen : > > > > > > > > On 03/10/2019 19:55, Tony Lindgren wrote: > > > >> The old omapdrm panels got removed for v5.4 in favor of generic panels, > > > >> and the Kconfig options changed. Let's update omap2plus_defconfig > > > >> accordingly so the same panels are still enabled. > > > >> Cc: Jyri Sarha > > > >> Cc: Laurent Pinchart > > > >> Cc: Tomi Valkeinen > > > >> Signed-off-by: Tony Lindgren > > > >> --- > > > >> arch/arm/configs/omap2plus_defconfig | 12 ++++++------ > > > >> 1 file changed, 6 insertions(+), 6 deletions(-) > > > >> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig > > > >> --- a/arch/arm/configs/omap2plus_defconfig > > > >> +++ b/arch/arm/configs/omap2plus_defconfig > > > >> @@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m > > > >> CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m > > > >> CONFIG_DRM_OMAP_PANEL_DPI=m > > > >> CONFIG_DRM_OMAP_PANEL_DSI_CM=m > > > >> -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m > > > >> -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m > > > >> -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m > > > >> -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m > > > >> -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m > > > >> -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m > > > >> CONFIG_DRM_TILCDC=m > > > >> CONFIG_DRM_PANEL_SIMPLE=m > > > >> +CONFIG_DRM_PANEL_LG_LB035Q02=m > > > >> +CONFIG_DRM_PANEL_NEC_NL8048HL11=m > > > >> +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m > > > >> +CONFIG_DRM_PANEL_SONY_ACX565AKM=m > > > >> +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m > > > >> +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m > > > >> CONFIG_FB=y > > > >> CONFIG_FIRMWARE_EDID=y > > > >> CONFIG_FB_MODE_HELPERS=y > > > > > > > > Sorry, I didn't remember to update these. Some additions: > > > > > > > > These can be dropped, they no longer exist: > > > > > > > > CONFIG_DRM_OMAP_ENCODER_TFP410=m > > > > CONFIG_DRM_OMAP_CONNECTOR_DVI=m > > > > CONFIG_DRM_OMAP_PANEL_DPI=m > > > > > > After being hit by the __always_inline issue [1] I am now > > > back with being able to test v5.4-rc1. > > > > > > Now this patch fixes the build problem, but we still have > > > one: panel drivers are no longer automatically loaded at > > > boot. We now need to manually modprobe them. > > > > > > This has been observed with GTA04 (TD028TTEC1) and OpenPandora > > > (TD043MTEA1). So moving the drivers seems to have changed/broken > > > something with DT based driver matching. > > > > That's really weird, the driver name, the SPI device table and the OF > > device table are the same (except for the "omapdss," prefix that we > > don't add anymore in omapdss-boot-init.c). Would you be able to > > investigate what broke ? > > > in earlier times: > > root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias > spi:tpo,td028ttec1 > > now in 5.4-rc1: > root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias > spi:td028ttec1 > > root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko > filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko > license: GPL > description: Toppoly TD028TTEC1 panel driver > author: H. Nikolaus Schaller > srcversion: 6B3E224BCD3D76253CF361C > alias: of:N*T*Ctoppoly,td028ttec1C* > alias: of:N*T*Ctoppoly,td028ttec1 > alias: of:N*T*Ctpo,td028ttec1C* > alias: of:N*T*Ctpo,td028ttec1 > alias: spi:toppoly,td028ttec1 > alias: spi:tpo,td028ttec1 > depends: drm > intree: Y > name: panel_tpo_td028ttec1 > vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8 > > That alias is not in the list. > some more research: in former times of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1 now it strips the tpo prefix because there is no omapdss prefix anymore. Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel