From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C7BC47404 for ; Mon, 7 Oct 2019 08:24:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4AD72084D for ; Mon, 7 Oct 2019 08:24:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NGr/FMaB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4AD72084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0+plf0KJIuieDvwFp6kXbeG9UBBHqmYDHJGiaWn+FVQ=; b=NGr/FMaBs1d8fT tKei/evbl+n5cho/FXWORSK/NT8MaVP8KQqusFDhI6U6k9AZHSvYJPHwRVsVLZJ/bfVlzdyIRPArT SxQ4vTLvsHWE+uHSQu1BN2w27RYGNiAMN2Jg2vUoNPMvPoslRbiLBGi+eDPi6j38FXM2//qNdZLNw OkazvTXo5A3/XzsQktaCOIpcfEbZeR38su417GHXjeamA7V41M6HtRxssj5gSK7ZWtxy2SevR0QEm e+xyMnxRH17ECmImOc9WsJ57TmxLZufGKiH+G2kqzUxN+OrC5C3I+Y3QdpZC0kNfJe15vl3Rb/9JU YmR4V6WFhopyIAB247og==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHOJp-00076U-5U; Mon, 07 Oct 2019 08:24:37 +0000 Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHOJm-00075p-Gf for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2019 08:24:35 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 01:24:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,267,1566889200"; d="scan'208";a="222841357" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002.fm.intel.com with ESMTP; 07 Oct 2019 01:24:28 -0700 Received: from andy by smile with local (Exim 4.92.2) (envelope-from ) id 1iHOJf-00059c-CT; Mon, 07 Oct 2019 11:24:27 +0300 Date: Mon, 7 Oct 2019 11:24:27 +0300 From: Andy Shevchenko To: William Breathitt Gray Subject: Re: [PATCH v16 10/14] gpio: 74x164: Utilize the for_each_set_clump8 macro Message-ID: <20191007082427.GM32742@smile.fi.intel.com> References: <13f5d24820e5e3a17a64d025f09efc37eda77739.1570374078.git.vilhelm.gray@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <13f5d24820e5e3a17a64d025f09efc37eda77739.1570374078.git.vilhelm.gray@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_012434_597121_EE718D06 X-CRM114-Status: GOOD ( 17.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Geert Uytterhoeven , linux-gpio@vger.kernel.org, yamada.masahiro@socionext.com, linus.walleij@linaro.org, linux-pm@vger.kernel.org, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, morten.tiljeset@prevas.dk, sean.nyekjaer@prevas.dk, bgolaszewski@baylibre.com, lukas@wunner.de, geert@linux-m68k.org, akpm@linux-foundation.org, preid@electromag.com.au, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 06, 2019 at 11:11:07AM -0400, William Breathitt Gray wrote: > Replace verbose implementation in set_multiple callback with > for_each_set_clump8 macro to simplify code and improve clarity. I can test it somewhat later. > Suggested-by: Andy Shevchenko > Cc: Geert Uytterhoeven > Cc: Phil Reid > Signed-off-by: William Breathitt Gray > --- > drivers/gpio/gpio-74x164.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c > index e81307f9754e..05637d585152 100644 > --- a/drivers/gpio/gpio-74x164.c > +++ b/drivers/gpio/gpio-74x164.c > @@ -6,6 +6,7 @@ > * Copyright (C) 2010 Miguel Gaio > */ > > +#include > #include > #include > #include > @@ -72,20 +73,18 @@ static void gen_74x164_set_multiple(struct gpio_chip *gc, unsigned long *mask, > unsigned long *bits) > { > struct gen_74x164_chip *chip = gpiochip_get_data(gc); > - unsigned int i, idx, shift; > - u8 bank, bankmask; > + unsigned long offset; > + unsigned long bankmask; > + size_t bank; > + unsigned long bitmask; > > mutex_lock(&chip->lock); > - for (i = 0, bank = chip->registers - 1; i < chip->registers; > - i++, bank--) { > - idx = i / sizeof(*mask); > - shift = i % sizeof(*mask) * BITS_PER_BYTE; > - bankmask = mask[idx] >> shift; > - if (!bankmask) > - continue; > + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) { > + bank = chip->registers - 1 - offset / 8; > + bitmask = bitmap_get_value8(bits, offset) & bankmask; > > chip->buffer[bank] &= ~bankmask; > - chip->buffer[bank] |= bankmask & (bits[idx] >> shift); > + chip->buffer[bank] |= bitmask; > } > __gen_74x164_write_config(chip); > mutex_unlock(&chip->lock); > -- > 2.23.0 > -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel