From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6153C4360C for ; Tue, 8 Oct 2019 05:57:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BEDE2084D for ; Tue, 8 Oct 2019 05:57:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F/7nH9wg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WHz8GCrp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BEDE2084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ft3S7+3c+WFS/vU4CDExgSqOwpNOuAx0kPMSqUPeECg=; b=F/7nH9wgGlp+rgjmNv0mIkxDC 5MGOWI+dBYblZxoTwKm6ZqCcqNGYJOu0kIMWmzR+gQHybaoF1RCIp1T7tZG3Kn2cEHEwhMYRlvrRW E8ismXOcdO9w8lA4CuV7/Pp9U5BIn9W56ykUJuiTzwJc3SOGnnK6/cCAcHwHi7uqKjI6cykjF79gN yEr68CtvMpqITJHu9T1u59TdArCvXUo4p40noSUpVGJNz9jWxNbm7b0EggP3nNzYaeBVXTRf/6RKY CBR7MvgNCeLKy9E5U+SNqUFh8G0MFwtsQoNfnX4BaeVMrgE9DMHAbnj6t81u4PYyb0AjCVqSK/48N Nye3NEPqQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHiV1-0000Zx-8G; Tue, 08 Oct 2019 05:57:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHiUx-0000Z6-N0 for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2019 05:57:29 +0000 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 880C7206BB; Tue, 8 Oct 2019 05:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570514247; bh=VQS1Z5YEyjcEb+iO3gDcHE+LVm6TY7h8zQi8r993+Ok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WHz8GCrpCarWXWXK7D/0N22WNfkg+gWyn5+1sJRb3wmEMxfqxJICsd/mw0uXd0++j tGWOePoz7oRKYkE8fRMl0ImgYNOtPNtVM5sifVmzGzKg7RJYMrfAkht5JRYHcM8Lrn 8hwfv+5LGqsFrjC9wajGk2BxaZP1uh8yhW1Zzsvo= Date: Tue, 8 Oct 2019 07:57:23 +0200 From: Maxime Ripard To: Icenowy Zheng Subject: Re: [PATCH v2 1/3] drm/sun4i: dsi: Fix video start delay computation Message-ID: <20191008055723.2r3mrg27useqhsei@gilmour> References: <20191006160303.24413-1-icenowy@aosc.io> <20191006160303.24413-2-icenowy@aosc.io> <20191007115148.vlu2ptmrfyng4p3r@gilmour> <8B137D6E-74C5-4A9B-A8FE-84F3D38A1AD0@aosc.io> MIME-Version: 1.0 In-Reply-To: <8B137D6E-74C5-4A9B-A8FE-84F3D38A1AD0@aosc.io> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_225727_791876_789FF375 X-CRM114-Status: GOOD ( 17.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Merlijn Wajer , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Jagan Teki , Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1329378090670432404==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1329378090670432404== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dnkdjwd3j4e57axu" Content-Disposition: inline --dnkdjwd3j4e57axu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 08, 2019 at 11:06:07AM +0800, Icenowy Zheng wrote: > =E4=BA=8E 2019=E5=B9=B410=E6=9C=887=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=88= 7:51:48, Maxime Ripard =E5=86=99=E5=88=B0: > >On Mon, Oct 07, 2019 at 12:03:00AM +0800, Icenowy Zheng wrote: > >> From: Jagan Teki > >> > >> The LCD timing definitions between Linux DRM vs Allwinner are > >different, > >> below diagram shows this clear differences. > >> > >> Active Front Sync Back > >> Region Porch > >Porch > >> > ><-----------------------><----------------><--------------><------------= --> > >> //////////////////////| > >> ////////////////////// | > >> ////////////////////// |.................. > >................ > >> ________________ > >> <----- [hv]display -----> > >> <------------- [hv]sync_start ------------> > >> <--------------------- [hv]sync_end ----------------------> > >> <-------------------------------- [hv]total > >------------------------------> > >> > >> <----- lcd_[xy] --------> <- lcd_[hv]spw -> > >> <---------- lcd_[hv]bp ---------> > >> <-------------------------------- lcd_[hv]t > >------------------------------> > >> > >> The DSI driver misinterpreted the vbp term from the BSP code to refer > >> only to the backporch, when in fact it was backporch + sync. Thus the > >> driver incorrectly used the vertical front porch plus sync in its > >> calculation of the DRQ set bit value, when it should not have > >included > >> the sync timing. > >> > >> Including additional sync timings leads to flip_done timed out as: > >> > >> WARNING: CPU: 0 PID: 31 at drivers/gpu/drm/drm_atomic_helper.c:1429 > >drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > >> [CRTC:46:crtc-0] vblank wait timed out > >> Modules linked in: > >> CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted > >5.1.0-next-20190514-00029-g09e5b0ed0a58 #18 > >> Hardware name: Allwinner sun8i Family > >> Workqueue: events deferred_probe_work_func > >> [] (unwind_backtrace) from [] > >(show_stack+0x10/0x14) > >> [] (show_stack) from [] (dump_stack+0x84/0x98) > >> [] (dump_stack) from [] (__warn+0xfc/0x114) > >> [] (__warn) from [] (warn_slowpath_fmt+0x44/0x68) > >> [] (warn_slowpath_fmt) from [] > >(drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > >> [] (drm_atomic_helper_wait_for_vblanks.part.1) from > >[] (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > >> [] (drm_atomic_helper_commit_tail_rpm) from [] > >(commit_tail+0x40/0x6c) > >> [] (commit_tail) from [] > >(drm_atomic_helper_commit+0xbc/0x128) > >> [] (drm_atomic_helper_commit) from [] > >(restore_fbdev_mode_atomic+0x1cc/0x1dc) > >> [] (restore_fbdev_mode_atomic) from [] > >(drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > >> [] (drm_fb_helper_restore_fbdev_mode_unlocked) from > >[] (drm_fb_helper_set_par+0x30/0x54) > >> [] (drm_fb_helper_set_par) from [] > >(fbcon_init+0x560/0x5ac) > >> [] (fbcon_init) from [] (visual_init+0xbc/0x104) > >> [] (visual_init) from [] > >(do_bind_con_driver+0x1b0/0x390) > >> [] (do_bind_con_driver) from [] > >(do_take_over_console+0x13c/0x1c4) > >> [] (do_take_over_console) from [] > >(do_fbcon_takeover+0x74/0xcc) > >> [] (do_fbcon_takeover) from [] > >(notifier_call_chain+0x44/0x84) > >> [] (notifier_call_chain) from [] > >(__blocking_notifier_call_chain+0x48/0x60) > >> [] (__blocking_notifier_call_chain) from [] > >(blocking_notifier_call_chain+0x18/0x20) > >> [] (blocking_notifier_call_chain) from [] > >(register_framebuffer+0x1e0/0x2f8) > >> [] (register_framebuffer) from [] > >(__drm_fb_helper_initial_config_and_unlock+0x2fc/0x50c) > >> [] (__drm_fb_helper_initial_config_and_unlock) from > >[] (drm_fbdev_client_hotplug+0xe8/0x1b8) > >> [] (drm_fbdev_client_hotplug) from [] > >(drm_fbdev_generic_setup+0x88/0x118) > >> [] (drm_fbdev_generic_setup) from [] > >(sun4i_drv_bind+0x128/0x160) > >> [] (sun4i_drv_bind) from [] > >(try_to_bring_up_master+0x164/0x1a0) > >> [] (try_to_bring_up_master) from [] > >(__component_add+0x94/0x140) > >> [] (__component_add) from [] > >(sun6i_dsi_probe+0x144/0x234) > >> [] (sun6i_dsi_probe) from [] > >(platform_drv_probe+0x48/0x9c) > >> [] (platform_drv_probe) from [] > >(really_probe+0x1dc/0x2c8) > >> [] (really_probe) from [] > >(driver_probe_device+0x60/0x160) > >> [] (driver_probe_device) from [] > >(bus_for_each_drv+0x74/0xb8) > >> [] (bus_for_each_drv) from [] > >(__device_attach+0xd0/0x13c) > >> [] (__device_attach) from [] > >(bus_probe_device+0x84/0x8c) > >> [] (bus_probe_device) from [] > >(deferred_probe_work_func+0x64/0x90) > >> [] (deferred_probe_work_func) from [] > >(process_one_work+0x204/0x420) > >> [] (process_one_work) from [] > >(worker_thread+0x274/0x5a0) > >> [] (worker_thread) from [] (kthread+0x11c/0x14c) > >> [] (kthread) from [] (ret_from_fork+0x14/0x2c) > >> Exception stack(0xde539fb0 to 0xde539ff8) > >> 9fa0: 00000000 00000000 00000000 > >00000000 > >> 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > >00000000 > >> 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > >> ---[ end trace 495200a78b24980e ]--- > >> random: fast init done > >> [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* > >[CRTC:46:crtc-0] flip_done timed out > >> [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* > >[CONNECTOR:48:DSI-1] flip_done timed out > >> [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* > >[PLANE:30:plane-0] flip_done timed out > >> > >> With the terms(as described in above diagram) fixed, the panel > >> displays correctly without any timeouts. > >> > >> Tested-by: Merlijn Wajer > >> Signed-off-by: Jagan Teki > > > >you should have your SoB here. > > > >All the patches look fine, so there's no need to resend a new > >version. I'll add it if you can give it. > > Sorry, I forgot it. > > Signed-off-by: Icenowy Zheng I've added it, thanks! Maxime --dnkdjwd3j4e57axu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXZwlQwAKCRDj7w1vZxhR xdm4AQDZ6B6LbA9bHrGtPKnKTUahItTfY5X2KySWzxVx2TTmtwEAhtK537tOvQ4p lnirCOMxOFdFdZE0G1regEvis82XyQc= =dnxX -----END PGP SIGNATURE----- --dnkdjwd3j4e57axu-- --===============1329378090670432404== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1329378090670432404==--