From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 751B4C10F14 for ; Tue, 8 Oct 2019 14:31:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48ECB206C2 for ; Tue, 8 Oct 2019 14:31:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FJxFJjyC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48ECB206C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pq/4HOlSZh72VfTtD6WPCbymLqjNoUSXllLSbyvEU5Y=; b=FJxFJjyCAlRWEd T1RWgz6bY9XyI8FnSsfYLVUGt8Dc0y+rM0KFgaYY/k5Vd8YsUpR29MtZdS6hhDP7l9QfICJxOw5pr UbwgXJWngodfQeMHNnbI1sBbrcz9Q+jcOShgcDjDW/8XTwx/DbGPb7biJw+trwz244dSUAjBPolCv 4V6NUer7CqP9lUhgUwod11KPmN2AdwdSCUn1dW75GO3HWx93d1/mclS2T+USA4wsDLZnTXPKZ2u+Z 6vzmXpSNb0omEUMmEdPidLR9TwR2TLiYGmUsE82wKzfnFmTvdTqCi2AwTGg84d4+4e9WWnMMRjHhk DG24wx6/GpQ1CmA8HxZg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHqWU-0004CP-Sd; Tue, 08 Oct 2019 14:31:34 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHqWQ-0004BM-Pz for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2019 14:31:32 +0000 X-Originating-IP: 86.207.98.53 Received: from localhost (aclermont-ferrand-651-1-259-53.w86-207.abo.wanadoo.fr [86.207.98.53]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 56FA7C0007; Tue, 8 Oct 2019 14:31:22 +0000 (UTC) Date: Tue, 8 Oct 2019 16:31:21 +0200 From: Alexandre Belloni To: Michal Simek Subject: Re: [PATCH] rtc: xilinx: Fix calibval variable type Message-ID: <20191008143121.GX4254@piout.net> References: <20765c4c27aa92c75426b82fd2815ebef6471492.1570544738.git.michal.simek@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20765c4c27aa92c75426b82fd2815ebef6471492.1570544738.git.michal.simek@xilinx.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191008_073130_977373_0AB97D32 X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Srinivas Goud , monstr@monstr.eu, Alessandro Zummo , linux-kernel@vger.kernel.org, git@xilinx.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 08/10/2019 16:25:41+0200, Michal Simek wrote: > From: Srinivas Goud > > This patch fixes the warnings reported by static code analysis. > Updated calibval variable type to unsigned type from signed. > > Signed-off-by: Srinivas Goud > Signed-off-by: Michal Simek > --- > > drivers/rtc/rtc-zynqmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c > index 2c762757fb54..da0dbea8def3 100644 > --- a/drivers/rtc/rtc-zynqmp.c > +++ b/drivers/rtc/rtc-zynqmp.c > @@ -44,7 +44,7 @@ struct xlnx_rtc_dev { > void __iomem *reg_base; > int alarm_irq; > int sec_irq; > - int calibval; > + unsigned int calibval; Note that ideally, this varialbe should be removed and replaced by .read_offset and .set_offset callbacks so userspace can properly recalibrate the crystal instead of relying on a static value inside the device tree. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel