From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4E6C4360C for ; Tue, 8 Oct 2019 20:32:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A3D521920 for ; Tue, 8 Oct 2019 20:32:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qP0pPhpi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="to94oEFR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A3D521920 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u9hSjodRVTq2GNotgI9Ig1alNciJsLaa/OTn4cIAj98=; b=qP0pPhpi31SNyH NtfO7AIQgRydmD7MS5REuMVdCEVBFEvusM+v8yerBmorVcabsZCFgP5P8LdYb8eGOkkMZ7FPyW0W+ +9WE7THhPUj58sdWlBf57URKehWAJrDFy/688x8g+tIhj6e78h6qZeiPVFBZoTHqfQDgsj3qY28lU TLsfXXu5E1N98OIxQNExHJwuYtRbazQe/XLi9vtsstqp3JWBzBdjP9W4tclumytJIEPhHI2xPMaEQ a52Myc5Nr+VYR/CrhLQrGqf6Hq4S0HUjiP2T0rKlyx9sKeblhE4ZedFrHyvBqNfP6+tIhKAGO5lBD mAD5BGfz81E1NQOH2wKw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHw9O-00005j-IG; Tue, 08 Oct 2019 20:32:06 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHw9M-000056-BN for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2019 20:32:05 +0000 Received: by mail-pf1-x441.google.com with SMTP id x127so54737pfb.7 for ; Tue, 08 Oct 2019 13:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eG3/KTcN+l0J8/6h6CFjDe7V6XOLu3qvlhIP2AFfrys=; b=to94oEFRu7pxgY2G1Xez6EtBwR0f3yzChiGgys5tcUAprpjiFizEtLFTEfBhUswbwS +b6TW6lVGXl4mLAI4N3auzBq0yZMZCqptNh/Hrja7n2IfTO9vb/N15/IR8y0cnVkil3G XHH3y7a5zxQHC3wZYFFvm7Pqh5HXET1swlIRVWpE9Sywk5HGoA2nEoT+d/8bSrhOPgkA icePHEWyx6ekqLhZHjFp3fBjzhyj7hLulxxnd8XhpqLUycijtMwDhnxpgAq67FKnWR2y vdW6JNefJLtAVnRwzX/hGl9q6hjmdYUGPNbc/S+XjVI42xIfKYKlpbh7fzA40E8l+ekx UnTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eG3/KTcN+l0J8/6h6CFjDe7V6XOLu3qvlhIP2AFfrys=; b=m6skAGNPMuXF9ruC1xb0gLuH7JVI7Kkqr+ZB6nAxa3tfY9LHh4cpwEIZukNHl43EAy bKmRoaFsLrxgYtfqmaqQ/FCRKD0Cvv2oFnT8xUOjLS8AU3Io2y78q/ZnVo3rfx331i8p uOXkj0x2f+0LLjkxijQ8ShdnXst0wCUEbFko0+7piZF3LGSVndtzeCTC5LambVqTRiAj ZHfqiedi8JKQV5df60CRhggcNtYN82lQSCinPt1LeVLQFbzTg2NXxha/gO0nkteR60pi M32ooldOxvaSkYzIsGX8OVrvrUyXMnO/Ni66htN+FjRCddq4WnKqypyhzfcs+aA6J0KI SLmg== X-Gm-Message-State: APjAAAWRyN5r8PY5NCTynovSBPHnZiAo6Bq1M/uLXh6iL0KY+CuyU8Gr ljQciEcKa60xScTBWn4vqudAuw== X-Google-Smtp-Source: APXvYqzuXMuOJlcRChpjsyL5D5qPR+4R8/wPvf3J5IUiMHTYlcl02d8LMjqeowAKe6J+zFd5NRArUw== X-Received: by 2002:a62:e21a:: with SMTP id a26mr6636688pfi.80.1570566723059; Tue, 08 Oct 2019 13:32:03 -0700 (PDT) Received: from google.com ([2620:15c:2cb:1:e90c:8e54:c2b4:29e7]) by smtp.gmail.com with ESMTPSA id r18sm16766pfc.3.2019.10.08.13.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 13:32:02 -0700 (PDT) Date: Tue, 8 Oct 2019 13:31:57 -0700 From: Brendan Higgins To: Jae Hyun Yoo Subject: Re: [PATCH 3/5] i2c: aspeed: fix master pending state handling Message-ID: <20191008203157.GA184092@google.com> References: <20191007231313.4700-1-jae.hyun.yoo@linux.intel.com> <20191007231313.4700-4-jae.hyun.yoo@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191007231313.4700-4-jae.hyun.yoo@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191008_133204_414666_F048DB67 X-CRM114-Status: GOOD ( 10.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Benjamin Herrenschmidt , openbmc@lists.ozlabs.org, Rob Herring , Joel Stanley , Tao Ren , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 07, 2019 at 04:13:11PM -0700, Jae Hyun Yoo wrote: > In case of master pending state, it should not trigger the master > command because this H/W is sharing the same data buffer for slave > and master operations, so this commit fixes the issue with making > the master command triggering happen when the state goes to active > state. nit: Makes sense, but can you explain what might happen without your change? > Signed-off-by: Jae Hyun Yoo Reviewed-by: Brendan Higgins Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel