From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E84DC47404 for ; Wed, 9 Oct 2019 17:51:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D36BA206BB for ; Wed, 9 Oct 2019 17:51:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k0/oddOr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D36BA206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RrhdgEpb4PuKSuFjXrZ+tEggrJgsKA8sy+tgIE2CXpU=; b=k0/oddOrJLiRL3 0cqTYXfqi1DuxZph6kOKkY0ujqqohyDDFXWzuP4YIL+5/x9z9kOX9uFDOS6APtgK+O1JSLMyEyui7 CJIENONRJJr6Xei/26j2ei6umKo5AGEY3lofAv2pzF+vCxInOEtNmpaFPtthoHbq31fVQWOpmtQbt DPTio7H3LiTJde5CjCEIRZMQdXskujiGbLc0zNT892nlxovEUkLdsrAVMnWljPYAhO45Q/Sdv7zUA PxbhBoMvs6cN2r+UFwO7vfQ1wVGR9R+969QJoD4ZT0IDwxNSn75TSBHqaElmKyKtpsTvSD4lIJf+C SwvcxApAd4F3y2rMRMAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIG7s-0000JT-SE; Wed, 09 Oct 2019 17:51:52 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIG7p-0000JD-TI; Wed, 09 Oct 2019 17:51:49 +0000 Date: Wed, 9 Oct 2019 10:51:49 -0700 From: Christoph Hellwig To: Ben Dooks Subject: Re: [PATCH] proc: centralise declaration of cpuinfo_op Message-ID: <20191009175149.GA28540@infradead.org> References: <20191009113930.13236-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191009113930.13236-1-ben.dooks@codethink.co.uk> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@lists.codethink.co.uk, linux-s390@vger.kernel.org, Rich Felker , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , linux-sh@vger.kernel.org, Greg Kroah-Hartman , "H. Peter Anvin" , Heiko Carstens , x86@kernel.org, Aurelien Jacquiot , Ingo Molnar , Borislav Petkov , linux-arm-kernel@lists.infradead.org, Mark Salter , sparclinux@vger.kernel.org, Thomas Gleixner , "David S. Miller" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 09, 2019 at 12:39:30PM +0100, Ben Dooks wrote: > When building for arm, cpuinfo_op generates a warning due > to no declaration. Since this is used in fs/proc/cpuinfo.c > and inconsitently declared across archiectures move the > declaration info . This means that the > cpuinfo_op will have a declaration any place it is used. > > Removes the following sparse warning: > > arch/arm/kernel/setup.c:1320:29: warning: symbol 'cpuinfo_op' was not declared. Should it be static? I like the consolidation, but I don't think seq_file.h is the right place. A procfs or cpu topology related header seems like the better choice. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel