From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB52CC10F14 for ; Thu, 10 Oct 2019 12:29:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B1CB208C3 for ; Thu, 10 Oct 2019 12:29:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I4dFsIhj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="N/F/KjOV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B1CB208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XmYpEvAMZtumG3QIpZ85EmVt63O4+tvYhGrSm6WiKgY=; b=I4dFsIhj7hF18d CWjjSd/UXcv4S4g6rSkqQwjRmj0MBYG/lUOFx474ZJ3F+BfwKp3lIWgWol2HZZ58Tw2RhfWyKeCG9 Ug22kGLrBcndQT27AmY4DiZKI8BrjbFsaVmMI35pa0v+UvQy47ju+IEV6Eb6x+vyLJ2CycyNMChTX FJpagTGJ26CBRdd029JutPNqGwvVSjcB9kXV1EwPYYfFKmdwWOqejaBOGUPYS2w2YIlm9OQeHtcKF 61oMne/YfmvJ/tZQNiDc7KfA/E+j3dCoaeGICdXlw/ZgVNfuGHmaVpL5l841BfXZerHlLDoX3TNDW mdLTr5XzYSDv0qaMVtQg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIXZQ-0006Fg-7x; Thu, 10 Oct 2019 12:29:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIXZN-0006Ew-9P for linux-arm-kernel@lists.infradead.org; Thu, 10 Oct 2019 12:29:26 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16F6B208C3; Thu, 10 Oct 2019 12:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570710564; bh=C8VqkU7v3wAzEbcXleNkpsJR4ud+QMo6al7Q+MPKvkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N/F/KjOV6cASJn2JD5k48WsHyhSM8QESdwogYeixXTZ7i94kLb1vHHW3FEGf0SuVP fykEj5TpaZsDvsF5ja6wNiE6HcNHwb9WuAGyWjzgfNhQF+31u4pQrfFJ38PkMMWUqb QEbGi2GvR7GaAaD1ok2/GbLClzscHgatZ4nHauJg= Date: Thu, 10 Oct 2019 14:29:22 +0200 From: Greg KH To: Suzuki K Poulose Subject: Re: [PATCH] arm64: cpufeature: Fix truncating a feature value Message-ID: <20191010122922.GA720144@kroah.com> References: <20191010110856.4376-1-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_052925_352513_5B679DCA X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 10, 2019 at 12:12:01PM +0100, Suzuki K Poulose wrote: > All, > > On 10/10/2019 12:08, Suzuki K Poulose wrote: > > A signed feature value is truncated to turn to an unsigned value > > causing bad state in the system wide infrastructure. This affects > > the discovery of FP/ASIMD support on arm64. Fix this by making sure > > we cast it properly. > > > > Fixes: 4f0a606bce5ec ("arm64: cpufeature: Track unsigned fields") > > Cc: stable@vger.kernel.org # v4.4 > > Please note that this patch is only applicable for stable 4.4 tree. > I should have removed the Fixes tag. Why is it only for 4.4? That needs to be documented really really really well in the changelog as to why this is a one-off patch, and why we can't just take the relevant patches that are in Linus's tree instead. Please fix up and resend. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel