From: Greg KH <gregkh@linuxfoundation.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: mark.rutland@arm.com, catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] arm64: cpufeature: Fix truncating a feature value
Date: Thu, 10 Oct 2019 15:16:15 +0200 [thread overview]
Message-ID: <20191010131615.GA807662@kroah.com> (raw)
In-Reply-To: <295cfb9e-ac7b-73e7-bc80-8b9150f4a626@arm.com>
On Thu, Oct 10, 2019 at 01:46:21PM +0100, Suzuki K Poulose wrote:
>
>
> On 10/10/2019 13:29, Greg KH wrote:
> > On Thu, Oct 10, 2019 at 12:12:01PM +0100, Suzuki K Poulose wrote:
> > > All,
> > >
> > > On 10/10/2019 12:08, Suzuki K Poulose wrote:
> > > > A signed feature value is truncated to turn to an unsigned value
> > > > causing bad state in the system wide infrastructure. This affects
> > > > the discovery of FP/ASIMD support on arm64. Fix this by making sure
> > > > we cast it properly.
> > > >
> > > > Fixes: 4f0a606bce5ec ("arm64: cpufeature: Track unsigned fields")
> > > > Cc: stable@vger.kernel.org # v4.4
> > >
> > > Please note that this patch is only applicable for stable 4.4 tree.
> > > I should have removed the Fixes tag.
> >
> > Why is it only for 4.4? That needs to be documented really really
>
> This was fixed later in v4.6 onwards with commit 28c5dcb22f90113dea
> ("arm64: Rename cpuid_feature field extract routines") rather inadvertently.
>
> > really well in the changelog as to why this is a one-off patch, and why
> > we can't just take the relevant patches that are in Linus's tree
> > instead.
> >
> > Please fix up and resend.
>
> I can resend the patch with the above information included if you like.
As I said, please do, I can not take it otherwise.
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-10 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 11:08 [PATCH] arm64: cpufeature: Fix truncating a feature value Suzuki K Poulose
2019-10-10 11:12 ` Suzuki K Poulose
2019-10-10 12:29 ` Greg KH
2019-10-10 12:46 ` Suzuki K Poulose
2019-10-10 13:16 ` Greg KH [this message]
2019-10-10 13:19 ` Suzuki K Poulose
2019-10-11 4:55 ` Greg KH
2019-10-11 10:31 ` Suzuki K Poulose
2019-10-11 12:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010131615.GA807662@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=stable@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).