Re: [PATCH v3 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD

Shawn Guo
2019-10-26T08:12:39Z

On Fri, Oct 25, 2019 at 08:07:43PM +0200, Andreas Kemnade wrote:
> Hi,
>
> On Fri, 25 Oct 2019 21:46:24 +0800
> Shawn Guo <shawnguo@kernel.org> wrote:
>
> [...]
> > > +
> > > + pinctrl_wifi_reset: wifi_reset_grp {
> > > + fsl,pins = <
> > > + MX6SLL_PAD_SD2_DATA7__GPIO5_IO00 0x10059 /* WIFI_RST */
> > > + >;
> > > + };
> > > +
> > > + pinctrl_wifi_power: wifi_power_grp {
> >
> > I guess you can have one pinctrl node to include both reset and power
> > pins? Also, to be consistent with other pinctrl nodes on naming, the
> > node name should probably be wifigrp.
> >
> well, the problems they are used in different nodes, so I cannot do
> that:
>
> reg_wifi: regulator-wifi {
> compatible = "regulator-fixed";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_wifi_power>;
> regulator-name = "SD3_SPWR";
> regulator-min-microvolt = <3000000>;
> regulator-max-microvolt = <3000000>;
> gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> };
>
> wifi_pwrseq: wifi_pwrseq {
> compatible = "mmc-pwrseq-simple";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_wifi_reset>;
> post-power-on-delay-ms = <20>;
> reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
> };

Ah, yes, it makes more sense. I missed that.

Shawn

>
> So having them combined breaks the mux where you use it rule.
> I got in earlier mails:
>
> > > + wifi_pwrseq: wifi_pwrseq {
> > > + compatible = "mmc-pwrseq-simple";
> > > + post-power-on-delay-ms = <20>;
> > > + reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
>
> > Can you add a pinctrl-entry here please? The general rule is to mux
> > things where you use it
> [...]
> > > + compatible = "regulator-fixed";
> > > + regulator-name = "SD3_SPWR";
> > > + regulator-min-microvolt = <3000000>;
> > > + regulator-max-microvolt = <3000000>;
> > > +
> > > + gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>;
>
> > Please add a pinctrl here to mux this gpio.
>
> Regards,
> Andreas