Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file

Andreas Kemnade
2019-10-11T15:06:29Z

[-- Attachment #1.1: Type: text/plain, Size: 1968 bytes --]

On Fri, 11 Oct 2019 09:29:27 -0500
Rob Herring <robh@kernel.org> wrote:

> On Fri, Oct 11, 2019 at 09:41:48AM +0200, Andreas Kemnade wrote:
> > On Fri, 11 Oct 2019 08:56:09 +0200
> > Marco Felsch <m.felsch@pengutronix.de> wrote:
> >
> > > Hi Andreas,
> > >
> > > On 19-10-10 21:23, Andreas Kemnade wrote:
> > > > The Netronix board E60K02 can be found some several Ebook-Readers,
> > > > at least the Kobo Clara HD and the Tolino Shine 3. The board
> > > > is equipped with different SoCs requiring different pinmuxes.
> > > >
> > > > For now the following peripherals are included:
> > > > - LED
> > > > - Power Key
> > > > - Cover (gpio via hall sensor)
> > > > - RC5T619 PMIC (the kernel misses support for rtc and charger
> > > > subdevices).
> > > > - Backlight via lm3630a
> > > > - Wifi sdio chip detection (mmc-powerseq and stuff)
> > > >
> > > > It is based on vendor kernel but heavily reworked due to many
> > > > changed bindings.
> > > >
> > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > > ---
> > > > Changes in v3:
> > > > - better led name
> > > > - correct memory size
> > > > - comments about missing devices
> > > >
> > > > Changes in v2:
> > > > - reordered, was 1/3
> > > > - moved pinmuxes to their actual users, not the parents
> > > > of them
> > > > - removed some already-disabled stuff
> > > > - minor cleanups
> > >
> > > You won't change the muxing, so a this dtsi can be self contained?
> > >
> > So you want me to put a big
> > #if defined(MX6SLL)
>
> Not sure what the comment meant, but no, don't do this. C defines in dts
> files are for symbolic names for numbers and assembling bitfields and
> that's it.

yes, that is also my opinion. For now, there is only one user
of this .dtsi, but I have another one in preparation. That is the
reason for splitting things between .dts and .dtsi to avoid such ugly
ifdefs

Regards,
Andreas

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]