From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0B96C47404 for ; Fri, 11 Oct 2019 09:45:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 858BF21A4A for ; Fri, 11 Oct 2019 09:45:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e+a1DDnl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 858BF21A4A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ubuntu.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UVaiDyb3pfx+qbS4CggV0PQDcy3grGqShDVTV241nsk=; b=e+a1DDnlv/8wlR 4cT0S1qurpTMd7SNBCWZgt4SxWgHtc3IaqtH7TPcq13JFzINyO3LClpgz9aENXhvnEAWnQvJUPvif Jeho/20PCOhd8GA2IZ0lngd6HpxRTnGa+nIeQsn22p87ErwGOPImWDCYbvEPDBvlTBLXBx42ahCce fYZ7e++MA0BXRuINaukr6G0U6oecjRRC9gcUEVoiStFO9B/KfnC4mbesNt3DdV20KFFlthrF3cnfV NGW1BVqH25TqZ1CBWNdEOP08PGSVUnKIkpEVnOEstBOtKj7h18JwgpUCFN3VQ7OZ3nh1rLsFV/Fqu BNMth8NI/GfmL2cLYkWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIrUP-0007qH-36; Fri, 11 Oct 2019 09:45:37 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIrUM-0007pF-7r; Fri, 11 Oct 2019 09:45:35 +0000 Received: from v22018046084765073.goodsrv.de ([185.183.158.195] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iIrUH-0004RM-Md; Fri, 11 Oct 2019 09:45:29 +0000 Date: Fri, 11 Oct 2019 11:45:28 +0200 From: Christian Brauner To: Kees Cook Subject: Re: [PATCH v1] seccomp: simplify secure_computing() Message-ID: <20191011094527.ftevtkeitjqafhdd@wittgenstein> References: <20190920131907.6886-1-christian.brauner@ubuntu.com> <20190924064420.6353-1-christian.brauner@ubuntu.com> <201910101450.0B13B7F@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201910101450.0B13B7F@keescook> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191011_024534_418699_97A5F717 X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, wad@chromium.org, linux-parisc@vger.kernel.org, x86@kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, oleg@redhat.com, Borislav Petkov , luto@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 10, 2019 at 02:53:24PM -0700, Kees Cook wrote: > On Tue, Sep 24, 2019 at 08:44:20AM +0200, Christian Brauner wrote: > > Afaict, the struct seccomp_data argument to secure_computing() is unused > > by all current callers. So let's remove it. > > The argument was added in [1]. It was added because having the arch > > supply the syscall arguments used to be faster than having it done by > > secure_computing() (cf. Andy's comment in [2]). This is not true anymore > > though. > > Yes; thanks for cleaning this up! > > > diff --git a/arch/s390/kernel/ptrace.c b/arch/s390/kernel/ptrace.c > > index ad71132374f0..ed80bdfbf5fe 100644 > > --- a/arch/s390/kernel/ptrace.c > > +++ b/arch/s390/kernel/ptrace.c > > @@ -439,7 +439,7 @@ static int poke_user(struct task_struct *child, addr_t addr, addr_t data) > > long arch_ptrace(struct task_struct *child, long request, > > unsigned long addr, unsigned long data) > > { > > - ptrace_area parea; > > + ptrace_area parea; > > int copied, ret; > > > > switch (request) { > > If this were whitespace cleanup in kernel/seccomp.c, I'd take it without > flinching. As this is only tangentially related and in an arch > directory, I've dropped this hunk out of a cowardly fear of causing > (a likely very unlikely) merge conflict. > > I'd rather we globally clean up trailing whitespace at the end of -rc1 > and ask Linus to run some crazy script. :) Oh that was on accident probably. It usally happens because I have vim do whitespace fixups automatically and then they end up slipping in... Sorry. Thanks for removing it! :) Christian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel