From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E936C4360C for ; Sun, 13 Oct 2019 15:08:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11A75206A3 for ; Sun, 13 Oct 2019 15:08:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sbgbTmYK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11A75206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rxLeuXDm2NrgE/15Rwcv/UirInfp+O7SqXiLy7bnWTs=; b=sbgbTmYKQ5jH43YuZtPyrXTYD d6174aEOZsWB+jb5wXLxT10m7/LTr+kRTbEE+QHHsw/mC2eWewp3Q4bAltjiol/TGBVOtopBtCAe+ IimNPhuVLk+2ultChSJcQpyS+9vQWWY8+E/B/oGFpDRg0DwwwIR8PDiAmagNjOUADY69zwkj9ar3x QFFXSwbczV0uZ69u+XUtJsDbHhqcuywNyMpJJTr1ztXFnKdbBUFeAxK31C8uWP37nYYG5DRKr5bBM g74s/kPZBsqBtQ/dTHU7znGLdVoqhJIjDgwtEq6Qjt9db3ZjbTBLGMTJgoyhaxrtUdzIMangm+sgA koeFf1I7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJfTl-00047L-0k; Sun, 13 Oct 2019 15:08:17 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJfTh-00045R-RD for linux-arm-kernel@lists.infradead.org; Sun, 13 Oct 2019 15:08:15 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 3837C80239; Sun, 13 Oct 2019 17:07:56 +0200 (CEST) Date: Sun, 13 Oct 2019 17:08:07 +0200 From: Pavel Machek To: Tony Lindgren Subject: Re: [PATCH 7/8] ARM: OMAP2+: Allow core oswr for omap4 Message-ID: <20191013150806.GE13278@amd> References: <20191010001224.41826-1-tony@atomide.com> <20191010001224.41826-8-tony@atomide.com> MIME-Version: 1.0 In-Reply-To: <20191010001224.41826-8-tony@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191013_080814_030066_0B113D28 X-CRM114-Status: GOOD ( 13.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Merlijn Wajer , linux-omap@vger.kernel.org, Sebastian Reichel , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5302955438175212347==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5302955438175212347== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vmttodhTwj0NAgWp" Content-Disposition: inline --vmttodhTwj0NAgWp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2019-10-09 17:12:23, Tony Lindgren wrote: > Commit f74297dd9354 ("ARM: OMAP2+: Make sure LOGICRETSTATE bits are not > cleared") disabled oswr (open switch retention) for per and core domains > as various GPIO related issues were noticed if the bootloader had > configured the bits for LOGICRETSTATE for per and core domains. >=20 > With the recent gpio-omap fixes, mostly related to commit e6818d29ea15 > ("gpio: gpio-omap: configure edge detection for level IRQs for idle > wakeup"), things now behave for enabling core oswr for omap4. >=20 > Cc: Merlijn Wajer > Cc: Pavel Machek > Cc: Sebastian Reichel > Signed-off-by: Tony Lindgren 2,7,8 basically modify same lines of code? Should that be done in one patch? Best regards, Pavel > =20 > - /* > - * Bootloader or kexec boot may have LOGICRETSTATE cleared > - * for some domains. This is the case when kexec booting from > - * Android kernels that support off mode for example. > - * Make sure it's set at least for core and per, otherwise > - * we currently will see lost GPIO interrupts for wlcore and > - * smsc911x at least if per hits retention during idle. > - */ > - if (!strncmp(pwrdm->name, "core", 4) > - pwrdm_set_logic_retst(pwrdm, PWRDM_POWER_RET); > - > - if (!strncmp(pwrdm->name, "l4per", 5) > + if (!strncmp(pwrdm->name, "core", 4) || > + !strncmp(pwrdm->name, "l4per", 5)) > pwrdm_set_logic_retst(pwrdm, PWRDM_POWER_OFF); > =20 > pwrst =3D kmalloc(sizeof(struct power_state), GFP_ATOMIC); --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --vmttodhTwj0NAgWp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl2jPdYACgkQMOfwapXb+vIJzACeMNSoapkU3z/f5DKDV6Y0WjlP 2mUAoJQ12bblkgVJi+y4SH2xOqtXPW2x =yYl4 -----END PGP SIGNATURE----- --vmttodhTwj0NAgWp-- --===============5302955438175212347== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5302955438175212347==--