From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFAB8C4CECE for ; Sun, 13 Oct 2019 19:10:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BA8D20679 for ; Sun, 13 Oct 2019 19:10:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HJPWSrdg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rnt3TaLC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BA8D20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+W2EAqnBSseaSgaBbk2z14hUizP6bCMtZ4Rw6C1mxgE=; b=HJPWSrdglNxcqr pFucCRcvUoDUMCRYjxa/O5gjYTeluqpuym7hwhixJRS701WJaeYZHa3ATVeF1HCxkXYu/yckx8cd/ Y7GwyzmD7BaVPRXwtKjAxExAkHq/nWt90scx3hKHsZzkFqylrtJtMe/TtmnpCfCXEeG4iyLc7uZQa lsdkQb/QXDDEA+SAjF4wxQKoH4ojUGcnZ5n1yW8IRPRBS27COOZembPlfriGm+HZYYlcoqZ+pIjo+ Sor4uFs2cGRCKYN1dRG1T6JOvU+1ubO6ukH2fvRnu8OHgG6bhxQWfKBL/lfwByLVsGFV6GfdwBVRt 3NV9zWNyvtstMKf0NHaQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJjGW-0004ve-JW; Sun, 13 Oct 2019 19:10:52 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJjGT-0004tz-0r; Sun, 13 Oct 2019 19:10:50 +0000 Received: by mail-pg1-x543.google.com with SMTP id f14so3661174pgi.9; Sun, 13 Oct 2019 12:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b80mjczMKdynxDiqihftIRC/nvOfe2fufAmH1zUWecg=; b=Rnt3TaLC3t5HfsHxd7aOpUWt1ltyyk0x1kQ4RXg7fRL316JzXDZRbp2fDirHoNbT+p TkG0KrYAXKYZNnszzkD7/wFIkEvaGtbd6sfhQ9e1SXbZgrRjSeI1ZAOdRbbwp9vIhfgU iCEGzzxe/taIIbL0bD56GdvxKmVDDlcE1Vnjet4RvBSzT7GlQ3a+GswEBA7O057MD433 sZzmLWGxZq9bfq5CEi4K3+GMVHY/tdb7BA11kXrydINEflM9jUm+rQRyrwdTux7LKIgh h/gqD6dw+6LHAe+ajJrvsqNJBYbke0Zs0T56BFwmnZGs7Hz0ldSo7y/uJhwQpGC8aFmR 0o5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b80mjczMKdynxDiqihftIRC/nvOfe2fufAmH1zUWecg=; b=OyY0JugCHbBiKjMlthNv/BF2gYIyr5/48YoWYJKj5dVhg5aMrzmdkQKo2wt55++bsL nfhMUPJd7MuBX10EYCXggYZI0uaoVC83nj0cHU2JuxzsdPvY8QaHva07FolPaD9FA8qB 5t4UIxqEy8JElKVu+M/nUpAmDHoDRGxFOo2f7M9HQP2FAZQHOLS4e8TL32pj/U0PcxAk OhIFTV6PCScbXaisX7tam58ud8RKGm3cLICz69wDRZJnphrxK0omUxabnrQMXCzQnxk0 DwK7F1M5r3KdATx9vGE5h7opLyv5zIb2rnOHSet8mu0zKfjgznTAnxgo+I/9l5Q0Pkz2 moBQ== X-Gm-Message-State: APjAAAVjm1JO+8Wq8EneQsdQX66dja/7qly7PCMtZzOSjl7f6Ox0jliz bXHiYpKG2rZPNGz3WyIgGpI= X-Google-Smtp-Source: APXvYqxQzbjm7g/LJpdZWfeo4Uaggr8/CzxmLN7hdm1fYG9ceaKdu+4kP3AREI2KrAAK0x40piPAqg== X-Received: by 2002:a17:90a:bc41:: with SMTP id t1mr31936123pjv.67.1570993846203; Sun, 13 Oct 2019 12:10:46 -0700 (PDT) Received: from wambui.zuku.co.ke ([197.237.61.225]) by smtp.googlemail.com with ESMTPSA id m5sm15261216pgt.15.2019.10.13.12.10.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Oct 2019 12:10:45 -0700 (PDT) From: Wambui Karuga To: outreachy-kernel@googlegroups.com Subject: [PATCH v2] staging: rtl8723bs: use DIV_ROUND_UP helper macro Date: Sun, 13 Oct 2019 22:10:27 +0300 Message-Id: <20191013191027.6470-1-wambui.karugax@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191013_121049_087657_063541D2 X-CRM114-Status: UNSURE ( 9.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, eric@anholt.net, bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use the DIV_ROUND_UP macro to replace open-coded divisor calculation to improve readability. Issue found using coccinelle: @@ expression n,d; @@ ( - ((n + d - 1) / d) + DIV_ROUND_UP(n,d) | - ((n + (d - 1)) / d) + DIV_ROUND_UP(n,d) ) Signed-off-by: Wambui Karuga --- Changes in v2: - Remove comment that explained previously used calculation. --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index 87535a4c2e14..22931ab3a5fc 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -4156,9 +4156,8 @@ void SetHwReg8723B(struct adapter *padapter, u8 variable, u8 *val) break; } - /* The value of ((usNavUpper + HAL_NAV_UPPER_UNIT_8723B - 1) / HAL_NAV_UPPER_UNIT_8723B) */ - /* is getting the upper integer. */ - usNavUpper = (usNavUpper + HAL_NAV_UPPER_UNIT_8723B - 1) / HAL_NAV_UPPER_UNIT_8723B; + usNavUpper = DIV_ROUND_UP(usNavUpper, + HAL_NAV_UPPER_UNIT_8723B); rtw_write8(padapter, REG_NAV_UPPER, (u8)usNavUpper); } break; -- 2.23.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel