From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB13C4CECE for ; Mon, 14 Oct 2019 08:02:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2B002083B for ; Mon, 14 Oct 2019 08:02:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pA1fP6o4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="KvNVoXYn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2B002083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qVPKMQW9hOcgFlA3MLCcJ4HMgQQNE1CexSGguwHMr9Q=; b=pA1fP6o4BD41CP OAtZlWWHBJYu6oNl8q8iS579V5IoyWhYEzmR3GZV2FbdpolDMxe8frk5Af+Qm+xl71Jo4lFOZYhlJ 5cQj6krqJr1IepKqKy6po6B1L5TKb/DPHXCUwa+KbYmYiAuCjj0fUnGa431FHR7xhhQMESCkLecZg P6Y6fynnlihpmpJLIfpH1C5SHk0A6dDS+sBoqQI1lzY1W3JdNeCXpABDnlWepYel/dTfyesHl4umJ VHlfu7LFWz29nvWP4c7mzORo0coVQCYcjSuRrwsWxla67Wo0we8dSuMEBs1hS/yKXZG5h/0gCiBXh T+Eel8KAqYMCGmJqJY3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJvJD-0004pq-Lp; Mon, 14 Oct 2019 08:02:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJvJA-0004pG-12 for linux-arm-kernel@lists.infradead.org; Mon, 14 Oct 2019 08:02:25 +0000 Received: from localhost (unknown [122.167.124.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCB2E20650; Mon, 14 Oct 2019 08:02:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571040143; bh=gjZ84eYSKyLRBQDVS9KkAvi+i1YmiBvyGp7N1fgos5s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KvNVoXYnE0Q/XbEnPebDW7zr35L3h2rMEjoshhFGj9G1vtitr68yRsxgzF774tF9v gHgeSDlq6C6KyhQsnW5FfGO2DdV4mB7KouXRCTwqOOcHXypFbfInX0bYAf5/XhCw2x QRKuqxaIJSz4+Zhoma8EH8FyaZ9z0wAbEWjERpzo= Date: Mon, 14 Oct 2019 13:32:15 +0530 From: Vinod Koul To: Robin Gong Subject: Re: [PATCH v1] dmaengine: imx-sdma: fix kernel hangs with SLUB slab allocator Message-ID: <20191014080215.GL2654@vkoul-mobl> References: <1569347584-3478-1-git-send-email-yibin.gong@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1569347584-3478-1-git-send-email-yibin.gong@nxp.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191014_010224_094503_CB66259C X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "dmaengine@vger.kernel.org" , "dan.j.williams@intel.com" , "festevam@gmail.com" , "J.Lambrecht@TELEVIC.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-09-19, 09:49, Robin Gong wrote: > Illegal memory will be touch if SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V3 > (41) exceed the size of structure sdma_script_start_addrs(40), > thus cause memory corrupt such as slob block header so that kernel > trap into while() loop forever in slob_free(). Please refer to below > code piece in imx-sdma.c: > for (i = 0; i < sdma->script_number; i++) > if (addr_arr[i] > 0) > saddr_arr[i] = addr_arr[i]; /* memory corrupt here */ > That issue was brought by commit a572460be9cf ("dmaengine: imx-sdma: Add > support for version 3 firmware") because SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V3 > (38->41 3 scripts added) not align with script number added in > sdma_script_start_addrs(2 scripts). Applied, thanks -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel