From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5AA5ECE587 for ; Mon, 14 Oct 2019 08:05:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76E2B2054F for ; Mon, 14 Oct 2019 08:05:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XThZFZik"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0HX2BXwB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76E2B2054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K8KQTIDkGuMdiUtYTJRgw/KaNKLvpfmDYSprVxG4fc4=; b=XThZFZikDgiJ2T +ZD7l/lqV2cUA5Bg7QexkGr6867SNFRXspsgKxyhghxBMDCGkREJOnWrUVVH7UJFTeA5AAxRTiIhn OAyWVipsM2JruigT7TItdjw8PMuh2q214PcCupUodJy20OKu770j5XBQ5AWahIPGbxtuANesn2TOb 2PJylGJBhUMFnAXf5B+wPO4AnLUL5KyKXdXO/LKMcsRXrdaOOpL5HVIJNvE2AJtMwGlZixKE3KQWJ tTD8xgDAfdJ0bQkMomCtvnBJM/6WscoaApwLQthlnZe/lmiaMZNUFmjhQuIAawPZ947Mldk+Vo6Xe pmI0Y/R+EwPl4XDIMiiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJvMW-0006kL-El; Mon, 14 Oct 2019 08:05:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iJvMT-0006jq-8P for linux-arm-kernel@lists.infradead.org; Mon, 14 Oct 2019 08:05:50 +0000 Received: from localhost (unknown [122.167.124.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EC802054F; Mon, 14 Oct 2019 08:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571040348; bh=JMX1LApY2fbKeVzv4AKmUzSaxbEE2mGrMc7ILY5Utmc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0HX2BXwBBUVV6EdFcDo4PS3xZqvONejrn/66/Ku4UC2V64qZHV/jxFo+KCNiX6hlm Bo0H90rxwYt9Gfhi5DTuBZjNx5l3SP+sAE1qPoUNivDYdOBs5i3rf/jwZVV55t3fe2 pHNsxzdfIhJtHxQuNRZDdojM3EnLMsDbsASy6uv8= Date: Mon, 14 Oct 2019 13:35:44 +0530 From: Vinod Koul To: Robin Gong Subject: Re: [PATCH v1] dmaengine: imx-sdma: fix kernel hangs with SLUB slab allocator Message-ID: <20191014080544.GM2654@vkoul-mobl> References: <1569347584-3478-1-git-send-email-yibin.gong@nxp.com> <20191014080215.GL2654@vkoul-mobl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191014080215.GL2654@vkoul-mobl> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191014_010549_316894_54F8A115 X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "dmaengine@vger.kernel.org" , "dan.j.williams@intel.com" , "festevam@gmail.com" , "J.Lambrecht@TELEVIC.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14-10-19, 13:32, Vinod Koul wrote: > On 24-09-19, 09:49, Robin Gong wrote: > > Illegal memory will be touch if SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V3 > > (41) exceed the size of structure sdma_script_start_addrs(40), > > thus cause memory corrupt such as slob block header so that kernel > > trap into while() loop forever in slob_free(). Please refer to below > > code piece in imx-sdma.c: > > for (i = 0; i < sdma->script_number; i++) > > if (addr_arr[i] > 0) > > saddr_arr[i] = addr_arr[i]; /* memory corrupt here */ > > That issue was brought by commit a572460be9cf ("dmaengine: imx-sdma: Add > > support for version 3 firmware") because SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V3 > > (38->41 3 scripts added) not align with script number added in > > sdma_script_start_addrs(2 scripts). > > Applied, thanks And after applying I noticed the patch title is not apt. The patch title should reflect the change and not the cause or result. So I have modified the title to: "dmaengine: imx-sdma: fix size check for sdma script_number" Thanks -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel