* [PATCH] arm: add kernel/fork.c function definitions @ 2019-10-09 14:06 Ben Dooks 2019-10-09 15:33 ` Christoph Hellwig 0 siblings, 1 reply; 4+ messages in thread From: Ben Dooks @ 2019-10-09 14:06 UTC (permalink / raw) To: linux-kernel; +Cc: Ben Dooks, Russell King, linux-arm-kernel, linux-kernel Add the definitions of arch_release_task_struct, arch_task_cache_init and arch_dup_task_struct which are used in kernel/fork.c but defined in various architecture's <asm/thread_info.h>. Fixes the following warnings: kernel/fork.c:160:13: warning: symbol 'arch_release_task_struct' was not declared. Should it be static? kernel/fork.c:752:20: warning: symbol 'arch_task_cache_init' was not declared. Should it be static? kernel/fork.c:841:12: warning: symbol 'arch_dup_task_struct' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Russell King <linux@armlinux.org.uk> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/include/asm/thread_info.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/include/asm/thread_info.h b/arch/arm/include/asm/thread_info.h index 0d0d5178e2c3..3d65d152dd19 100644 --- a/arch/arm/include/asm/thread_info.h +++ b/arch/arm/include/asm/thread_info.h @@ -118,6 +118,11 @@ extern void iwmmxt_task_switch(struct thread_info *); extern void vfp_sync_hwstate(struct thread_info *); extern void vfp_flush_hwstate(struct thread_info *); +/* for kernel/fork.c */ +extern void arch_release_task_struct(struct task_struct *tsk); +extern void arch_task_cache_init(void); +extern int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src); + struct user_vfp; struct user_vfp_exc; -- 2.23.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: add kernel/fork.c function definitions 2019-10-09 14:06 [PATCH] arm: add kernel/fork.c function definitions Ben Dooks @ 2019-10-09 15:33 ` Christoph Hellwig 2019-10-11 13:44 ` Ben Dooks 0 siblings, 1 reply; 4+ messages in thread From: Christoph Hellwig @ 2019-10-09 15:33 UTC (permalink / raw) To: Ben Dooks; +Cc: linux-kernel, Russell King, linux-arm-kernel, linux-kernel On Wed, Oct 09, 2019 at 03:06:37PM +0100, Ben Dooks wrote: > Add the definitions of arch_release_task_struct, > arch_task_cache_init and arch_dup_task_struct which > are used in kernel/fork.c but defined in various > architecture's <asm/thread_info.h>. So please lift them into a common header. In fact I'm pretty sure I had that comment before when people did the same blind sparse cleanups for riscv.. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: add kernel/fork.c function definitions 2019-10-09 15:33 ` Christoph Hellwig @ 2019-10-11 13:44 ` Ben Dooks 2019-10-14 16:17 ` Christoph Hellwig 0 siblings, 1 reply; 4+ messages in thread From: Ben Dooks @ 2019-10-11 13:44 UTC (permalink / raw) To: Christoph Hellwig Cc: linux-kernel, Russell King, linux-arm-kernel, linux-kernel On 09/10/2019 16:33, Christoph Hellwig wrote: > On Wed, Oct 09, 2019 at 03:06:37PM +0100, Ben Dooks wrote: >> Add the definitions of arch_release_task_struct, >> arch_task_cache_init and arch_dup_task_struct which >> are used in kernel/fork.c but defined in various >> architecture's <asm/thread_info.h>. > > So please lift them into a common header. In fact I'm pretty sure > I had that comment before when people did the same blind sparse > cleanups for riscv.. Does anyone have a preference to where these should go? -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: add kernel/fork.c function definitions 2019-10-11 13:44 ` Ben Dooks @ 2019-10-14 16:17 ` Christoph Hellwig 0 siblings, 0 replies; 4+ messages in thread From: Christoph Hellwig @ 2019-10-14 16:17 UTC (permalink / raw) To: Ben Dooks Cc: Christoph Hellwig, linux-kernel, Russell King, linux-arm-kernel, linux-kernel On Fri, Oct 11, 2019 at 02:44:25PM +0100, Ben Dooks wrote: > Does anyone have a preference to where these should go? Maybe include/linux/thread_info.h ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-14 16:17 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-10-09 14:06 [PATCH] arm: add kernel/fork.c function definitions Ben Dooks 2019-10-09 15:33 ` Christoph Hellwig 2019-10-11 13:44 ` Ben Dooks 2019-10-14 16:17 ` Christoph Hellwig
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).