From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D841ECE588 for ; Tue, 15 Oct 2019 10:46:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A9B12089C for ; Tue, 15 Oct 2019 10:46:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OVKfGpIK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A9B12089C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hwqhn2pQOKcJyLN8b/uzojP7kl/61uVzsR+LPwOzbAs=; b=OVKfGpIK+lCxRU vPHN66kexPe3joRC5Mmnt4ICllXwkBrFB2OMYyQwA6u+FF9wW2fgTJAl43I41t6ZjdstJ2IxRtrY2 hDQlCBnHCtwyPEf6HiaJfnpdEq2jWsThNlXqumLqRVmkzb9bkayztRucQlCq4G5o4Eyl7k3i0tdIJ jmAFlk9ZPrB8VSQEHjyfSwnwcF0FKwHm7VPUK24K0KyRIsOMdcssLt5FBFrqrbOSPKu0HAWv2Ouy7 I2F1Sj+cBcH6Q17jnmpmUOE8hjScyGRCy6P8y9XtsfjS8n+WZxh3FHhVTTPl8FUj2wHhSwPXOVrjS Ncmanaw9SDaifUCDRxqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKKL6-0004Nv-L7; Tue, 15 Oct 2019 10:46:04 +0000 Received: from 8bytes.org ([81.169.241.247] helo=theia.8bytes.org) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKKL3-0004LP-4l; Tue, 15 Oct 2019 10:46:02 +0000 Received: by theia.8bytes.org (Postfix, from userid 1000) id 3E5212D9; Tue, 15 Oct 2019 12:45:48 +0200 (CEST) Date: Tue, 15 Oct 2019 12:45:46 +0200 From: Joerg Roedel To: Heiko Stuebner Subject: Re: [PATCH] iommu/rockchip: don't use platform_get_irq to implicitly count irqs Message-ID: <20191015104546.GD14518@8bytes.org> References: <20190925184346.14121-1-heiko@sntech.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190925184346.14121-1-heiko@sntech.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191015_034601_334683_A613694E X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rockchip@lists.infradead.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 25, 2019 at 08:43:46PM +0200, Heiko Stuebner wrote: > Till now the Rockchip iommu driver walked through the irq list via > platform_get_irq() until it encountered an ENXIO error. With the > recent change to add a central error message, this always results > in such an error for each iommu on probe and shutdown. > > To not confuse people, switch to platform_count_irqs() to get the > actual number of interrupts before walking through them. > > Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") > Signed-off-by: Heiko Stuebner > --- > drivers/iommu/rockchip-iommu.c | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) Applied for v5.4, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel