From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 542B1ECE588 for ; Tue, 15 Oct 2019 11:03:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 218C12086A for ; Tue, 15 Oct 2019 11:03:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R+kKrw1H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 218C12086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uIJyL/MCl9g962TqkcttKMzCRRxNtjnlCqleU1vpbls=; b=R+kKrw1HJyeTiL 1rSy/ltkOFKye1ZCXhMUK5SP+4yCJms1YfPzhQpfQlXBFZFle8NaCrWSGbV/OSyYnxpTwKQ8pcp5I ghO8Q28DOqUyk+h0lOt36AuChkNTVsB5SfgK0KiRHK2uwHozPdkvYf5sUJjFXTWSXKOeB0Cr17JBs HPeYUPxoT+DXOapvsynZxlTbtF/tsMU2OqXlCiHAoFWLCRqqCoxaqOhqhAU6vdtbeYI8ODyKMRGqz GjagIoMh7fHRrI2Pp7kYKT3aKlWiKrZPI+fiuWoNcjSCdGnz6iQELlH0Wu0j7BtXXsebvAJoBEi8p 1Y8djA9omlDMudm4bRrQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKKba-00035T-5c; Tue, 15 Oct 2019 11:03:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKKbW-00034O-9G for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2019 11:03:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D119A28; Tue, 15 Oct 2019 04:02:59 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CED563F68E; Tue, 15 Oct 2019 04:02:58 -0700 (PDT) Date: Tue, 15 Oct 2019 12:02:54 +0100 From: Lorenzo Pieralisi To: Rob Herring Subject: Re: [PATCH 02/11] PCI: altera: Use pci_parse_request_of_pci_ranges() Message-ID: <20191015110254.GA5160@e121166-lin.cambridge.arm.com> References: <20190924214630.12817-1-robh@kernel.org> <20190924214630.12817-3-robh@kernel.org> <20190925102423.GR9720@e119886-lin.cambridge.arm.com> <20190930151346.GD42880@e119886-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191015_040302_367032_D1E2583F X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: PCI , rfi@lists.rocketboards.org, Ley Foon Tan , Bjorn Helgaas , Andrew Murray , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 30, 2019 at 12:36:22PM -0500, Rob Herring wrote: > On Mon, Sep 30, 2019 at 10:13 AM Andrew Murray wrote: > > > > On Wed, Sep 25, 2019 at 07:33:35AM -0500, Rob Herring wrote: > > > On Wed, Sep 25, 2019 at 5:24 AM Andrew Murray wrote: > > > > > > > > On Tue, Sep 24, 2019 at 04:46:21PM -0500, Rob Herring wrote: > > > > > Convert altera host bridge to use the common > > > > > pci_parse_request_of_pci_ranges(). > > > > > > > > > > Cc: Ley Foon Tan > > > > > Cc: Lorenzo Pieralisi > > > > > Cc: Bjorn Helgaas > > > > > Cc: rfi@lists.rocketboards.org > > > > > Signed-off-by: Rob Herring > > > > > --- > > > > > > > > @@ -833,9 +800,8 @@ static int altera_pcie_probe(struct platform_device *pdev) > > > > > return ret; > > > > > } > > > > > > > > > > - INIT_LIST_HEAD(&pcie->resources); > > > > > - > > > > > - ret = altera_pcie_parse_request_of_pci_ranges(pcie); > > > > > + ret = pci_parse_request_of_pci_ranges(dev, &pcie->resources, > > > > > > > > Does it matter that we now map any given IO ranges whereas we didn't > > > > previously? > > > > > > > > As far as I can tell there are no users that pass an IO range, if they > > > > did then with the existing code the probe would fail and they'd get > > > > a "I/O range found for %pOF. Please provide an io_base pointer...". > > > > However with the new code if any IO range was given (which would > > > > probably represent a misconfiguration), then we'd proceed to map the > > > > IO range. When that IO is used, who knows what would happen. > > > > > > Yeah, I'm assuming that the DT doesn't have an IO range if IO is not > > > supported. IMO, it is not the kernel's job to validate the DT. > > > > Sure. Is it worth mentioning in the commit message this subtle change > > in behaviour? > > Will do. Hi Rob, I would like to merge this series, are you resending it ? It does not apply to v5.4-rc1, if you rebase it please also update this patch log, as per comments above (I can do it too but if you resend it there is no point). Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel