From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7772CECE59D for ; Tue, 15 Oct 2019 22:04:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BD262084B for ; Tue, 15 Oct 2019 22:04:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uBHs2T5k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BD262084B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=breakpoint.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3iP4Mla3ch/P2qHWxwwb33RPgXZu7/Qg6HgbK3bZVUo=; b=uBHs2T5kGzR3vv rAdUcYMkImz0vrq14jiXFQ8N0KGhM24dnfhyRqJHGWaNaNPo2USBOdlIUqXUh7ofMcYH4qAx3tE6B jvLWsNlGVBSGPbeY5lLdmim97Rq10OA2w8f3t5gSfr9gOwRkWrjpa/9dE3JdIb/JS8gFaSm6+fOkg T/CrLcU9pVLEeNKBbt+cHULZpXp5w604gENay6+DiOe9yWBlFrOqqmcCTJ+4MegVycOdQVsehg4e1 25c+QiCJU2XkSLY2vDhp3JSEjCc/RAo8SHih8qNeGLbwJicxVtCvOOOfsijvbIYHLizmuTm6YG88q QEeg+4lkOTBatA/UvDSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKUvj-0002XG-Lg; Tue, 15 Oct 2019 22:04:35 +0000 Received: from chamillionaire.breakpoint.cc ([2a0a:51c0:0:12e:520::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKUvg-0002W3-IM for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2019 22:04:33 +0000 Received: from bigeasy by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1iKUvV-00077j-6y; Wed, 16 Oct 2019 00:04:21 +0200 Date: Wed, 16 Oct 2019 00:04:21 +0200 From: Sebastian Andrzej Siewior To: Arnd Bergmann Subject: Re: [PATCH 6/6] ARM: Inline locking functions for !PREEMPTION Message-ID: <20191015220420.lisfkqd4lfpiyd7h@flow> References: <20191013221310.30748-1-sebastian@breakpoint.cc> <20191013221310.30748-7-sebastian@breakpoint.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191015_150432_604957_66582F53 X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Russell King , Ingo Molnar , Waiman Long , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019-10-14 09:43:53 [+0200], Arnd Bergmann wrote: > On Mon, Oct 14, 2019 at 12:14 AM Sebastian Andrzej Siewior > wrote: > > > > On non-preemptive kernels, the locking instruction is less than 64 bytes > > and it makes sense to inline it. With PREEMPTION the kernel becomes very > > big if the locks are inlined. > > > > Signed-off-by: Sebastian Andrzej Siewior > > --- > > At the moment, we have two architectures selecting all 28 symbols > and you are adding a third, all other architecture select none of them. > > This tells me that the configurability has gone a little overboard. How about > adding a shortcut ARCH_INLINE_ALL_SPINLOCKS that selects the 28 > symbols and using that for arm/arm64/s390? Sounds reasonable. > Also, the output of 'size vmlinux' before and after the patch for > multi_v7_defconfig would be useful to have in the changelog, as there > are a couple of platforms that are particularly sensitive to object code > size changes. okay. > Arnd Sebastian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel