* [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops
@ 2019-10-08 12:34 Ben Dooks
2019-10-08 12:34 ` [PATCH 02/11] ARM: bcm: fix missing __iomem in bcm_kona_smc.c Ben Dooks
` (11 more replies)
0 siblings, 12 replies; 15+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-kernel, Florian Fainelli, Scott Branden, Ray Jui, Ben Dooks,
bcm-kernel-feedback-list
Include platsmp.h for the definition of bcm2836_smp_ops to fix
the following warning:
arch/arm/mach-bcm/platsmp.c:334:29: warning: symbol 'bcm2836_smp_ops' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
---
arch/arm/mach-bcm/platsmp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
index 47f8053d0240..21400b3fa5fe 100644
--- a/arch/arm/mach-bcm/platsmp.c
+++ b/arch/arm/mach-bcm/platsmp.c
@@ -22,6 +22,8 @@
#include <asm/smp_plat.h>
#include <asm/smp_scu.h>
+#include "platsmp.h"
+
/* Size of mapped Cortex A9 SCU address space */
#define CORTEX_A9_SCU_SIZE 0x58
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 02/11] ARM: bcm: fix missing __iomem in bcm_kona_smc.c
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
@ 2019-10-08 12:34 ` Ben Dooks
2019-10-08 17:57 ` Scott Branden
2019-10-15 23:16 ` Florian Fainelli
2019-10-08 12:34 ` [PATCH 03/11] ARM: highbank: include local core.h for highbank_pm_init Ben Dooks
` (10 subsequent siblings)
11 siblings, 2 replies; 15+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-kernel, Florian Fainelli, Scott Branden, Ray Jui, Ben Dooks,
bcm-kernel-feedback-list
Fix the following sparse warnings from a missing __iomem
in __bcm_kona_smc() function by adding __iomem attriubte.
arch/arm/mach-bcm/bcm_kona_smc.c:143:21: warning: incorrect type in initializer (different address spaces)
arch/arm/mach-bcm/bcm_kona_smc.c:143:21: expected unsigned int [usertype] *args
arch/arm/mach-bcm/bcm_kona_smc.c:143:21: got void [noderef] <asn:2> *static [toplevel] [assigned] bcm_smc
_buffer
arch/arm/mach-bcm/bcm_kona_smc.c:149:9: warning: incorrect type in argument 2 (different address spaces)
arch/arm/mach-bcm/bcm_kona_smc.c:149:9: expected void volatile [noderef] <asn:2> *addr
arch/arm/mach-bcm/bcm_kona_smc.c:149:9: got unsigned int [usertype] *
arch/arm/mach-bcm/bcm_kona_smc.c:150:9: warning: incorrect type in argument 2 (different address spaces)
arch/arm/mach-bcm/bcm_kona_smc.c:150:9: expected void volatile [noderef] <asn:2> *addr
arch/arm/mach-bcm/bcm_kona_smc.c:150:9: got unsigned int [usertype] *
arch/arm/mach-bcm/bcm_kona_smc.c:151:9: warning: incorrect type in argument 2 (different address spaces)
arch/arm/mach-bcm/bcm_kona_smc.c:151:9: expected void volatile [noderef] <asn:2> *addr
arch/arm/mach-bcm/bcm_kona_smc.c:151:9: got unsigned int [usertype] *
arch/arm/mach-bcm/bcm_kona_smc.c:152:9: warning: incorrect type in argument 2 (different address spaces)
arch/arm/mach-bcm/bcm_kona_smc.c:152:9: expected void volatile [noderef] <asn:2> *addr
arch/arm/mach-bcm/bcm_kona_smc.c:152:9: got unsigned int [usertype] *[assigned] args
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
---
arch/arm/mach-bcm/bcm_kona_smc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c
index 541e850a736c..43a16f922b53 100644
--- a/arch/arm/mach-bcm/bcm_kona_smc.c
+++ b/arch/arm/mach-bcm/bcm_kona_smc.c
@@ -140,7 +140,7 @@ static int bcm_kona_do_smc(u32 service_id, u32 buffer_phys)
static void __bcm_kona_smc(void *info)
{
struct bcm_kona_smc_data *data = info;
- u32 *args = bcm_smc_buffer;
+ u32 __iomem *args = bcm_smc_buffer;
BUG_ON(smp_processor_id() != 0);
BUG_ON(!args);
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 03/11] ARM: highbank: include local core.h for highbank_pm_init
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
2019-10-08 12:34 ` [PATCH 02/11] ARM: bcm: fix missing __iomem in bcm_kona_smc.c Ben Dooks
@ 2019-10-08 12:34 ` Ben Dooks
2019-10-08 12:34 ` [PATCH 04/11] ARM: meson: use NULL instead of 0 for pointer Ben Dooks
` (9 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel, Rob Herring, Ben Dooks
Fix missing declaration of highbank_pm_init by including core.h.
arch/arm/mach-highbank/pm.c:43:13: warning: symbol 'highbank_pm_init' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Rob Herring <robh@kernel.org>
---
arch/arm/mach-highbank/pm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-highbank/pm.c b/arch/arm/mach-highbank/pm.c
index 561941baeda9..3fdbdb83113b 100644
--- a/arch/arm/mach-highbank/pm.c
+++ b/arch/arm/mach-highbank/pm.c
@@ -12,6 +12,8 @@
#include <uapi/linux/psci.h>
+#include "core.h"
+
#define HIGHBANK_SUSPEND_PARAM \
((0 << PSCI_0_2_POWER_STATE_ID_SHIFT) | \
(1 << PSCI_0_2_POWER_STATE_AFFL_SHIFT) | \
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 04/11] ARM: meson: use NULL instead of 0 for pointer
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
2019-10-08 12:34 ` [PATCH 02/11] ARM: bcm: fix missing __iomem in bcm_kona_smc.c Ben Dooks
2019-10-08 12:34 ` [PATCH 03/11] ARM: highbank: include local core.h for highbank_pm_init Ben Dooks
@ 2019-10-08 12:34 ` Ben Dooks
2019-10-08 12:34 ` [PATCH 05/11] arm: mediatek: force type of mtk_smp_base Ben Dooks
` (8 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel, Kevin Hilman, Ben Dooks, linux-amlogic
Fix the second argument of of_get_cpu_node which is a pointer
being passed a plain 0 by using NULL instead. Fixes the following
warning:
arch/arm/mach-meson/platsmp.c:40:55: warning: Using plain integer as NULL pointer
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
CC: Kevin Hilman <khilman@baylibre.com>
CC: linux-amlogic@lists.infradead.org
---
arch/arm/mach-meson/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-meson/platsmp.c b/arch/arm/mach-meson/platsmp.c
index 4b8ad728bb42..f992c436d3ed 100644
--- a/arch/arm/mach-meson/platsmp.c
+++ b/arch/arm/mach-meson/platsmp.c
@@ -37,7 +37,7 @@ static struct regmap *pmu;
static struct reset_control *meson_smp_get_core_reset(int cpu)
{
- struct device_node *np = of_get_cpu_node(cpu, 0);
+ struct device_node *np = of_get_cpu_node(cpu, NULL);
return of_reset_control_get_exclusive(np, NULL);
}
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 05/11] arm: mediatek: force type of mtk_smp_base
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
` (2 preceding siblings ...)
2019-10-08 12:34 ` [PATCH 04/11] ARM: meson: use NULL instead of 0 for pointer Ben Dooks
@ 2019-10-08 12:34 ` Ben Dooks
2019-10-08 12:34 ` [PATCH 06/11] ARM: OMAP2+: do not export am43xx_control functions Ben Dooks
` (7 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-kernel, Matthias Brugger, Ben Dooks, linux-mediatek
In __mtk_smp_prepare_cpus force the return of phys_to_virt()
to have __iomem on it to avoid the following sparse warning:
arch/arm/mach-mediatek/platsmp.c:105:30: warning: incorrect type in assignment (different address spaces)
arch/arm/mach-mediatek/platsmp.c:105:30: expected void [noderef] <asn:2> *static [toplevel] mtk_smp_base
arch/arm/mach-mediatek/platsmp.c:105:30: got void *
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-mediatek@lists.infradead.org
---
arch/arm/mach-mediatek/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-mediatek/platsmp.c b/arch/arm/mach-mediatek/platsmp.c
index 16a4ee6c9590..3717b960618d 100644
--- a/arch/arm/mach-mediatek/platsmp.c
+++ b/arch/arm/mach-mediatek/platsmp.c
@@ -102,7 +102,7 @@ static void __init __mtk_smp_prepare_cpus(unsigned int max_cpus, int trustzone)
if (trustzone) {
/* smp_base(trustzone-bootinfo) is reserved by device tree */
- mtk_smp_base = phys_to_virt(mtk_smp_info->smp_base);
+ mtk_smp_base = (void __force __iomem *)phys_to_virt(mtk_smp_info->smp_base);
} else {
mtk_smp_base = ioremap(mtk_smp_info->smp_base, MTK_SMP_REG_SIZE);
if (!mtk_smp_base) {
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 06/11] ARM: OMAP2+: do not export am43xx_control functions
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
` (3 preceding siblings ...)
2019-10-08 12:34 ` [PATCH 05/11] arm: mediatek: force type of mtk_smp_base Ben Dooks
@ 2019-10-08 12:34 ` Ben Dooks
2019-10-08 12:34 ` [PATCH 07/11] ARM: OMAP2+: prm44xx: make prm_{save, restore}_context static Ben Dooks
` (6 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel, Tony Lindgren, linux-omap, Ben Dooks
Do not export am43xx_control_{save,restore}_context to avoid
the foloowing warnings:
arch/arm/mach-omap2/control.c:687:6: warning: symbol 'am43xx_control_save_context' was not declared. Should it be static?
arch/arm/mach-omap2/control.c:701:6: warning: symbol 'am43xx_control_restore_context' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
---
arch/arm/mach-omap2/control.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/control.c b/arch/arm/mach-omap2/control.c
index c84b5e260617..73338cf80d76 100644
--- a/arch/arm/mach-omap2/control.c
+++ b/arch/arm/mach-omap2/control.c
@@ -684,7 +684,7 @@ static u32 am33xx_control_vals[ARRAY_SIZE(am43xx_control_reg_offsets)];
*
* Save the wkup domain registers
*/
-void am43xx_control_save_context(void)
+static void am43xx_control_save_context(void)
{
int i;
@@ -698,7 +698,7 @@ void am43xx_control_save_context(void)
*
* Restore the wkup domain registers
*/
-void am43xx_control_restore_context(void)
+static void am43xx_control_restore_context(void)
{
int i;
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 07/11] ARM: OMAP2+: prm44xx: make prm_{save, restore}_context static
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
` (4 preceding siblings ...)
2019-10-08 12:34 ` [PATCH 06/11] ARM: OMAP2+: do not export am43xx_control functions Ben Dooks
@ 2019-10-08 12:34 ` Ben Dooks
2019-10-08 12:34 ` [PATCH 08/11] ARM: mach-prima2: include common.h for sirfsoc_pm_init Ben Dooks
` (5 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel, Tony Lindgren, linux-omap, Ben Dooks
The prm_{save,restore}_context functions are not exported
so make them static to avoid the following warnings:
arch/arm/mach-omap2/prm44xx.c:748:6: warning: symbol 'prm_save_context' was not declared. Should it be static?
arch/arm/mach-omap2/prm44xx.c:759:6: warning: symbol 'prm_restore_context' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: linux-omap@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/prm44xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
index 1d9346f2a4ae..25093c1e5b9a 100644
--- a/arch/arm/mach-omap2/prm44xx.c
+++ b/arch/arm/mach-omap2/prm44xx.c
@@ -745,7 +745,7 @@ struct pwrdm_ops omap4_pwrdm_operations = {
static int omap44xx_prm_late_init(void);
-void prm_save_context(void)
+static void prm_save_context(void)
{
omap_prm_context.irq_enable =
omap4_prm_read_inst_reg(AM43XX_PRM_OCP_SOCKET_INST,
@@ -756,7 +756,7 @@ void prm_save_context(void)
omap4_prcm_irq_setup.pm_ctrl);
}
-void prm_restore_context(void)
+static void prm_restore_context(void)
{
omap4_prm_write_inst_reg(omap_prm_context.irq_enable,
OMAP4430_PRM_OCP_SOCKET_INST,
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 08/11] ARM: mach-prima2: include common.h for sirfsoc_pm_init
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
` (5 preceding siblings ...)
2019-10-08 12:34 ` [PATCH 07/11] ARM: OMAP2+: prm44xx: make prm_{save, restore}_context static Ben Dooks
@ 2019-10-08 12:34 ` Ben Dooks
2019-10-08 12:34 ` [PATCH 09/11] ARM: mach-prima2: make sirfsoc_rtc_iobrg_wait_sync static Ben Dooks
` (4 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel, Barry Song, Ben Dooks
Include the common.h header for the definition of sirfsoc_pm_init
to avoid the following warning:
arch/arm/mach-prima2/pm.c:147:12: warning: symbol 'sirfsoc_pm_init' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Barry Song <baohua@kernel.org>
---
arch/arm/mach-prima2/pm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-prima2/pm.c b/arch/arm/mach-prima2/pm.c
index c24bc89f320b..f31e3b6b9e00 100644
--- a/arch/arm/mach-prima2/pm.c
+++ b/arch/arm/mach-prima2/pm.c
@@ -19,6 +19,7 @@
#include <asm/suspend.h>
#include <asm/hardware/cache-l2x0.h>
+#include "common.h"
#include "pm.h"
/*
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 09/11] ARM: mach-prima2: make sirfsoc_rtc_iobrg_wait_sync static
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
` (6 preceding siblings ...)
2019-10-08 12:34 ` [PATCH 08/11] ARM: mach-prima2: include common.h for sirfsoc_pm_init Ben Dooks
@ 2019-10-08 12:34 ` Ben Dooks
2019-10-08 12:34 ` [PATCH 10/11] ARM: mach-prima2: include linux/rtc/sirfsoc_rtciobrg.h Ben Dooks
` (3 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel, Ben Dooks
The sirfsoc_rtc_iobrg_wait_sync is not used outside of this file
so make it static to avoid the following warning:
arch/arm/mach-prima2/rtciobrg.c:34:6: warning: symbol 'sirfsoc_rtc_iobrg_wait_sync' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Barry Song <baohua@kernel.org
---
arch/arm/mach-prima2/rtciobrg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-prima2/rtciobrg.c b/arch/arm/mach-prima2/rtciobrg.c
index 97c0e333e3b9..f5177219732a 100644
--- a/arch/arm/mach-prima2/rtciobrg.c
+++ b/arch/arm/mach-prima2/rtciobrg.c
@@ -31,7 +31,7 @@ static DEFINE_SPINLOCK(rtciobrg_lock);
* symbols without lock are only used by suspend asm codes
* and these symbols are not exported too
*/
-void sirfsoc_rtc_iobrg_wait_sync(void)
+static void sirfsoc_rtc_iobrg_wait_sync(void)
{
while (readl_relaxed(sirfsoc_rtciobrg_base + SIRFSOC_CPUIOBRG_CTRL))
cpu_relax();
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 10/11] ARM: mach-prima2: include linux/rtc/sirfsoc_rtciobrg.h
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
` (7 preceding siblings ...)
2019-10-08 12:34 ` [PATCH 09/11] ARM: mach-prima2: make sirfsoc_rtc_iobrg_wait_sync static Ben Dooks
@ 2019-10-08 12:34 ` Ben Dooks
2019-10-08 12:34 ` [PATCH 11/11] ARM: ux500: make ux500_cpu_die static Ben Dooks
` (2 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel, Barry Song, Ben Dooks
A numbre of the rtciobrg.c functions are declared in the
<linux/rtc/sirfsoc_rtciobrg.h> so include it to silence
the following warnings:
arch/arm/mach-prima2/rtciobrg.c:40:6: warning: symbol 'sirfsoc_rtc_iobrg_besyncing' was not declared. Should it be static?
arch/arm/mach-prima2/rtciobrg.c:65:5: warning: symbol 'sirfsoc_rtc_iobrg_readl' was not declared. Should it be static?
arch/arm/mach-prima2/rtciobrg.c:90:6: warning: symbol 'sirfsoc_rtc_iobrg_writel' was not declared. Should it be static?
arch/arm/mach-prima2/rtciobrg.c:137:15: warning: symbol 'devm_regmap_init_iobg' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Barry Song <baohua@kernel.org>
---
arch/arm/mach-prima2/rtciobrg.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-prima2/rtciobrg.c b/arch/arm/mach-prima2/rtciobrg.c
index f5177219732a..ba6aee0aadce 100644
--- a/arch/arm/mach-prima2/rtciobrg.c
+++ b/arch/arm/mach-prima2/rtciobrg.c
@@ -15,6 +15,8 @@
#include <linux/of_device.h>
#include <linux/of_platform.h>
+#include <linux/rtc/sirfsoc_rtciobrg.h>
+
#define SIRFSOC_CPUIOBRG_CTRL 0x00
#define SIRFSOC_CPUIOBRG_WRBE 0x04
#define SIRFSOC_CPUIOBRG_ADDR 0x08
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 11/11] ARM: ux500: make ux500_cpu_die static
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
` (8 preceding siblings ...)
2019-10-08 12:34 ` [PATCH 10/11] ARM: mach-prima2: include linux/rtc/sirfsoc_rtciobrg.h Ben Dooks
@ 2019-10-08 12:34 ` Ben Dooks
2019-10-08 17:56 ` [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Scott Branden
2019-10-15 23:16 ` Florian Fainelli
11 siblings, 0 replies; 15+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel, Linus Walleij, Ben Dooks
The ux500_cpu_die function is not exported so make it static
to avoid the following warning:
arch/arm/mach-ux500/platsmp.c:89:6: warning: symbol 'ux500_cpu_die' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/mach-ux500/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/platsmp.c b/arch/arm/mach-ux500/platsmp.c
index 0810f3abd810..415d8ad2a3c1 100644
--- a/arch/arm/mach-ux500/platsmp.c
+++ b/arch/arm/mach-ux500/platsmp.c
@@ -86,7 +86,7 @@ static int ux500_boot_secondary(unsigned int cpu, struct task_struct *idle)
}
#ifdef CONFIG_HOTPLUG_CPU
-void ux500_cpu_die(unsigned int cpu)
+static void ux500_cpu_die(unsigned int cpu)
{
wfi();
}
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
` (9 preceding siblings ...)
2019-10-08 12:34 ` [PATCH 11/11] ARM: ux500: make ux500_cpu_die static Ben Dooks
@ 2019-10-08 17:56 ` Scott Branden
2019-10-15 23:16 ` Florian Fainelli
11 siblings, 0 replies; 15+ messages in thread
From: Scott Branden @ 2019-10-08 17:56 UTC (permalink / raw)
To: Ben Dooks, linux-arm-kernel
Cc: linux-kernel, Ray Jui, Florian Fainelli, bcm-kernel-feedback-list,
Scott Branden
On 2019-10-08 5:34 a.m., Ben Dooks wrote:
> Include platsmp.h for the definition of bcm2836_smp_ops to fix
> the following warning:
>
> arch/arm/mach-bcm/platsmp.c:334:29: warning: symbol 'bcm2836_smp_ops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> ---
> arch/arm/mach-bcm/platsmp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
> index 47f8053d0240..21400b3fa5fe 100644
> --- a/arch/arm/mach-bcm/platsmp.c
> +++ b/arch/arm/mach-bcm/platsmp.c
> @@ -22,6 +22,8 @@
> #include <asm/smp_plat.h>
> #include <asm/smp_scu.h>
>
> +#include "platsmp.h"
> +
> /* Size of mapped Cortex A9 SCU address space */
> #define CORTEX_A9_SCU_SIZE 0x58
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 02/11] ARM: bcm: fix missing __iomem in bcm_kona_smc.c
2019-10-08 12:34 ` [PATCH 02/11] ARM: bcm: fix missing __iomem in bcm_kona_smc.c Ben Dooks
@ 2019-10-08 17:57 ` Scott Branden
2019-10-15 23:16 ` Florian Fainelli
1 sibling, 0 replies; 15+ messages in thread
From: Scott Branden @ 2019-10-08 17:57 UTC (permalink / raw)
To: Ben Dooks, linux-arm-kernel
Cc: linux-kernel, Ray Jui, Florian Fainelli, bcm-kernel-feedback-list,
Scott Branden
On 2019-10-08 5:34 a.m., Ben Dooks wrote:
> Fix the following sparse warnings from a missing __iomem
> in __bcm_kona_smc() function by adding __iomem attriubte.
>
> arch/arm/mach-bcm/bcm_kona_smc.c:143:21: warning: incorrect type in initializer (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:143:21: expected unsigned int [usertype] *args
> arch/arm/mach-bcm/bcm_kona_smc.c:143:21: got void [noderef] <asn:2> *static [toplevel] [assigned] bcm_smc
> _buffer
> arch/arm/mach-bcm/bcm_kona_smc.c:149:9: warning: incorrect type in argument 2 (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:149:9: expected void volatile [noderef] <asn:2> *addr
> arch/arm/mach-bcm/bcm_kona_smc.c:149:9: got unsigned int [usertype] *
> arch/arm/mach-bcm/bcm_kona_smc.c:150:9: warning: incorrect type in argument 2 (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:150:9: expected void volatile [noderef] <asn:2> *addr
> arch/arm/mach-bcm/bcm_kona_smc.c:150:9: got unsigned int [usertype] *
> arch/arm/mach-bcm/bcm_kona_smc.c:151:9: warning: incorrect type in argument 2 (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:151:9: expected void volatile [noderef] <asn:2> *addr
> arch/arm/mach-bcm/bcm_kona_smc.c:151:9: got unsigned int [usertype] *
> arch/arm/mach-bcm/bcm_kona_smc.c:152:9: warning: incorrect type in argument 2 (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:152:9: expected void volatile [noderef] <asn:2> *addr
> arch/arm/mach-bcm/bcm_kona_smc.c:152:9: got unsigned int [usertype] *[assigned] args
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> ---
> arch/arm/mach-bcm/bcm_kona_smc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c
> index 541e850a736c..43a16f922b53 100644
> --- a/arch/arm/mach-bcm/bcm_kona_smc.c
> +++ b/arch/arm/mach-bcm/bcm_kona_smc.c
> @@ -140,7 +140,7 @@ static int bcm_kona_do_smc(u32 service_id, u32 buffer_phys)
> static void __bcm_kona_smc(void *info)
> {
> struct bcm_kona_smc_data *data = info;
> - u32 *args = bcm_smc_buffer;
> + u32 __iomem *args = bcm_smc_buffer;
>
> BUG_ON(smp_processor_id() != 0);
> BUG_ON(!args);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
` (10 preceding siblings ...)
2019-10-08 17:56 ` [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Scott Branden
@ 2019-10-15 23:16 ` Florian Fainelli
11 siblings, 0 replies; 15+ messages in thread
From: Florian Fainelli @ 2019-10-15 23:16 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Ben Dooks, linux-arm-kernel
Cc: linux-kernel, Ray Jui, Scott Branden
On Tue, 8 Oct 2019 13:34:43 +0100, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> Include platsmp.h for the definition of bcm2836_smp_ops to fix
> the following warning:
>
> arch/arm/mach-bcm/platsmp.c:334:29: warning: symbol 'bcm2836_smp_ops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
Applied to soc/next, thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 02/11] ARM: bcm: fix missing __iomem in bcm_kona_smc.c
2019-10-08 12:34 ` [PATCH 02/11] ARM: bcm: fix missing __iomem in bcm_kona_smc.c Ben Dooks
2019-10-08 17:57 ` Scott Branden
@ 2019-10-15 23:16 ` Florian Fainelli
1 sibling, 0 replies; 15+ messages in thread
From: Florian Fainelli @ 2019-10-15 23:16 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Ben Dooks, linux-arm-kernel
Cc: linux-kernel, Ray Jui, Scott Branden
On Tue, 8 Oct 2019 13:34:44 +0100, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> Fix the following sparse warnings from a missing __iomem
> in __bcm_kona_smc() function by adding __iomem attriubte.
>
> arch/arm/mach-bcm/bcm_kona_smc.c:143:21: warning: incorrect type in initializer (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:143:21: expected unsigned int [usertype] *args
> arch/arm/mach-bcm/bcm_kona_smc.c:143:21: got void [noderef] <asn:2> *static [toplevel] [assigned] bcm_smc
> _buffer
> arch/arm/mach-bcm/bcm_kona_smc.c:149:9: warning: incorrect type in argument 2 (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:149:9: expected void volatile [noderef] <asn:2> *addr
> arch/arm/mach-bcm/bcm_kona_smc.c:149:9: got unsigned int [usertype] *
> arch/arm/mach-bcm/bcm_kona_smc.c:150:9: warning: incorrect type in argument 2 (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:150:9: expected void volatile [noderef] <asn:2> *addr
> arch/arm/mach-bcm/bcm_kona_smc.c:150:9: got unsigned int [usertype] *
> arch/arm/mach-bcm/bcm_kona_smc.c:151:9: warning: incorrect type in argument 2 (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:151:9: expected void volatile [noderef] <asn:2> *addr
> arch/arm/mach-bcm/bcm_kona_smc.c:151:9: got unsigned int [usertype] *
> arch/arm/mach-bcm/bcm_kona_smc.c:152:9: warning: incorrect type in argument 2 (different address spaces)
> arch/arm/mach-bcm/bcm_kona_smc.c:152:9: expected void volatile [noderef] <asn:2> *addr
> arch/arm/mach-bcm/bcm_kona_smc.c:152:9: got unsigned int [usertype] *[assigned] args
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
Applied to soc/next, thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-10-15 23:16 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
2019-10-08 12:34 ` [PATCH 02/11] ARM: bcm: fix missing __iomem in bcm_kona_smc.c Ben Dooks
2019-10-08 17:57 ` Scott Branden
2019-10-15 23:16 ` Florian Fainelli
2019-10-08 12:34 ` [PATCH 03/11] ARM: highbank: include local core.h for highbank_pm_init Ben Dooks
2019-10-08 12:34 ` [PATCH 04/11] ARM: meson: use NULL instead of 0 for pointer Ben Dooks
2019-10-08 12:34 ` [PATCH 05/11] arm: mediatek: force type of mtk_smp_base Ben Dooks
2019-10-08 12:34 ` [PATCH 06/11] ARM: OMAP2+: do not export am43xx_control functions Ben Dooks
2019-10-08 12:34 ` [PATCH 07/11] ARM: OMAP2+: prm44xx: make prm_{save, restore}_context static Ben Dooks
2019-10-08 12:34 ` [PATCH 08/11] ARM: mach-prima2: include common.h for sirfsoc_pm_init Ben Dooks
2019-10-08 12:34 ` [PATCH 09/11] ARM: mach-prima2: make sirfsoc_rtc_iobrg_wait_sync static Ben Dooks
2019-10-08 12:34 ` [PATCH 10/11] ARM: mach-prima2: include linux/rtc/sirfsoc_rtciobrg.h Ben Dooks
2019-10-08 12:34 ` [PATCH 11/11] ARM: ux500: make ux500_cpu_die static Ben Dooks
2019-10-08 17:56 ` [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Scott Branden
2019-10-15 23:16 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).