From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF23BFA372B for ; Wed, 16 Oct 2019 20:28:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71996218DE for ; Wed, 16 Oct 2019 20:28:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u95BKoVx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71996218DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: From:Subject:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F045tNBUfHXQTuidI+spw27zpNH0Tsb6pAW0/pfUiJ0=; b=u95BKoVxszhl0P grj4v3/W9EhpDXLkmF4cot+JrWnfCIYYnnEnK50Ue5vCbDIMJJnHbKv6qCk1c6tHlWRIgiw0FJbMd KhnZ8Eu8e8XiFp/7dZninbEazx/BgKR9IC3lqSFS/2umibhd1ZMCXpidV58SQGswEr4xphrAX2+Xs Kphl5I8wxSo3M/5NvJDptvSTn1+Fa1EXq8sz3UyiaQj/k3gasH+yzEdcfb84UY/QMq0pjQEAaUS/K xwOrZJ8lgdjQBZKlB4KzfJKBa3pLBGPYqXj3TwwdTQ8eduTzix1Olh3jiEyKTGStv20+TfwW84SMj 9pBftdbbucQkiTcFvNfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKptz-0008FM-2e; Wed, 16 Oct 2019 20:28:11 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKptu-0008Az-Px for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2019 20:28:08 +0000 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D74DC1434B989; Wed, 16 Oct 2019 13:28:05 -0700 (PDT) Date: Wed, 16 Oct 2019 13:28:05 -0700 (PDT) Message-Id: <20191016.132805.1945227679877403030.davem@davemloft.net> To: ben.dooks@codethink.co.uk Subject: Re: [PATCH] net: stmmac: fix argument to stmmac_pcs_ctrl_ane() From: David Miller In-Reply-To: <20191016082205.26899-1-ben.dooks@codethink.co.uk> References: <20191016082205.26899-1-ben.dooks@codethink.co.uk> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 16 Oct 2019 13:28:06 -0700 (PDT) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_132806_862444_2E3770BD X-CRM114-Status: UNSURE ( 7.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@lists.codethink.co.uk, alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, peppe.cavallaro@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: "Ben Dooks (Codethink)" Date: Wed, 16 Oct 2019 09:22:05 +0100 > The stmmac_pcs_ctrl_ane() expects a register address as > argument 1, but for some reason the mac_device_info is > being passed. > > Fix the warning (and possible bug) from sparse: > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces) > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: expected void [noderef] *ioaddr > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: got struct mac_device_info *hw > > Signed-off-by: Ben Dooks I'm still reviewing this but FYI you did not have to send this twice. Always check: https://patchwork.ozlabs.org/project/netdev/list/ to see what state your patch submission is in. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel