From: LABBE Corentin <clabbe@baylibre.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
herbert@gondor.apana.org.au, martin.blumenstingl@googlemail.com,
khilman@baylibre.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, linux-crypto@vger.kernel.org,
linux-amlogic@lists.infradead.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] crypto: amlogic: Add crypto accelerator for amlogic GXL
Date: Wed, 16 Oct 2019 22:11:52 +0200 [thread overview]
Message-ID: <20191016201152.GA31674@Red> (raw)
In-Reply-To: <8f9be4a8-ed6c-a2bd-f3ba-df22752e7172@infradead.org>
On Sun, Oct 13, 2019 at 10:41:06PM -0700, Randy Dunlap wrote:
> Hi,
>
> On 10/13/19 10:31 PM, Corentin Labbe wrote:
> > diff --git a/drivers/crypto/amlogic/Kconfig b/drivers/crypto/amlogic/Kconfig
> > new file mode 100644
> > index 000000000000..9c4bf96afeb3
> > --- /dev/null
> > +++ b/drivers/crypto/amlogic/Kconfig
> > @@ -0,0 +1,24 @@
> > +config CRYPTO_DEV_AMLOGIC_GXL
> > + tristate "Support for amlogic cryptographic offloader"
> > + default y if ARCH_MESON
> > + select CRYPTO_BLKCIPHER
> > + select CRYPTO_ENGINE
> > + select CRYPTO_ECB
> > + select CRYPTO_CBC
> > + select CRYPTO_AES
> > + help
> > + Select y here for having support for the cryptographic offloader
>
> to have support for
>
> > + availlable on Amlogic GXL SoC.
>
> available
>
> > + This hardware handle AES ciphers in ECB/CBC mode.
>
> handles
>
> > +
> > + To compile this driver as a module, choose M here: the module
> > + will be called amlogic-crypto.
>
> That module name does not match the Makefile's name.
>
> > +
> > +config CRYPTO_DEV_AMLOGIC_GXL_DEBUG
> > + bool "Enabled amlogic stats"
>
> Enable
>
> > + depends on CRYPTO_DEV_AMLOGIC_GXL
> > + depends on DEBUG_FS
> > + help
> > + Say y to enabled amlogic-crypto debug stats.
>
> enable
>
> > + This will create /sys/kernel/debug/gxl-crypto/stats for displaying
> > + the number of requests per flow and per algorithm.
> > diff --git a/drivers/crypto/amlogic/Makefile b/drivers/crypto/amlogic/Makefile
> > new file mode 100644
> > index 000000000000..39057e62c13e
> > --- /dev/null
> > +++ b/drivers/crypto/amlogic/Makefile
> > @@ -0,0 +1,2 @@
> > +obj-$(CONFIG_CRYPTO_DEV_AMLOGIC_GXL) += amlogic-gxl-crypto.o
> > +amlogic-gxl-crypto-y := amlogic-gxl-core.o amlogic-gxl-cipher.o
>
Thanks, I fixed it
Regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-16 20:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 5:31 [PATCH v2 0/4] crypto: add amlogic crypto offloader driver Corentin Labbe
2019-10-14 5:31 ` [PATCH v2 1/4] dt-bindings: crypto: Add DT bindings documentation for amlogic-crypto Corentin Labbe
2019-10-14 18:17 ` Rob Herring
2019-10-14 5:31 ` [PATCH v2 2/4] MAINTAINERS: Add myself as maintainer of amlogic crypto Corentin Labbe
2019-10-14 5:31 ` [PATCH v2 3/4] crypto: amlogic: Add crypto accelerator for amlogic GXL Corentin Labbe
2019-10-14 5:41 ` Randy Dunlap
2019-10-16 20:11 ` LABBE Corentin [this message]
2019-10-14 5:31 ` [PATCH v2 4/4] ARM64: dts: amlogic: adds crypto hardware node Corentin Labbe
2019-10-16 16:52 ` Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2019-10-14 5:18 [PATCH v2 0/4] crypto: add amlogic crypto offloader driver Corentin Labbe
2019-10-14 5:18 ` [PATCH v2 3/4] crypto: amlogic: Add crypto accelerator for amlogic GXL Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016201152.GA31674@Red \
--to=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).