From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Kamel Bouhara <kamel.bouhara@bootlin.com>
Cc: devicetree@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Mickael GARDET" <m.gardet@overkiz.com>,
linux-kernel@vger.kernel.org,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Kévin RAYMOND" <k.raymond@overkiz.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: at91: add a common kizbox2 dtsi file
Date: Thu, 17 Oct 2019 11:04:27 +0200 [thread overview]
Message-ID: <20191017110427.66bccdfb@windsurf> (raw)
In-Reply-To: <20191017085405.12599-3-kamel.bouhara@bootlin.com>
Hello Kamel,
On Thu, 17 Oct 2019 10:54:05 +0200
Kamel Bouhara <kamel.bouhara@bootlin.com> wrote:
> There are three different boards available depending on the PCB
> (3 antennas support and several revison). Add a dtsi file to share
> common binding between all kizbox2 boards.
>
> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> Signed-off-by: Kévin RAYMOND <k.raymond@overkiz.com>
> Signed-off-by: Mickael GARDET <m.gardet@overkiz.com>
> ---
> arch/arm/boot/dts/Makefile | 6 +-
> arch/arm/boot/dts/at91-kizbox.dts | 173 +++++++-------
The changes to this file (change to use phandles) seem unrelated to the
current patch, unless I'm missing something.
> arch/arm/boot/dts/at91-kizbox2-0.dts | 17 ++
> arch/arm/boot/dts/at91-kizbox2-1.dts | 22 ++
> arch/arm/boot/dts/at91-kizbox2-2.dts | 26 +++
> arch/arm/boot/dts/at91-kizbox2-3.dts | 30 +++
> arch/arm/boot/dts/at91-kizbox2-rev2.dts | 34 +++
> arch/arm/boot/dts/at91-kizbox2.dts | 244 -------------------
> arch/arm/boot/dts/at91-kizbox2_common.dtsi | 258 +++++++++++++++++++++
"-" seems to be a much more common separator for DT names, including in
this file, so what about at91-kizbox2-common.dtsi ?
> +// WMBUS (inverted with IO in the latest schematic)
I am not sure C++ comments are common in Device Tree files.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-17 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 8:54 [PATCH 0/2] Add a Kizbox2 dtsi and documentation Kamel Bouhara
2019-10-17 8:54 ` [PATCH 1/2] dt-bindings: arm: at91: Document Kizbox2 boards binding Kamel Bouhara
2019-10-29 1:49 ` Rob Herring
2019-10-30 10:05 ` Kamel Bouhara
2019-10-17 8:54 ` [PATCH 2/2] ARM: dts: at91: add a common kizbox2 dtsi file Kamel Bouhara
2019-10-17 9:04 ` Thomas Petazzoni [this message]
2019-10-17 9:26 ` Kamel Bouhara
-- strict thread matches above, loose matches on Subject: below --
2019-10-17 9:40 [PATCH 0/2] Add Kizboxmini boards support Kamel Bouhara
2019-10-17 12:24 ` [PATCH 2/2] ARM: dts: at91: add a common kizbox2 dtsi file Kamel Bouhara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017110427.66bccdfb@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=k.raymond@overkiz.com \
--cc=kamel.bouhara@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=m.gardet@overkiz.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox