* [PATCH 1/2] ARM: OMAP2+: make dra7xx_sha0_hwmod static
@ 2019-10-09 8:56 Ben Dooks
2019-10-09 8:56 ` [PATCH 2/2] ARM: OMAP2+: make omap44xx_sha0_hwmod and omap44xx_l3_main_2__des static Ben Dooks
2019-10-21 17:35 ` [PATCH 1/2] ARM: OMAP2+: make dra7xx_sha0_hwmod static Tony Lindgren
0 siblings, 2 replies; 4+ messages in thread
From: Ben Dooks @ 2019-10-09 8:56 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-kernel, Paul Walmsley, Tony Lindgren, Ben Dooks,
Benoît Cousson, linux-omap
The dra7xx_sha0_hwmod object is not exported outside of
omap_hwmod_7xx_data. so make it static to avoid the
following warning:
arch/arm/mach-omap2/omap_hwmod_7xx_data.c:686:19: warning: symbol 'dra7xx_sha0_hwmod' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: "Benoît Cousson" <bcousson@baylibre.com>
Cc: Paul Walmsley <paul@pwsan.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index e5bd549d2a5e..bd392d59382b 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -683,7 +683,7 @@ static struct omap_hwmod_class dra7xx_sha0_hwmod_class = {
.sysc = &dra7xx_sha0_sysc,
};
-struct omap_hwmod dra7xx_sha0_hwmod = {
+static struct omap_hwmod dra7xx_sha0_hwmod = {
.name = "sham",
.class = &dra7xx_sha0_hwmod_class,
.clkdm_name = "l4sec_clkdm",
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ARM: OMAP2+: make omap44xx_sha0_hwmod and omap44xx_l3_main_2__des static
2019-10-09 8:56 [PATCH 1/2] ARM: OMAP2+: make dra7xx_sha0_hwmod static Ben Dooks
@ 2019-10-09 8:56 ` Ben Dooks
2019-10-21 17:37 ` Tony Lindgren
2019-10-21 17:35 ` [PATCH 1/2] ARM: OMAP2+: make dra7xx_sha0_hwmod static Tony Lindgren
1 sibling, 1 reply; 4+ messages in thread
From: Ben Dooks @ 2019-10-09 8:56 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-kernel, Paul Walmsley, Tony Lindgren, Ben Dooks,
Benoît Cousson, linux-omap
The omap44xx_sha0_hwmod and omap44xx_l3_main_2__des objects are
not exported so make them static to avoid the following warnings:
arch/arm/mach-omap2/omap_hwmod_44xx_data.c:793:19: warning: symbol 'omap44xx_sha0_hwmod' was not declared. Should it be static?
arch/arm/mach-omap2/omap_hwmod_44xx_data.c:977:26: warning: symbol 'omap44xx_l3_main_2__des' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: "Benoît Cousson" <bcousson@baylibre.com>
Cc: Paul Walmsley <paul@pwsan.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 28ea2960a9b2..a11cd6f57d7c 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -790,7 +790,7 @@ static struct omap_hwmod_class omap44xx_sha0_hwmod_class = {
.sysc = &omap44xx_sha0_sysc,
};
-struct omap_hwmod omap44xx_sha0_hwmod = {
+static struct omap_hwmod omap44xx_sha0_hwmod = {
.name = "sham",
.class = &omap44xx_sha0_hwmod_class,
.clkdm_name = "l4_secure_clkdm",
@@ -974,7 +974,7 @@ static struct omap_hwmod omap44xx_des_hwmod = {
},
};
-struct omap_hwmod_ocp_if omap44xx_l3_main_2__des = {
+static struct omap_hwmod_ocp_if omap44xx_l3_main_2__des = {
.master = &omap44xx_l3_main_2_hwmod,
.slave = &omap44xx_des_hwmod,
.clk = "l3_div_ck",
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] ARM: OMAP2+: make dra7xx_sha0_hwmod static
2019-10-09 8:56 [PATCH 1/2] ARM: OMAP2+: make dra7xx_sha0_hwmod static Ben Dooks
2019-10-09 8:56 ` [PATCH 2/2] ARM: OMAP2+: make omap44xx_sha0_hwmod and omap44xx_l3_main_2__des static Ben Dooks
@ 2019-10-21 17:35 ` Tony Lindgren
1 sibling, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2019-10-21 17:35 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, Paul Walmsley, linux-omap, Benoît Cousson,
linux-arm-kernel
* Ben Dooks <ben.dooks@codethink.co.uk> [191009 01:57]:
> The dra7xx_sha0_hwmod object is not exported outside of
> omap_hwmod_7xx_data. so make it static to avoid the
> following warning:
>
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c:686:19: warning: symbol 'dra7xx_sha0_hwmod' was not declared. Should it be static?
Applying into omap-for-v5.5/soc thanks.
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-21 17:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-09 8:56 [PATCH 1/2] ARM: OMAP2+: make dra7xx_sha0_hwmod static Ben Dooks
2019-10-09 8:56 ` [PATCH 2/2] ARM: OMAP2+: make omap44xx_sha0_hwmod and omap44xx_l3_main_2__des static Ben Dooks
2019-10-21 17:37 ` Tony Lindgren
2019-10-21 17:35 ` [PATCH 1/2] ARM: OMAP2+: make dra7xx_sha0_hwmod static Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).