From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6493CA9EA0 for ; Tue, 22 Oct 2019 12:26:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A820421906 for ; Tue, 22 Oct 2019 12:26:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g0qvo+SR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="duVArzCh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A820421906 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VgY9XeBY1BKMUIIZH34InmGtsrhqP0vszMXgD9amSx4=; b=g0qvo+SRbBVfCN WwEt87abFU3Guo9M0Mjkx4Ig+K0DE16WEbUOeLTPYr5vOjqbabfZGGiYaO06X1+J6Ryc0ozQ6La8J ppELVEUt9ZiWkzjfZ3qewOxNMq2skmF141BEqpoTSG/4Eg6ucQsC2nAPTZ9MnmAmadmV3EdFu/bLH LJ10oWj64015lGs7OUbNw6tr/lK/n4dyMmeg5rf8h0k9ap/dUKn4IpNx/BZfOUUkbidCMLb2nzaGl DI/WjUzfEfoEatso+Egnm/sxXZ6DAyq94hvbGZEFBsI6M96CKDrF1KXj2mnVIJr9LeG7ZxYZVFZOw 4N0Lbd3faV4RV9mOIMfQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMtEf-0002nY-32; Tue, 22 Oct 2019 12:26:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMtEa-0002mm-Kb for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2019 12:25:59 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C91502184C; Tue, 22 Oct 2019 12:25:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571747156; bh=oXX6Ruh04x8qHjPZHb6cjHnTqz33Xt0fFodUI+uKHKg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=duVArzChHrutOcwxJlN96kTY7+qq2YILVx276cvY9b18m4OL8KF9BueLggsB8kb06 Rz3EMvp3f5M9uTprMOgWvWee/MI/Xwa5r35mm0pCDildOFgnDalN1OTvyTtg8RyRjN HubV3AweoLeSmsFWva17wmGRYjpUVGSS0xkToypQ= Date: Tue, 22 Oct 2019 13:25:50 +0100 From: Will Deacon To: Candle Sun Subject: Re: [RESEND PATCH] ARM/hw_breakpoint: add ARMv8.1/ARMv8.2 debug architecutre versions support in enable_monitor_mode() Message-ID: <20191022122550.GA17232@willie-the-truck> References: <1569483508-18768-1-git-send-email-candlesea@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1569483508-18768-1-git-send-email-candlesea@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191022_052556_698002_2DEDBC6C X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux@armlinux.org.uk, Candle Sun , linux-kernel@vger.kernel.org, Nianfu Bai , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 26, 2019 at 03:38:28PM +0800, Candle Sun wrote: > From: Candle Sun > > When ARMv8.1/ARMv8.2 cores are used in AArch32 mode, > arch_hw_breakpoint_init() in arch/arm/kernel/hw_breakpoint.c will be used. > > From ARMv8 specification, different debug architecture versions defined: > * 0110 ARMv8, v8 Debug architecture. > * 0111 ARMv8.1, v8 Debug architecture, with Virtualization Host Extensions. > * 1000 ARMv8.2, v8.2 Debug architecture. > > So missing ARMv8.1/ARMv8.2 cases will cause enable_monitor_mode() function > returns -ENODEV, and arch_hw_breakpoint_init() will fail. > > Signed-off-by: Candle Sun > Signed-off-by: Nianfu Bai > --- > arch/arm/include/asm/hw_breakpoint.h | 2 ++ > arch/arm/kernel/hw_breakpoint.c | 2 ++ > 2 files changed, 4 insertions(+) [...] > diff --git a/arch/arm/include/asm/hw_breakpoint.h b/arch/arm/include/asm/hw_breakpoint.h > index ac54c06..9137ef6 100644 > --- a/arch/arm/include/asm/hw_breakpoint.h > +++ b/arch/arm/include/asm/hw_breakpoint.h > @@ -53,6 +53,8 @@ static inline void decode_ctrl_reg(u32 reg, > #define ARM_DEBUG_ARCH_V7_MM 4 > #define ARM_DEBUG_ARCH_V7_1 5 > #define ARM_DEBUG_ARCH_V8 6 > +#define ARM_DEBUG_ARCH_V8_1 7 > +#define ARM_DEBUG_ARCH_V8_2 8 Looks like you can also add: #define ARM_DEBUG_ARCH_V8_4 9 and treat that the same way. With that, and a fix to $SUBJECT: Acked-by: Will Deacon Please put this into the patch system [1]. Will [1] https://www.arm.linux.org.uk/developer/patches/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel