From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAD05CA9EB9 for ; Tue, 22 Oct 2019 15:31:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B06CC21872 for ; Tue, 22 Oct 2019 15:31:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hiuw9i5M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B06CC21872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+5jgSacKODVisdBzbXQGk6v6C7QTOGJoN5hQRcMnffg=; b=hiuw9i5MLGGWYT 3a0MWBaEMvSB34qFAl+dEulbJfHa/CuUAJXkbm09COugxYK0UjdYbeFzKKePTQ7T2d9RmJXwRuIxY wZl4kNM937U6xfBsQwKNsvVb9Y0aMIHqiXF1w6WdJWj4/owllRVKLQd+XxJi2yJZNH+26bYQifjWr vIyy2ETIf9Aor8u/WSmjLTBIJHcR0ULDOCiWekp7XGgM3fqHei86p1vOUjkBH1lO+DTMeDWmtdioc MOyzQY7XT2O6KSPNK7bGB0k0+qFRL46H7wBohPA/BZYWpz3hPka0apCpw9wSB3GNNLxz5Tsq8scSJ +Xhk8yDhieUjm7RA51TA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMw7b-0007eY-7B; Tue, 22 Oct 2019 15:30:55 +0000 Received: from [217.140.110.172] (helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMw7Y-0007ce-Ek for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2019 15:30:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA786176B; Tue, 22 Oct 2019 08:30:39 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BFBAE3F71A; Tue, 22 Oct 2019 08:30:37 -0700 (PDT) Date: Tue, 22 Oct 2019 16:30:35 +0100 From: Mark Rutland To: Steven Rostedt Subject: Re: [PATCH 1/8] ftrace: add ftrace_init_nop() Message-ID: <20191022153035.GB52920@lakrids.cambridge.arm.com> References: <20191021163426.9408-1-mark.rutland@arm.com> <20191021163426.9408-2-mark.rutland@arm.com> <20191021140756.613a1bac@gandalf.local.home> <20191022112811.GA11583@lakrids.cambridge.arm.com> <20191022085428.75cfaad6@gandalf.local.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191022085428.75cfaad6@gandalf.local.home> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191022_083052_540366_9F442C43 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jthierry@redhat.com, will@kernel.org, ard.biesheuvel@linaro.org, peterz@infradead.org, catalin.marinas@arm.com, deller@gmx.de, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, takahiro.akashi@linaro.org, mingo@redhat.com, james.morse@arm.com, jeyu@kernel.org, amit.kachhap@arm.com, svens@stackframe.org, duwe@suse.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 22, 2019 at 08:54:28AM -0400, Steven Rostedt wrote: > On Tue, 22 Oct 2019 12:28:11 +0100 > Mark Rutland wrote: > > > To make the name even better, let's just rename it to: > > > > > > ftrace_nop_initialization() > > > > > > I think that may be the best description for it. > > > > Perhaps ftrace_nop_initialize(), so that it's not a noun? > > > > I've made it ftrace_nop_initialization() in my branch for now. > > I'm fine with ftrace_nop_initialize(). It's settled, then. :) [...] > > | /** > > | * ftrace_init_nop - initialize a nop call site > > | * @mod: module structure if called by module load initialization > > | * @rec: the mcount call site record > > Perhaps say "mcount/fentry" This is the exact wording that ftrace_make_nop and ftrace_modify_call have. For consistency, I think those should all match. I can add " (e.g. mcount/fentry)" to all of those if you'd like? ... or leave them all as-is? > > | * > > | * This is a very sensitive operation and great care needs > > | * to be taken by the arch. The operation should carefully > > | * read the location, check to see if what is read is indeed > > | * what we expect it to be, and then on success of the compare, > > | * it should write to the location. > > | * > > | * The code segment at @rec->ip should be as initialized by the > > "should be as" is a bit confusing. What about? > > "The code segment at @rec->ip should contain the contents created by > the compiler". Works for me. Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel