From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79DF0CA9EB6 for ; Wed, 23 Oct 2019 12:36:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47F7521906 for ; Wed, 23 Oct 2019 12:36:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZscLG7Bl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47F7521906 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dhnUIPL+sDs4sBsZvKuyR1vwEv67o0JgOkDR1gGWidY=; b=ZscLG7BlZeTjFs h3OjVQwEUgF8vPqpXuaOmbtbEx5wpg5D2wky5i94nXMp8lthhq/IPUKOAO2Uiam8uEHwrP91nrPJ7 BxxK88oi2iZatksxCpl0bsC3dm14iVDM48Za0gBomB3hguNtW3doUyNf+wXQgIOnPuE6zQSJdiaf7 5tORCHw8NC9N8daU711bfmcxX69ITgCqAS1Q2o1C9CSS+pqpXpFnA7Ood2TFaMTPWOGMCqUGGhTcE ccwyioNwJx2ouH5K7WsulfRb4Cq3X4UvBMd1GapdtbnoaVTN4G6agtRgCn5zmUAwHLPwHWqXeCdI/ 8VVpe6y+ddD8RiiIBD3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNFrp-0000sQ-Od; Wed, 23 Oct 2019 12:35:57 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNFo5-0005Dl-9g for linux-arm-kernel@lists.infradead.org; Wed, 23 Oct 2019 12:32:06 +0000 Received: by mail-ed1-f66.google.com with SMTP id h2so15616908edn.3 for ; Wed, 23 Oct 2019 05:32:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KQN2p3CqQqqGqvDm8RQZXLnReFZTauNKSF3Je5lv8Vs=; b=HT4cCWKR2rnRrNl8wtyqn2/7V38P7dfdDglV4BQ4WpHM3J9/XFnUVUSY9Z9iJhthbA RcnnBkgdnfmZynbGFkIcfqVsBIGjr/Acpzv7du756cyUrbsA8J2/tJLOHF9TFk87XpjC 6HtS5tj2JgRnZS5VcjdvJ8w+X5sXGbpUXmRtXoCVTpXU+8j+ll2pJ3yIvzbhazaIkhkE ietIt/DIltEtpSTKKU2qFr6m/9H0ZzO1VTHcLjDxLig6MkxKTah6aIXSRWu0z21Mmdt8 jrPiaksSAMf9DiaqPQEXKXcRdnzJTXBsGfeN4Z1TxcZI6IFcEV9UxlINTt7WMdFBspLI 1Acg== X-Gm-Message-State: APjAAAXyCXoXATkS0zL3CmiJzz13OIkyLgL9hwkPBMA3CCjv4/d2NeuI kRgS75Ps579bTJAiaB9fGv/rDOahQTk= X-Google-Smtp-Source: APXvYqzAyy2/9uMMaEi+++Uil+JEuPxjvNWuDWfQdsPMkZduyAwEgeg60Y2iekGhRXEaJq6rYisoxg== X-Received: by 2002:a17:906:d214:: with SMTP id w20mr32128690ejz.68.1571833923476; Wed, 23 Oct 2019 05:32:03 -0700 (PDT) Received: from pi3 ([194.230.155.217]) by smtp.googlemail.com with ESMTPSA id k24sm163420edx.46.2019.10.23.05.32.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 05:32:02 -0700 (PDT) Date: Wed, 23 Oct 2019 14:32:00 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann Subject: Re: [PATCH 13/36] ARM: s3c: move regs-spi.h into spi driver Message-ID: <20191023123200.GC11048@pi3> References: <20191010202802.1132272-1-arnd@arndb.de> <20191010203043.1241612-1-arnd@arndb.de> <20191010203043.1241612-13-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191010203043.1241612-13-arnd@arndb.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191023_053205_345394_469DC3D2 X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , Kukjin Kim , Andi Shyti , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 10, 2019 at 10:29:57PM +0200, Arnd Bergmann wrote: > The file is mostly specific to the driver, the few bits that > are actually used by the platform code get moved to mach/map.h > instead. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-s3c24xx/include/mach/map.h | 2 ++ > arch/arm/mach-s3c24xx/s3c2412.c | 1 - > arch/arm/plat-samsung/devs.c | 1 - > drivers/spi/spi-s3c24xx-fiq.S | 4 +++- > .../include/plat/regs-spi.h => drivers/spi/spi-s3c24xx-regs.h | 3 --- > drivers/spi/spi-s3c24xx.c | 3 +-- > 6 files changed, 6 insertions(+), 8 deletions(-) > rename arch/arm/plat-samsung/include/plat/regs-spi.h => drivers/spi/spi-s3c24xx-regs.h (95%) > > diff --git a/arch/arm/mach-s3c24xx/include/mach/map.h b/arch/arm/mach-s3c24xx/include/mach/map.h > index bca93112f57d..a20c9fd0d855 100644 > --- a/arch/arm/mach-s3c24xx/include/mach/map.h > +++ b/arch/arm/mach-s3c24xx/include/mach/map.h > @@ -86,6 +86,8 @@ > #define S3C2410_PA_SPI (0x59000000) > #define S3C2443_PA_SPI0 (0x52000000) > #define S3C2443_PA_SPI1 S3C2410_PA_SPI > +#define S3C2410_SPI1 (0x20) > +#define S3C2412_SPI1 (0x100) > > /* SDI */ > #define S3C2410_PA_SDI (0x5A000000) > diff --git a/arch/arm/mach-s3c24xx/s3c2412.c b/arch/arm/mach-s3c24xx/s3c2412.c > index 8fe4d4670dcb..c3fb3e6c0dd8 100644 > --- a/arch/arm/mach-s3c24xx/s3c2412.c > +++ b/arch/arm/mach-s3c24xx/s3c2412.c > @@ -37,7 +37,6 @@ > #include > #include > #include > -#include > > #include "common.h" > #include "nand-core.h" > diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c > index 6e4c1cb07104..fd94a35e22f8 100644 > --- a/arch/arm/plat-samsung/devs.c > +++ b/arch/arm/plat-samsung/devs.c > @@ -59,7 +59,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/drivers/spi/spi-s3c24xx-fiq.S b/drivers/spi/spi-s3c24xx-fiq.S > index e95d6282109e..9d5f8f1e5e81 100644 > --- a/drivers/spi/spi-s3c24xx-fiq.S > +++ b/drivers/spi/spi-s3c24xx-fiq.S > @@ -12,10 +12,12 @@ > > #include > #include > -#include > > #include "spi-s3c24xx-fiq.h" > > +#define S3C2410_SPTDAT (0x10) > +#define S3C2410_SPRDAT (0x14) > + > .text > > @ entry to these routines is as follows, with the register names > diff --git a/arch/arm/plat-samsung/include/plat/regs-spi.h b/drivers/spi/spi-s3c24xx-regs.h > similarity index 95% > rename from arch/arm/plat-samsung/include/plat/regs-spi.h > rename to drivers/spi/spi-s3c24xx-regs.h > index 607844311566..37b93ff7c7fe 100644 > --- a/arch/arm/plat-samsung/include/plat/regs-spi.h > +++ b/drivers/spi/spi-s3c24xx-regs.h > @@ -8,9 +8,6 @@ > #ifndef __ASM_ARCH_REGS_SPI_H > #define __ASM_ARCH_REGS_SPI_H Can you also update the guard name? Best regards, Krzysztof > > -#define S3C2410_SPI1 (0x20) > -#define S3C2412_SPI1 (0x100) > - > #define S3C2410_SPCON (0x00) > > #define S3C2410_SPCON_SMOD_DMA (2 << 5) /* DMA mode */ > diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c > index 2d6e37f25e2d..2f395e4861f6 100644 > --- a/drivers/spi/spi-s3c24xx.c > +++ b/drivers/spi/spi-s3c24xx.c > @@ -21,10 +21,9 @@ > #include > #include > > -#include > - > #include > > +#include "spi-s3c24xx-regs.h" > #include "spi-s3c24xx-fiq.h" > > /** > -- > 2.20.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel