From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5397CCA9EB6 for ; Wed, 23 Oct 2019 12:36:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03049205C9 for ; Wed, 23 Oct 2019 12:36:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rajq6XAw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03049205C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Uqz375Zlvuq+v1QqgJsVEteYEMV1g+dFCPwL67kbOCo=; b=rajq6XAw0nStNj zzaMj08iZPnft+k8ui8wQLNgSiImbHfW4ngOynzPlbXLE/++gGMO01CVXFMO/fK+wSU9uesbRP+6v V9YlyBTnPddTOrl2oh7PpNgA3B17jJjQDP8lGpQyqKSYdIw0NpbJUcKQyNiyhh/y5S2CJ3jABsO1X Q83vN8z5m3Kz6OTSQ2rWYSF3eiNtO/5RGNFxryPd/d6znhWvvGctjFz6tPk8DVQThAZeXxfTOaTKE t2PxiqdLkQC+x5ZOXGI5eFWx1b8l+Kgcan7s0WpaqPIH83MZlDLskzU1AMM7p2g+WpbCgWsaqxtpb GJ11MHBGQ1vTsTQ+P9pA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNFs4-000163-HT; Wed, 23 Oct 2019 12:36:12 +0000 Received: from [217.140.110.172] (helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNFoU-0005R6-8Y for linux-arm-kernel@lists.infradead.org; Wed, 23 Oct 2019 12:32:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC3BC497; Wed, 23 Oct 2019 05:32:17 -0700 (PDT) Received: from arm.com (e112269-lin.cambridge.arm.com [10.1.194.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3CC263F6C4; Wed, 23 Oct 2019 05:32:16 -0700 (PDT) Date: Wed, 23 Oct 2019 13:32:10 +0100 From: Steven Price To: Mao Wenan Subject: Re: [PATCH] KVM: arm64: Select SCHED_INFO before SCHEDSTATS Message-ID: <20191023123210.GA40238@arm.com> References: <20191023032254.159510-1-maowenan@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191023032254.159510-1-maowenan@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191023_053230_361235_EE3EA132 X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki Poulose , "maz@kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Morse , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , "will@kernel.org" , "kvmarm@lists.cs.columbia.edu" , "julien.thierry.kdev@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 23, 2019 at 04:22:54AM +0100, Mao Wenan wrote: > If KVM=y, it will select SCHEDSTATS, below erros can > be seen: > kernel/sched/stats.h: In function rq_sched_info_arrive: > kernel/sched/stats.h:12:20: error: struct sched_info > has no member named run_delay > rq->rq_sched_info.run_delay += delta; > ^ > kernel/sched/stats.h:13:20: error: struct sched_info > has no member named pcount > rq->rq_sched_info.pcount++; > ^ > kernel/sched/stats.h: In function rq_sched_info_dequeued: > kernel/sched/stats.h:31:20: error: struct sched_info has > no member named run_delay > rq->rq_sched_info.run_delay += delta; > > These are because CONFIG_SCHED_INFO is not set, This patch > is to select SCHED_INFO before SCHEDSTATS. It looks like I didn't spot this because when DEBUG_KERNEL is enabled then KVM selects SCHEDSTATS, which selects SCHED_INFO. Thanks for spotting this. > > Fixes: 8564d6372a7d ("KVM: arm64: Support stolen time reporting via shared structure") > Signed-off-by: Mao Wenan Reviewed-by: Steven Price > --- > arch/arm64/kvm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig > index d8b88e4..3c46eac 100644 > --- a/arch/arm64/kvm/Kconfig > +++ b/arch/arm64/kvm/Kconfig > @@ -39,6 +39,7 @@ config KVM > select IRQ_BYPASS_MANAGER > select HAVE_KVM_IRQ_BYPASS > select HAVE_KVM_VCPU_RUN_PID_CHANGE > + select SCHED_INFO > select SCHEDSTATS > ---help--- > Support hosting virtualized guest machines. > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel