From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E99BCCA9EB7 for ; Wed, 23 Oct 2019 17:03:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE41B21928 for ; Wed, 23 Oct 2019 17:03:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q+V+uBXf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N4mOPS98" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE41B21928 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PcbQAyjwBI+k8GZ+niXt57WrCm/gxNDsFdaFdM2XCvc=; b=q+V+uBXf/HqwRv /oXHjiErzLQHOXchuGAYk2+AJCmAT0vCPfzbNH8VTwCbjhrdikEu75fTefpA/Ol4nzRQP5pq/h50f ZeEQN9k69+GDHffbaHhM9B3iSGXHicrEQVA/70hKpohNEVa09AFs75/gqWYruPkct+JOVSQJS6REr +9uIvEXmG+oVgJXVhjbqYFh+E7g00IzCh9OYC+PMtxTJM/qBVYx1wNqklNYopu8xDXLU7mnwxpnYR +R1PM2ofhzzxxhPi58Zy4LfXIuWcKDXiZMtzgU+JJYMZWhKpMSqdaaQF8D+sKwkrRcA2T/u6WH5si 2nDZHrIyQiNYhz2cVy7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNK2Y-0006IH-H8; Wed, 23 Oct 2019 17:03:18 +0000 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNK2L-00064c-VC for linux-arm-kernel@lists.infradead.org; Wed, 23 Oct 2019 17:03:07 +0000 Received: by mail-ot1-x344.google.com with SMTP id 53so6444284otv.4 for ; Wed, 23 Oct 2019 10:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LNIlo875oLUnbVBAslOcAnj59hqK1kHx858TCXge7cA=; b=N4mOPS98IWbZY/2/KBp62o4U8DpmiY8K/DxEPJzcpUxxxheeFNhUu7vukEldTwgqYR rHqct06pgkkgI7CxlYFrLPVZFWX0enc8m766N5KPfidbuNpOhSlOnf7lUm4GpzbTXhqi mKxKG1Y07F9CS+p9fzQ9CFIozlQSEzIVJiYzQjPfo6BpMzEDSObuiZoB7x9je0fp6S0/ DyL2E/W6hxxWsJfr0QGpj9uWjDA0V25V2YCZx82kOEZYyAZ8gLMmecgtPLXiTgUOyeY+ X9ZQcx5xLJl2//NB9fL0WDdd6hfY1K67a98OMzhy12qY9cFN8oW7zGfw3Oiphk5MZUXX LNyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LNIlo875oLUnbVBAslOcAnj59hqK1kHx858TCXge7cA=; b=GDP47Bv7BeaUhs0fXznP9a3MsHRt2ahbpv4vhRWgPKxVU4ccaPvq4dlwsYQy6i+KwR gQoEYH/8NUDX0kQYYrQbFjKz0wJgmD8LfsjLWHMRV/HD0XxCFXU1Mr66PFVFZcl33SCM diV50fgvY0SxcS/B39ai1XuUqyzfrvqC3AuLugAp3Xaxfy+OzSst9EUrm8PE0JauBLLH TpqVY6IWCondqrI6I5x6nGE6M92BNsvyLztg/7sgRcAvPX48oRadwye5nbk61L5rI+0q 0U5GdbaYbfR0navPBpmmIfvhwXBir/fIdNFlo8i2ksL6ykr87Owx6gNXDSsFJF2BEsFu w70A== X-Gm-Message-State: APjAAAWiO1s2K2M0ib32YwsQW7phmIT2HJRnMDUDNlk3rlXO2prsb9kt Fvs8LequCaHHU0cvUNszjU4= X-Google-Smtp-Source: APXvYqyr+KOjBV2W0qrTz7k8vKZIZRshNryK06zDkLhWk6XYcHe9LOVkSReS/D2+RnKymZPKRqgmvQ== X-Received: by 2002:a9d:6ace:: with SMTP id m14mr8170163otq.11.1571850184682; Wed, 23 Oct 2019 10:03:04 -0700 (PDT) Received: from ubuntu-m2-xlarge-x86 ([2604:1380:4111:8b00::1]) by smtp.gmail.com with ESMTPSA id r26sm5705285oij.46.2019.10.23.10.03.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2019 10:03:04 -0700 (PDT) Date: Wed, 23 Oct 2019 10:03:02 -0700 From: Nathan Chancellor To: Mark Brown Subject: Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init Message-ID: <20191023170302.GA45373@ubuntu-m2-xlarge-x86> References: <20191023000906.14374-1-natechancellor@gmail.com> <20191023032302.tu5nkvulo2yoctgr@vireshk-i7> <20191023104304.GA5723@sirena.co.uk> <20191023162628.GA10997@ubuntu-m2-xlarge-x86> <20191023163656.GH5723@sirena.co.uk> <20191023165417.GA15082@ubuntu-m2-xlarge-x86> <20191023165923.GL5723@sirena.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191023165923.GL5723@sirena.co.uk> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191023_100306_023880_36DD3F10 X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, Viresh Kumar , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , clang-built-linux@googlegroups.com, Kukjin Kim , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 23, 2019 at 05:59:23PM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 09:54:17AM -0700, Nathan Chancellor wrote: > > On Wed, Oct 23, 2019 at 05:36:56PM +0100, Mark Brown wrote: > > > On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > > > > On Wed, Oct 23, 2019 at 11:43:04AM +0100, Mark Brown wrote: > > > > > > The driver should also have supported s3c6400 as well. > > > > > Kconfig says otherwise, unless I am missing something. > > > > Note the XX in the config option. > > > But what about the depends and the help text? > > Viresh asked why the driver was written with s3c6410 support optional. > I explained that the reason that it was written this way was to > accomodate s3c6400 support. Ah understood, thanks for the clarification and sorry for the misunderstanding! Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel