From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DDE0CA9EAF for ; Thu, 24 Oct 2019 08:51:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E479621872 for ; Thu, 24 Oct 2019 08:51:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aQN+uJky"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xpwdM9yM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E479621872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rr/S7gcHYd1uUe50cH+0GHGPkvAQM815Hl2eokMGqso=; b=aQN+uJkyfwxu+Y 8OFe0enhwd7ShSnVmul809UjPLPXGAmpC/Y6qfl8JGGmoZhWYUxo30Qld4wUkJdCABJgeg9w5IhQR vVYa/YbWTFXY/x9OVqQ1ETiOtJyJFtGIVO2faTDtq8z3y8QY8zvNUL5JE3yx74/pxpVZ52PVHEZzG Ux9+z0YfLm+9GivW21dOiSSIVyjD8ke2IWfcFr4wUFfOCDribuuyrtNM/vAEfArGiRcdgD6eqsPjn ctku85ZxPSQ7oYVsH1e2h9QHIetpfyRoJhr5PlfQn1uAeiy8unF1b5XU7KLJMmoyFOF8zobMLPeL4 blgj0GBEcKgIwADAhkJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNYqK-0007mA-9g; Thu, 24 Oct 2019 08:51:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNYqG-0007lZ-L2; Thu, 24 Oct 2019 08:51:37 +0000 Received: from rapoport-lnx (nesher1.haifa.il.ibm.com [195.110.40.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C60620684; Thu, 24 Oct 2019 08:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571907096; bh=yne+q2OXrSImKWVSiY3azP5LbAIN48uZobw79sAWlFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xpwdM9yMJT3vwdJLbOI5KIPEEpEYHfqEfSqqKjUi5ZSSU5mfa5OWBh563R00Omteo 1c6jhSHIeQS869/swtQtZqJJbFD6Wthojjuy5NInms0kvWdnjQNTpkjIm45S4+i5rs whgYfB8T+i91x0MJgndRbMS9GGWr99hizp8ehhpU= Date: Thu, 24 Oct 2019 11:51:24 +0300 From: Mike Rapoport To: Rolf Eike Beer Subject: Re: [PATCH 08/12] parisc: use pgtable-nopXd instead of 4level-fixup Message-ID: <20191024085123.GB12281@rapoport-lnx> References: <1571822941-29776-1-git-send-email-rppt@kernel.org> <1571822941-29776-9-git-send-email-rppt@kernel.org> <70339cfc547e2fa0f6b98fefb1b1a9fa@sf-tec.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <70339cfc547e2fa0f6b98fefb1b1a9fa@sf-tec.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191024_015136_715548_D7CE93FC X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-parisc-owner@vger.kernel.org, "James E.J. Bottomley" , linux-mm@kvack.org, sparclinux@vger.kernel.org, Vincent Chen , Greg Ungerer , Anton Ivanov , linux-arch@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Richard Weinberger , Helge Deller , Russell King , Mike Rapoport , Geert Uytterhoeven , Mark Salter , Matt Turner , Jeff Dike , Sam Creasey , Arnd Bergmann , Vineet Gupta , linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, Greentime Hu , "Kirill A. Shutemov" , linux-arm-kernel@lists.infradead.org, Michal Simek , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, Andrew Morton , Linus Torvalds , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 23, 2019 at 12:20:29PM +0200, Rolf Eike Beer wrote: > >diff --git a/arch/parisc/include/asm/page.h > >b/arch/parisc/include/asm/page.h > >index 93caf17..1d339ee 100644 > >--- a/arch/parisc/include/asm/page.h > >+++ b/arch/parisc/include/asm/page.h > >@@ -42,48 +42,54 @@ typedef struct { unsigned long pte; } pte_t; /* > >either 32 or 64bit */ > > > > /* NOTE: even on 64 bits, these entries are __u32 because we allocate > > * the pmd and pgd in ZONE_DMA (i.e. under 4GB) */ > >-typedef struct { __u32 pmd; } pmd_t; > > typedef struct { __u32 pgd; } pgd_t; > > typedef struct { unsigned long pgprot; } pgprot_t; > > > >-#define pte_val(x) ((x).pte) > >-/* These do not work lvalues, so make sure we don't use them as such. */ > >+#if CONFIG_PGTABLE_LEVELS == 3 > >+typedef struct { __u32 pmd; } pmd_t; > >+#define __pmd(x) ((pmd_t) { (x) } ) > >+/* pXd_val() do not work lvalues, so make sure we don't use them as such. > >*/ > > For me it sounds like there is something missing, maybe an "as" before > lvalues? Right, "as lvalues" makes sense. > And it was "These", so plural, and now it is singular, so do -> does? There's also pgd_val() a few lines below, it's just not visible in the patch. > Eike -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel