From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2000CA9EAF for ; Thu, 24 Oct 2019 16:31:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D49421872 for ; Thu, 24 Oct 2019 16:31:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Jhbc9z+n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D49421872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lxmZ4O5OOhnE8SdLJ65h4jLvIBymd3739uT1tphTrIs=; b=Jhbc9z+nbo30wf VSM9ZKQpte1DinwCV0gNGw7QPqExazXTQFlbz3ZsV+wVXGuPDN2I9ngd+jWfpXZBx8RWlxEVjhDZV TQer/3E1ayfwUla87WQCh8/bs8u3P1V7EtLzNLEYZphTkJSiS4fuznLpbrDsk78KyGwAlGQ4hJOu1 S21ykb3WYpmtWvc4TFYRxO1fY1oZYuAgFvS6tXWOBuJxH77itst6ULf1+jVwSqj1lm2STeRTbi+9Z G8fugMcr+e+juSJJ9rmyA4iL4uhnYk2N/NSUJ9bOup1vKrVsDdAlojp6WuEaYeT4QimtRwL5SQW15 tDk+ewAZ6MHxSokNRpuw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNg1O-0001he-8l; Thu, 24 Oct 2019 16:31:34 +0000 Received: from [217.140.110.172] (helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNg1L-0001gc-Mb for linux-arm-kernel@lists.infradead.org; Thu, 24 Oct 2019 16:31:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1545C32B; Thu, 24 Oct 2019 09:31:21 -0700 (PDT) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B0643F71F; Thu, 24 Oct 2019 09:31:19 -0700 (PDT) Date: Thu, 24 Oct 2019 17:31:17 +0100 From: Sudeep Holla To: Ulf Hansson Subject: Re: [PATCH 10/13] cpuidle: psci: Add a helper to attach a CPU to its PM domain Message-ID: <20191024163117.GB22036@bogus> References: <20191010113937.15962-1-ulf.hansson@linaro.org> <20191010113937.15962-11-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191010113937.15962-11-ulf.hansson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191024_093131_781548_6E5445D4 X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Lorenzo Pieralisi , linux-pm@vger.kernel.org, Stephen Boyd , linux-arm-msm@vger.kernel.org, Daniel Lezcano , "Rafael J . Wysocki" , Lina Iyer , Bjorn Andersson , Kevin Hilman , Rob Herring , Sudeep Holla , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 10, 2019 at 01:39:34PM +0200, Ulf Hansson wrote: > Introduce a PSCI DT helper function, psci_dt_attach_cpu(), which takes a > CPU number as an in-parameter and tries to attach the CPU's struct device > to its corresponding PM domain. > > Let's makes use of dev_pm_domain_attach_by_name(), as it allows us to > specify "psci" as the "name" of the PM domain to attach to. Additionally, > let's also prepare the attached device to be power managed via runtime PM. > > Signed-off-by: Ulf Hansson > --- > drivers/cpuidle/cpuidle-psci-domain.c | 21 +++++++++++++++++++++ > drivers/cpuidle/cpuidle-psci.h | 6 ++++++ > 2 files changed, 27 insertions(+) > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > index 3f5143ccc3e0..7429fd7626a1 100644 > --- a/drivers/cpuidle/cpuidle-psci-domain.c > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > @@ -9,9 +9,11 @@ > > #define pr_fmt(fmt) "CPUidle PSCI: " fmt > > +#include > #include > #include > #include > +#include > #include > #include > #include > @@ -279,3 +281,22 @@ static int __init psci_idle_init_domains(void) > return ret; > } > subsys_initcall(psci_idle_init_domains); > + > +struct device *psci_dt_attach_cpu(int cpu) > +{ > + struct device *dev; > + > + /* Currently limit the hierarchical topology to be used in OSI mode. */ > + if (!psci_has_osi_support()) > + return NULL; > + > + dev = dev_pm_domain_attach_by_name(get_cpu_device(cpu), "psci"); This clarifies the need for the fixed name. But why not just go by index 0 as the consumer of these psci power-domains will have only one power domain entry. Why do we need this name compulsory ? Further, it's specified as optional in the generic binding, do we make it "required" for this psci idle states binding anywhere that I missed ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel