From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45179CA9EA0 for ; Fri, 25 Oct 2019 16:22:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 152F421872 for ; Fri, 25 Oct 2019 16:22:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IlqODal7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 152F421872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3objuQTuRkdKZJ+6LSZXHK8NcwZNzrqou7nDR+L+qIg=; b=IlqODal7xUJ1mQ wcGO9Sj+8P2RVDXCYdlkMgvjchb13Tej3hDQfuf6PIRZIAjwEjZQvUoYmO3muAkpe4PLQEipXourn lW4JE2OAJ7jdRPJ1TPXymIJpWX+kC7nsmN28cnNOy5a4o3ozkwNZmi0PuXH5kJPHpALvNAKLkk11P wcdt7kF9b/kFlSO3oV5+EfjBZgBmTfVpSZB5Bbhciv1jgl7M2w0o9XpqKjQyhepVaAXI1VIjGUaG2 A8tF0htTndbJcVN285d/ycaQ1pwMpEKR05J7FLogEaftF1bXnDdHhH8abe++6WnRlODM/LbOe0j+g lBTjkXz00zf+Klpp/nIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iO2ML-0006XY-F1; Fri, 25 Oct 2019 16:22:41 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iO2MI-0006Vw-68; Fri, 25 Oct 2019 16:22:39 +0000 Received: by mail-ot1-f68.google.com with SMTP id z6so2464837otb.2; Fri, 25 Oct 2019 09:22:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DcXI0ptEmLNRJ3ATloq3LFD9nbZMbeqbCJ87LxNGHWo=; b=iBLMFthqM3AXSW1Bj9akCCKNKuiYHVgLvdXjTLu61KrMI855uEIWPDtyItiM+818/I wTjTp+/qxSVCVyKK7ZJlSBeFrrFKkaf+pEorQBjLBZ39v8qRe4jWqZlZZSfQyEjSRjMJ M/Z2QWGcgQl/3rFvMxiTKX93e8aph50QkXjl0OzYqxkE1L1kxaoRvpM2elDUhoSl3fIH M+HE4cLedwZl65TO8ep/ye2GbGlzpOFrhAEDcvs6ciy/pOelg3w+XmoXFtGdEb+TZzr3 VENBrKlYd11onI0y9D/Idxmg64LoxDzcg3BkM6vFCZeLyP/da5k6NyGdjd3WbzlofeQ1 0Scw== X-Gm-Message-State: APjAAAUKngvAXHP5fvk46erbHQ+/rFwSXpZHnSMiOuWjW0SKDsEx0bFe dA7OHYI2Hbrq0/EESP6FQw== X-Google-Smtp-Source: APXvYqzzIuc1vcdp++0F80RLl8KAdKlip2Nqm2Fe6QaByRNOoVA8SwaqBnoVkTda+L/6FQKAQI1xRg== X-Received: by 2002:a9d:3476:: with SMTP id v109mr3516135otb.211.1572020554577; Fri, 25 Oct 2019 09:22:34 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id i5sm836976otk.10.2019.10.25.09.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2019 09:22:33 -0700 (PDT) Date: Fri, 25 Oct 2019 11:22:32 -0500 From: Rob Herring To: Cheng-Yi Chiang Subject: Re: [PATCH v8 2/6] ASoC: rockchip-max98090: Support usage with and without HDMI Message-ID: <20191025162232.GA23022@bogus> References: <20191025133007.11190-1-cychiang@chromium.org> <20191025133007.11190-3-cychiang@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191025133007.11190-3-cychiang@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191025_092238_227921_880D8EC6 X-CRM114-Status: GOOD ( 12.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , alsa-devel@alsa-project.org, Heiko Stuebner , Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hans Verkuil , Andrzej Hajda , Laurent Pinchart , Jerome Brunet , Takashi Iwai , linux-rockchip@lists.infradead.org, dgreid@chromium.org, devicetree@vger.kernel.org, tzungbi@chromium.org, Jonas Karlman , Liam Girdwood , Russell King , Mark Brown , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , dianders@chromium.org, Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 25, 2019 at 09:30:03PM +0800, Cheng-Yi Chiang wrote: > There will be multiple boards sharing this machine driver. > Use compatible string to specify the use case. > > "rockchip,rockchip-audio-max98090" for max98090-only. > "rockchip,rockchip-audio-hdmi" for HDMI-only > "rockchip,rockchip-audio-max98090-hdmi" for max98090 plus > > Move these properties to optional because they are not needed for > HDMI-only use case. > "rockchip,audio-codec": The phandle of the MAX98090 audio codec > "rockchip,headset-codec": The phandle of Ext chip for jack detection > > The machine driver change will add support for HDMI codec in > rockchip-max98090. > Add one optional property "rockchip,hdmi-codec" to let user specify HDMI > device node in DTS so machine driver can find hdmi-codec device node for > codec DAI. Why not just use the presence of rockchip,hdmi-codec to enable HDMI or not. Maybe you still add rockchip,rockchip-audio-hdmi for HDMI only. Really, the same should have been done for which codec is used too, but I guess someone wanted 2 machine drivers. > > Signed-off-by: Cheng-Yi Chiang > --- > .../bindings/sound/rockchip-max98090.txt | 38 +++++++++++++++++-- > 1 file changed, 35 insertions(+), 3 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel