From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 181C7CA9EB9 for ; Sat, 26 Oct 2019 08:12:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD4EE21D81 for ; Sat, 26 Oct 2019 08:12:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ClRggV+7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wRieEcbL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD4EE21D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mq6q8bQ+9n8CPHX0yWI/5CZ6/KOzr+/X6Or0uYw8sjI=; b=ClRggV+7H9eI7v idpRphoEBPq1I89edhe72e2dtZaDW3x1WS+6pJE0PAQzqlpBNRdRn7loIdnXAK4sCRnkLbiD0USUQ pzP2X1xcoHm95Oj2kdzC0YpA2xA3uT5Zr8is1yNKLhQtgkBVEmfFKQNLSeLdhdexVK/mBiwrz1AkE U3UkLj4K1GrLWontuu3CcIKqUjlJOxsu0o3QTnRNGIF17E1Ww+kqmKSDKcX4DmrLS3SviPAbByz7v kbTQhD+sXgLbPPuNOR/irfI0b8mB2pkpW3VHUuBpzUovyoR4aMuFNXXFTheV1oAEJniTDF8dnWaIC UGg6W7mphpK9ztspV8aA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOHBd-0003ZC-Lg; Sat, 26 Oct 2019 08:12:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOHBb-0003Yh-9A for linux-arm-kernel@lists.infradead.org; Sat, 26 Oct 2019 08:12:36 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BBBD6214DA; Sat, 26 Oct 2019 08:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572077555; bh=uLrgR5dduFiKpCf2zS/LUfYO4qdcUR5sKFqtU9Ua3Xc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wRieEcbL9aSAvlkBKLiSjJvhvYjxTr7M/1F5X6n/1gwJb+4tm0rqZjlUNkmpTYBzR FSfVZf99PGNvd9h8CuatnG7fM6hyTPAc7Ab4mtZ1aUCi/aDRCTrxz7Up34ZLFBifko asjSu+zFgko2TZlDVN1OZjhZ57/BCAurusF6BDVs= Date: Sat, 26 Oct 2019 16:12:15 +0800 From: Shawn Guo To: Andreas Kemnade Subject: Re: [PATCH v3 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD Message-ID: <20191026081214.GB14401@dragon> References: <20191010192357.27884-1-andreas@kemnade.info> <20191010192357.27884-4-andreas@kemnade.info> <20191025134621.GN3208@dragon> <20191025200743.48455cc9@aktux> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191025200743.48455cc9@aktux> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191026_011235_344278_97468171 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, marex@denx.de, Marco Felsch , devicetree@vger.kernel.org, andrew.smirnov@gmail.com, s.hauer@pengutronix.de, angus@akkea.ca, linux-kernel@vger.kernel.org, j.neuschaefer@gmx.net, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, manivannan.sadhasivam@linaro.org, Discussions about the Letux Kernel , festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 25, 2019 at 08:07:43PM +0200, Andreas Kemnade wrote: > Hi, > > On Fri, 25 Oct 2019 21:46:24 +0800 > Shawn Guo wrote: > > [...] > > > + > > > + pinctrl_wifi_reset: wifi_reset_grp { > > > + fsl,pins = < > > > + MX6SLL_PAD_SD2_DATA7__GPIO5_IO00 0x10059 /* WIFI_RST */ > > > + >; > > > + }; > > > + > > > + pinctrl_wifi_power: wifi_power_grp { > > > > I guess you can have one pinctrl node to include both reset and power > > pins? Also, to be consistent with other pinctrl nodes on naming, the > > node name should probably be wifigrp. > > > well, the problems they are used in different nodes, so I cannot do > that: > > reg_wifi: regulator-wifi { > compatible = "regulator-fixed"; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_wifi_power>; > regulator-name = "SD3_SPWR"; > regulator-min-microvolt = <3000000>; > regulator-max-microvolt = <3000000>; > gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; > enable-active-high; > }; > > wifi_pwrseq: wifi_pwrseq { > compatible = "mmc-pwrseq-simple"; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_wifi_reset>; > post-power-on-delay-ms = <20>; > reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > }; Ah, yes, it makes more sense. I missed that. Shawn > > So having them combined breaks the mux where you use it rule. > I got in earlier mails: > > > > + wifi_pwrseq: wifi_pwrseq { > > > + compatible = "mmc-pwrseq-simple"; > > > + post-power-on-delay-ms = <20>; > > > + reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > > > Can you add a pinctrl-entry here please? The general rule is to mux > > things where you use it > [...] > > > + compatible = "regulator-fixed"; > > > + regulator-name = "SD3_SPWR"; > > > + regulator-min-microvolt = <3000000>; > > > + regulator-max-microvolt = <3000000>; > > > + > > > + gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; > > > Please add a pinctrl here to mux this gpio. > > Regards, > Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel