From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D648CA9EB9 for ; Sat, 26 Oct 2019 15:33:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36DFA20663 for ; Sat, 26 Oct 2019 15:33:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L0FaVKIw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36DFA20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=axRnQpDzhyaU9sD4JoMLwntQUczltwRIwrWKmbq52w8=; b=L0FaVKIwYh8ib6YKtPDCKO0vy cYHtAUewzMTegUCSSd4xx5u1jhigz3urq5BuqJGNZoTWByjqjYk4o8uJVOP5Zuhk0TJeeZuEogYQz CZrRiXfahAvXp7qv8RiQoEra7LYebW9BAYkiJjpo7/Z3+V08AcPmd3/07lZUCNAreElkb26zteNRj YssNK6cwi68ZloCQxfkeyJW+O/hUzGysbp7WFUqavYxyOW8Ez3isyORG/9Fdf7YiHqUS5FU/OYwwb rWaTUw5h9GuCh3AuCWQW6nix2tvPwcUpA+/sS34vaRRd6Ee+WkU3HZdqkuDyTGpvHF9nOJDBc7RbG ZNtcp6SwA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOO4B-0005Ph-Or; Sat, 26 Oct 2019 15:33:23 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOO47-0005P8-Tj for linux-arm-kernel@lists.infradead.org; Sat, 26 Oct 2019 15:33:21 +0000 Received: from localhost (p5486CC3E.dip0.t-ipconnect.de [84.134.204.62]) by pokefinder.org (Postfix) with ESMTPSA id 547462C03C5; Sat, 26 Oct 2019 17:33:15 +0200 (CEST) Date: Sat, 26 Oct 2019 17:33:15 +0200 From: Wolfram Sang To: Stefan Wahren Subject: Re: [PATCH RFC] i2c: bcm2835: Store pointer to bus clock Message-ID: <20191026153314.GA5137@kunai> References: <1572093288-6223-1-git-send-email-wahrenst@gmx.net> MIME-Version: 1.0 In-Reply-To: <1572093288-6223-1-git-send-email-wahrenst@gmx.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191026_083320_108792_837671C7 X-CRM114-Status: UNSURE ( 7.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Scott Branden , Ray Jui , Annaliese McDermond , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, Dave Stevenson , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7678244681165576323==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7678244681165576323== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SUOF0GtieIMvvwua" Content-Disposition: inline --SUOF0GtieIMvvwua Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > a NULL pointer dereference on driver unload. It seems that we can't fetch > the bus clock via devm_clk_get in bcm2835_i2c_remove. As an alternative Uh, yes, devm_* doesn't make sense in a remove function. We could probably use plain clk_get/put here, but a pointer seems fine, too. --SUOF0GtieIMvvwua Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl20ZzYACgkQFA3kzBSg KbakVA/+K2R/9SirG2DNayuOk52DPILr/uDihZvMo7UkD0EyCWhk+q/hJSTAZZD9 +cgGElLwuKJ6egXWaUuN9rgEIsjRU7kfnuBAf6lstPeLUWBJM8Xzl7OprTKVX0FH hGXR86MehWVEfAcAvTOKYrDAB2jTuwTiYasdQmF2jHipgdN8gOl5NRErGBfWPApq ICAr4I7PuwOrRqT8cXyX5j7A1USDx4GBa1424aygQ892SLc+r5chSmlEvGOxQZ40 QRxdVhGlHDWvO5C/kvppVvKxI/BwQN2mQ9el/bkkFBEYuqKC0bv1aMkAAothWRP2 o0yNRQcqz4aZv07ve/RuyMxQyFXJMjIutHs72SwiHhlpVNxIg2PiyEYDx02wS36v ZTLnMnZWfYIEHmTkpyzgcZh12WKWpCSUmDWuJCofslPadCXhxWYYt6GNMr1oEeac 4HbSW28ngj1zM8buQRQPt1bgGfFNcVLHi8uZqAzi9vfBBIo/mFF3d44adxB/h1JN BfYCcVODBDYABWIAAKLstydW7LLy5EjgpOQLe+DHb7+XjRKsU0VkVARCsGSDcSd1 TkRuGJCYaF0cJ2cW/k1MnROE9C+W6M2fAZJfrWB8gOO0EmWMsSeMt5GzaARjTUq0 1iBLQYhmi+SQNUHL882J8mrGY+95bdXJk06S9WVtChiai3GRdJM= =xaw5 -----END PGP SIGNATURE----- --SUOF0GtieIMvvwua-- --===============7678244681165576323== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7678244681165576323==--