* [PATCH] zx: make zx_smp_prepare_cpus static
@ 2019-10-17 10:39 Ben Dooks (Codethink)
2019-10-28 3:06 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks (Codethink) @ 2019-10-17 10:39 UTC (permalink / raw)
To: linux-kernel
Cc: Jun Nie, Ben Dooks (Codethink), Shawn Guo, Russell King,
linux-arm-kernel
The zx_smp_prepare_cpus is not declared and not directly
exported outside of the file it is in. Make it static to
remove the following sparse warning:
arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Jun Nie <jun.nie@linaro.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
---
arch/arm/mach-zx/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c
index d4e1d3792224..43a33eaff388 100644
--- a/arch/arm/mach-zx/platsmp.c
+++ b/arch/arm/mach-zx/platsmp.c
@@ -38,7 +38,7 @@ static void __iomem *pcu_base;
static void __iomem *matrix_base;
static void __iomem *scu_base;
-void __init zx_smp_prepare_cpus(unsigned int max_cpus)
+static void __init zx_smp_prepare_cpus(unsigned int max_cpus)
{
struct device_node *np;
unsigned long base = 0;
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] zx: make zx_smp_prepare_cpus static
2019-10-17 10:39 [PATCH] zx: make zx_smp_prepare_cpus static Ben Dooks (Codethink)
@ 2019-10-28 3:06 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2019-10-28 3:06 UTC (permalink / raw)
To: Ben Dooks (Codethink), Arnd Bergmann
Cc: linux-kernel, Jun Nie, Russell King, linux-arm-kernel
On Thu, Oct 17, 2019 at 11:39:34AM +0100, Ben Dooks (Codethink) wrote:
> The zx_smp_prepare_cpus is not declared and not directly
> exported outside of the file it is in. Make it static to
> remove the following sparse warning:
>
> arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Shawn Guo <shawnguo@kernel.org>
@Arnd, please help apply it to arm-soc, thanks!
Shawn
> ---
> Cc: Jun Nie <jun.nie@linaro.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/mach-zx/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c
> index d4e1d3792224..43a33eaff388 100644
> --- a/arch/arm/mach-zx/platsmp.c
> +++ b/arch/arm/mach-zx/platsmp.c
> @@ -38,7 +38,7 @@ static void __iomem *pcu_base;
> static void __iomem *matrix_base;
> static void __iomem *scu_base;
>
> -void __init zx_smp_prepare_cpus(unsigned int max_cpus)
> +static void __init zx_smp_prepare_cpus(unsigned int max_cpus)
> {
> struct device_node *np;
> unsigned long base = 0;
> --
> 2.23.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-28 3:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-17 10:39 [PATCH] zx: make zx_smp_prepare_cpus static Ben Dooks (Codethink)
2019-10-28 3:06 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).