public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
	patchwork-lst@pengutronix.de
Subject: Re: [PATCH] arm64: dts: zii-ultra: add i210 ethernet node
Date: Mon, 28 Oct 2019 14:15:41 +0800	[thread overview]
Message-ID: <20191028061540.GM16985@dragon> (raw)
In-Reply-To: <20191021164200.31051-1-l.stach@pengutronix.de>

On Mon, Oct 21, 2019 at 06:42:00PM +0200, Lucas Stach wrote:
> Used by the bootloader to patch in the correct MAC address for
> the ethernet adapter.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> index 087b5b6ebe89..7933c685fe6a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> @@ -475,6 +475,17 @@
>  	         <&pcie1_refclk>;
>  	clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
>  	status = "okay";
> +
> +	host@0 {

Where is the bindings documenting this child node of pcie device?

> +		reg = <0 0 0 0 0>;
> +
> +		#address-cells = <3>;
> +		#size-cells = <2>;
> +
> +		i210: i210@0 {

Can we have generic node name for it?

Shawn

> +			reg = <0 0 0 0 0>;
> +		};
> +	};
>  };
>  
>  &pgc_gpu {
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-28  6:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 16:42 [PATCH] arm64: dts: zii-ultra: add i210 ethernet node Lucas Stach
2019-10-28  6:15 ` Shawn Guo [this message]
2019-10-30 16:44   ` Lucas Stach
2019-11-04  1:04     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191028061540.GM16985@dragon \
    --to=shawnguo@kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=patchwork-lst@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox