From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B811CCA9EC0 for ; Mon, 28 Oct 2019 14:54:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BFA7208C0 for ; Mon, 28 Oct 2019 14:54:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qXCb63t2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dw85Ikz4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BFA7208C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9xPCR/RbZPHJX86hKzT/LKNpTL+7XFRjGvpIysa2wkM=; b=qXCb63t2lnVQvo m5ZJnbUn+dDElWv/LAoyuLFvokBVW1OFOm1xZqD6HYgQlOWXwK4pqsfYedjqGGgHCuYdivZ+8eruG A2b4y9NHfIthjZOt+Dpefz6NNXbQG0xkNNQuMgWnXoc62fsCAhjKjBdX/Le+s4SxpcYJRuuSkYS/g S0IK1ptUmEbZHoMNRbJMnMxDPDZgROGkn1/4yJSd+207ekScugfseDn8fqQ7v8fgUH2AvkSLd4wEe xCf0oWKm7oyt9JFhXJN0v9W+mVQNuOEZMK7DIYsFPljZpobuMoOZaIsuRQ9vqllyi+Qhm+iRHdLcu W1FkRx7NiEvvVDK1KGCg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP6Pt-0007kK-Ay; Mon, 28 Oct 2019 14:54:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP6Pq-0007jn-Ne for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2019 14:54:44 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D642208C0; Mon, 28 Oct 2019 14:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572274482; bh=PhikCgxetaRn/QivtL9ZiSUgV42VKkp/4HdVJZ8os4U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dw85Ikz4lNXGWHUl0us9s7fvZdUBNCBRGUFZ7f+StA3QWPMTkkrTS4xJ/GijSDjoa lW3bELx6pSpRkQnSl4zhBqAq5pRiaceRHsPuqVeYioT0YyiYPDKWfOEHBOygaI6snV WS1JhnOoWnyxLumtfABtheA2vVBN5asMkIoImXvE= Date: Mon, 28 Oct 2019 14:54:37 +0000 From: Will Deacon To: Joakim Zhang Subject: Re: [PATCH 1/2] perf/imx_ddr: add enhanced AXI ID filter support Message-ID: <20191028145436.GA5576@willie-the-truck> References: <20190906082356.25485-1-qiangqing.zhang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190906082356.25485-1-qiangqing.zhang@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_075442_791209_DAB8A1B2 X-CRM114-Status: GOOD ( 16.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , Frank Li , "robin.murphy@arm.com" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 06, 2019 at 08:26:55AM +0000, Joakim Zhang wrote: > With DDR_CAP_AXI_ID_FILTER quirk, indicating HW supports AXI ID filter > which only can get bursts of reading/writing DDR, i.e. DDR read/write > request. > > This patch add DDR_CAP_AXI_ID_ENHANCED_FILTER quirk, indicating HW > supports AXI ID filter which can get bytes of reading/writing DDR. This > feature is more meaningful due to we always care more about bandwidth. > > Need select both above two qiurks together when HW support enhanced AXI > ID filter. > > Signed-off-by: Joakim Zhang > --- > drivers/perf/fsl_imx8_ddr_perf.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c > index ce7345745b42..5f70dbfa9607 100644 > --- a/drivers/perf/fsl_imx8_ddr_perf.c > +++ b/drivers/perf/fsl_imx8_ddr_perf.c > @@ -45,7 +45,8 @@ > static DEFINE_IDA(ddr_ida); > > /* DDR Perf hardware feature */ > -#define DDR_CAP_AXI_ID_FILTER 0x1 /* support AXI ID filter */ > +#define DDR_CAP_AXI_ID_FILTER BIT(1) /* support AXI ID filter */ Is this a deliberate change from the previous code and, if so, why? > +#define DDR_CAP_AXI_ID_FILTER_ENHANCED BIT(2) /* support enhanced AXI ID filter */ What does it mean to have DDR_CAP_AXI_ID_FILTER_ENHANCED but not DDR_CAP_AXI_ID_FILTER? Could we just say that DDR_CAP_AXI_ID_FILTER_ENHANCED implies DDR_CAP_AXI_ID_FILTER? > struct fsl_ddr_devtype_data { > unsigned int quirks; /* quirks needed for different DDR Perf core */ > @@ -209,7 +210,15 @@ static void ddr_perf_free_counter(struct ddr_pmu *pmu, int counter) > > static u32 ddr_perf_read_counter(struct ddr_pmu *pmu, int counter) > { > - return readl_relaxed(pmu->base + COUNTER_READ + counter * 4); > + if ((pmu->devtype_data->quirks & DDR_CAP_AXI_ID_FILTER) && > + (pmu->devtype_data->quirks & DDR_CAP_AXI_ID_FILTER_ENHANCED)) { > + if ((pmu->events[counter]->attr.config == 0x41) || > + (pmu->events[counter]->attr.config == 0x42)) > + return readl_relaxed(pmu->base + COUNTER_DPCR1 + counter * 4); In which case, this could be slightly simplified. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel