From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3834CA9EC0 for ; Mon, 28 Oct 2019 16:44:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9603720717 for ; Mon, 28 Oct 2019 16:44:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jACXOs4L"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="yqVSXkmC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9603720717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0RI/4AUzpIZSKimDnYM3r9z9g3H5tBNdzpkGqNWrfr4=; b=jACXOs4LqsIWN1 MvWvln/ra1pzVbdPujm2a4LVvr70istpiWLVmL+mpXg6gn2t7KBC+LhZLh4MOQ7VQlxxoBRJq2/A5 yA6jZkW4oyc1wl956bwTKhf1A29auIKVKMsoXtJOm83rX0VT32sfaH9+lHz8rPMwH/0LfOrFHDa80 z509zJE+eOO37t0PsUOBLNv5/qwiRUE2HapCJvZwPFfWwOk0nuTpHN4pbtFP/zT8uv3MSjsbJFTMu pD/cPmYhf8xzcc4zEPkEiXzanal0CPtrA4eF6M2wjmTpNk1H7gr8vhfT7pHxr/zww5SjBH0TlQ7pX n5874WRI6HYgq2Qd1/Fg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP888-0002Oq-Up; Mon, 28 Oct 2019 16:44:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP85d-0008QF-2o for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2019 16:41:58 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DE9120717; Mon, 28 Oct 2019 16:41:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572280916; bh=xtvPd1K/YDW7pOBLtD45xOTJPSaoVEBKM/lFmfsk+04=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yqVSXkmCm0ZzMkqp9I3WP1EDc2BAzYsjc90PkXO9y3vZOZvnOYvA8I5H0zhGnodkU gHhZSDI+/bAmJmO/06vSWWfhBiIbZkqQ3NF0+klZAAnUN8N78KP7Eptjm+1l4Jx7c9 3f0bwKZeh7ISaQoMrM82OPdz0s+KFVa7jfxbp1pA= Date: Mon, 28 Oct 2019 16:41:51 +0000 From: Will Deacon To: Xiang Zheng Subject: Re: [PATCH] arm64: print additional fault message when executing non-exec memory Message-ID: <20191028164150.GG5576@willie-the-truck> References: <20191028090837.39652-1-zhengxiang9@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191028090837.39652-1-zhengxiang9@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_094157_182390_D08099EC X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, james.morse@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wanghaibin.wang@huawei.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 28, 2019 at 05:08:37PM +0800, Xiang Zheng wrote: > When attempting to executing non-executable memory, the fault message > shows: > > Unable to handle kernel read from unreadable memory at virtual address > ffff802dac469000 > > This may confuse someone, so add a new fault message for instruction > abort. > > Signed-off-by: Xiang Zheng > --- > arch/arm64/mm/fault.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > index 9fc6db0bcbad..68bf4ec376d0 100644 > --- a/arch/arm64/mm/fault.c > +++ b/arch/arm64/mm/fault.c > @@ -318,6 +318,8 @@ static void __do_kernel_fault(unsigned long addr, unsigned int esr, > if (is_el1_permission_fault(addr, esr, regs)) { > if (esr & ESR_ELx_WNR) > msg = "write to read-only memory"; > + else if (is_el1_instruction_abort(esr)) > + msg = "execute non-executable memory"; nit, please make this "execute from non-executable memory". With that: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel