From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99414CA9EC0 for ; Mon, 28 Oct 2019 17:36:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73FB9208C0 for ; Mon, 28 Oct 2019 17:36:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a9cw7ErA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73FB9208C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rmQwJaL8J8/czTor0pHZNkDzBhb3YPkNRpJI5kcDxP8=; b=a9cw7ErAgWdlk9 DVSLOn+psdrCSwz8r67L8e9pMG1vBWOghmIMl5sGUst98yYokw2DYbecAmTZr6t4LHv6lir7jn9wl rpBP/i/a/k+hJIvb4L4F6JtFDCfbNq2DsLdpOAsEuESL0R7F5AvzbUUFlXfLQVNbQ6ts+0k3/a24S ODlnShnhE0PR0AT7T/SlH/iRD4BS9hLrmGHqC3C1frScudRkqlydLDx/37oY/HAT+vgnJnUxMrdiN NQOyj0mweRYWK3KrGCrSC+0NHy/u6M0Bk2lSFNuD6XHCzww37l5wq3I8JJFz43J5DdaGptqNwE4f6 5Tl2bT25NmlkeoWOOu7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP8vy-0000cS-TD; Mon, 28 Oct 2019 17:36:02 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP8vv-0000aX-EZ for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2019 17:36:01 +0000 Received: by mail-ed1-f67.google.com with SMTP id k2so8548492edx.2 for ; Mon, 28 Oct 2019 10:35:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5Q/O2+63vyfOOc8TciZScYae9QvHO/ZsisH+/bPe/bY=; b=C4P7Nwf+uBrIWZoYN9FhOmerj4DjF9XzzbYJn+pxRrhas2p4exS7W/duf/318xVTX5 ivGIYAsDhxLbQG0q1fkkaBzFN9ztJdvkbPBXe5oe6BILndK3OJ2KGECu9zmz5uQ++9cM 2RfWF/hmC8nTbmaMnhd85zyqcCEoh8aMzl0xdPUzsPM7rcaxl4LXkCYbA9GpmboD8gLm wfvSW/jIoZMDszk5esp429pIfcwAn2fr1/TLt9cklxMbZ0nwzxyaix6NhsxII9nuNsjw 12hc9+NskYxMnkhElw3b34ru8gMC3L38RekYdrkoG4GnVq5rfVJCC2pGkMcXQYHaWSCA b9/A== X-Gm-Message-State: APjAAAVmqMC7dpI8ukUaMe8GON8Z9BkQZbqcZzCn+gHsLZfJ6VEfSEn6 CJmjAEhu5LlMwE9XoHeUolo= X-Google-Smtp-Source: APXvYqzoUJl7QMBZQoYR89SoTXUdW/ohGM8/IS7x6+XbBSVHr6HcscdiM7+fVXuN3VrPgkEN0cQ0OA== X-Received: by 2002:aa7:d3c4:: with SMTP id o4mr21407071edr.194.1572284157625; Mon, 28 Oct 2019 10:35:57 -0700 (PDT) Received: from kozik-lap ([194.230.155.180]) by smtp.googlemail.com with ESMTPSA id f19sm565060edx.48.2019.10.28.10.35.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Oct 2019 10:35:56 -0700 (PDT) Date: Mon, 28 Oct 2019 18:35:55 +0100 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH v6 1/2] soc: samsung: Add Exynos Adaptive Supply Voltage driver Message-ID: <20191028173555.GB14395@kozik-lap> References: <20191028151534.9920-1-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191028151534.9920-1-s.nawrocki@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_103559_489282_665D6C72 X-CRM114-Status: GOOD ( 19.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, vireshk@kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 28, 2019 at 04:15:33PM +0100, Sylwester Nawrocki wrote: > The Adaptive Supply Voltage (ASV) driver adjusts CPU cluster operating > points depending on exact revision of an SoC retrieved from the CHIPID > block or the OTP memory. This allows for some power saving as for some > CPU clock frequencies we can lower CPU cluster's supply voltage comparing > to safe values common to all the SoC revisions. > > This patch adds support for Exynos5422/5800 SoC, it is partially based > on code from https://github.com/hardkernel/linux repository, > branch odroidxu4-4.14.y, files: arch/arm/mach-exynos/exynos5422-asv.[ch]. > > Tested on Odroid XU3, XU4, XU3 Lite. > > Signed-off-by: Sylwester Nawrocki > --- > Changes since v5: > - "syscon" compatible in the chipid node is not required any more, > use device_node_to_regmap() instead of syscon_node_to_regmap(), > - dropped "Unsupported product ID" log, > - EXYNOS_ASV_SYSBSYS* enumeration simplified and moved to exynos5422 > specific header, > - dropped unnecessary headers inclusion, > - dropped unused argument from exynos5422_asv_parse* helpers, > - added const qualifier to some function arguments. > > Changes since v4: > - Fixed include guard in drivers/soc/samsung/exynos5422-asv.h > > Changes since v3: > - instead of removing/adding OPP use dedicated API to adjust OPP's > voltage, only exynos_asv_update_cpu_opps() function has changed, > - added a comment describing ASV tables at beginning of > exynos5422-asv.c file. > > Changes since v2: > - use devm_kzalloc() in probe() to avoid memory leak, > - removed leading spaces in exynos-chipid.h, > - removed unneeded header inclusion, > - dropped parentheses from exynos542_asv_parse_sg(), > - updated Kconfig entry, > - added const attribute to struct exynos_asv_susbsys::cpu_dt_compat. > > Changes since v1 (RFC): > - removed code for parsing the ASV OPP tables from DT, the ASV OPP tables > moved to the driver, > - converted to use the regmap API, > - converted to normal platform driver. > > --- > drivers/soc/samsung/Kconfig | 10 + > drivers/soc/samsung/Makefile | 3 + > drivers/soc/samsung/exynos-asv.c | 177 ++++++++++ > drivers/soc/samsung/exynos-asv.h | 71 ++++ > drivers/soc/samsung/exynos5422-asv.c | 505 +++++++++++++++++++++++++++ > drivers/soc/samsung/exynos5422-asv.h | 31 ++ > 6 files changed, 797 insertions(+) > create mode 100644 drivers/soc/samsung/exynos-asv.c > create mode 100644 drivers/soc/samsung/exynos-asv.h > create mode 100644 drivers/soc/samsung/exynos5422-asv.c Thanks, applied. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel