From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_ADSP_ALL, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F282C47E49 for ; Tue, 29 Oct 2019 01:25:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E731621835 for ; Tue, 29 Oct 2019 01:25:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Tru83le1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=megous.com header.i=@megous.com header.b="A9YyLgNh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E731621835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=megous.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6zdxi005WdI44u6BsYQQKvNWyT0mKvj0sK2XxR5T9Jk=; b=Tru83le1JtHnzc nsNsvq63dY4HoPtU/C0i62gOvgMRVxkZzf8hoKjdVbRZBRF7Dkw5b6Po7k1P7XOvhRMUN3nsPH7ad yAPXwQP/egcALINjsf8Vd7uS/9JRoDK6DLB4vqr4DnYcuOGXJ8Vumsq15RFfGjsS5Juv6ZDgaZJBk 5tqc3FgJ88KLzIByOqGEYgvKkAenP4vzs7XTR1s4e+8G/8A8G/+admecHaBx5SHDciJKlo/X7THE9 jm1o4wEt1oaZaK1LbBGIPQqwNVE/JpkTjSF5F8l4mjDzKNoEVkNtssF7D6fiCL7U/BPBWECuJLsvp aQPCRaLpLoDk6iEuz7Sw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPGGC-0002EK-7p; Tue, 29 Oct 2019 01:25:24 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPGG8-0002Dh-9q for linux-arm-kernel@lists.infradead.org; Tue, 29 Oct 2019 01:25:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1572312318; bh=yZJ2tr1txca9SLDOy4OtsLu+iAa2f0cZDLnWQ7+OML8=; h=Date:From:To:Cc:Subject:References:X-My-GPG-KeyId:From; b=A9YyLgNhvrxlUztIuCRhuPElEulYpYKTMOb3Hdyf6b5wAYii97AeXsS/rGMCkEskW C0mY/yPIhHdiJKF25+6vtI21q6NsMXjfK/3/CxdTMg40ZTSycRT5LkucjHFQUkMiKD jKO8p4ACl0Huenevm29Hl1sHst+Z8pOKmICnXozU= Date: Tue, 29 Oct 2019 02:25:17 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Chen-Yu Tsai Subject: Re: [linux-sunxi] [PATCH] ARM: sunxi: Fix CPU powerdown on A83T Message-ID: <20191029012517.eddekmphtxyslevx@core.my.home> Mail-Followup-To: Chen-Yu Tsai , linux-sunxi , stable , Maxime Ripard , Russell King , "moderated list:ARM/Allwinner sunXi SoC support" , open list References: <20191028214914.3465156-1-megous@megous.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_182520_515207_8B991A00 X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: open list , Maxime Ripard , Russell King , linux-sunxi , stable , "moderated list:ARM/Allwinner sunXi SoC support" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 29, 2019 at 09:09:40AM +0800, Chen-Yu Tsai wrote: > On Tue, Oct 29, 2019 at 5:49 AM Ondrej Jirman wrote: > > > > PRCM_PWROFF_GATING_REG has CPU0 at bit 4 on A83T. So without this > > patch, instead of gating the CPU0, the whole cluster was power gated, > > when shutting down first CPU in the cluster. > > > > Fixes: 6961275e72a8c1 ("ARM: sun8i: smp: Add support for A83T") > > Signed-off-by: Ondrej Jirman > > Cc: stable@vger.kernel.org > > Acked-by: Chen-Yu Tsai > > Though I distinctly remember the BSP had some code dealing with chip > revisions in which the two bits were reversed. :( Actually, it's a bit more complicated. There's a special check in BSP code (grep for SUN8IW6P1_REV_A) that instead of power gating, just holds the core in reset for that revision. regards, o. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel