From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7941CCA9EAE for ; Tue, 29 Oct 2019 11:16:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 497AA208E3 for ; Tue, 29 Oct 2019 11:16:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iofW3ihc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GdaMUmmg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 497AA208E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9JKQInOIPmhrNgAvp6tA0344Ba/6+4WbtF4r00lJ9/4=; b=iofW3ihcMX+h7G FGt/RJRWrjFGBdPoSIC5uPBhc6IvXqXfVs3yAkKLaofo5Jrb6D8RQd+AGEj7/sazA0jXHpy1CenPR qnJB0FOhLgWI6FE6PfK+zg/mPUwkFECYuQoQK7oJ6WKh/MaQl7KFp2vNHWs7HQngWdziBEHpxLnt4 szj/ITQgVFB9qWO6CPwgjZ+2MRV/egfpHsprIamj0HccKdAkv1iiiINMLAoMdCV3uf1HLqkCtVvkz l+d5LQ1pPJxiQdrPd59EUKuZaVslxtzzCXAurSskggmcTVOMC8rdwJ3zExkzx67IIprW/QTrYp2hm N9QZ2/+BTQxjSszG+QYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPPTo-0002B4-Jq; Tue, 29 Oct 2019 11:16:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPPTk-0002AM-UL for linux-arm-kernel@lists.infradead.org; Tue, 29 Oct 2019 11:16:02 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 12913208E3; Tue, 29 Oct 2019 11:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572347760; bh=PYpYmLCcRCDnvoNd2S0sMHcaEM2JronWu9CsKftbO3I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GdaMUmmgMjWuXCjwK0dWZlcoWZbdkss1hf/IPKcAItun5DvAeYWYvYEXepIKuV8F4 Cgj6BmO5LCR5kVQSqH6TeJrA5sMtyubLtUhcJCViQ3HQZ9x8ffrdD48QttQIxJTdvs cKuoCU3Lo8JRJ8savTdPFUcs8+VjcCEB/d/GTobo= Date: Tue, 29 Oct 2019 11:15:56 +0000 From: Will Deacon To: Robin Murphy Subject: Re: [PATCH v2] iommu/arm-smmu: fix "hang" when games exit Message-ID: <20191029111555.GF11590@willie-the-truck> References: <418d8426-f299-1269-2b2e-f86677cf22c2@arm.com> <20191007204906.19571-1-robdclark@gmail.com> <20191028222042.GB8532@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191029_041601_001655_71FF9806 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Joerg Roedel , iommu@lists.linux-foundation.org, open list , Rob Clark , freedreno , "moderated list:ARM SMMU DRIVERS" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 28, 2019 at 10:51:53PM +0000, Robin Murphy wrote: > On 2019-10-28 10:38 pm, Rob Clark wrote: > > On Mon, Oct 28, 2019 at 3:20 PM Will Deacon wrote: > > > On Mon, Oct 07, 2019 at 01:49:06PM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > When games, browser, or anything using a lot of GPU buffers exits, there > > > > can be many hundreds or thousands of buffers to unmap and free. If the > > > > GPU is otherwise suspended, this can cause arm-smmu to resume/suspend > > > > for each buffer, resulting 5-10 seconds worth of reprogramming the > > > > context bank (arm_smmu_write_context_bank()/arm_smmu_write_s2cr()/etc). > > > > To the user it would appear that the system just locked up. > > > > > > > > A simple solution is to use pm_runtime_put_autosuspend() instead, so we > > > > don't immediately suspend the SMMU device. > > > > > > Please can you reword the subject to be a bit more useful? The commit > > > message is great, but the subject is a bit like "fix bug in code" to me. > > > > yeah, not the best $subject, but I wasn't quite sure how to fit > > something better in a reasonable # of chars.. maybe something like: > > "iommu/arm-smmu: optimize unmap but avoiding toggling runpm state"? > > FWIW, I'd be inclined to frame it as something like "avoid pathological RPM > behaviour for unmaps". LGTM! Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel