From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE661CA9EC5 for ; Wed, 30 Oct 2019 13:56:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A07220874 for ; Wed, 30 Oct 2019 13:56:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EwnW5Bgp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A07220874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U7iGyX4LVPK/X06PBmdny3frxRZeFDOJXhQorj4foWo=; b=EwnW5BgpdV5/ly fRykqUIdo4iNG843CWq2aZmsC4m7WVVyNpzvhVuiAHMfD0XjYyO9ipmluThcNxB0JVAKS4NzF4cO+ TD7tA2gi0UMBL2ip8Z29CRxz8nXklsatDVPQ9rZeJMJ9t08JPrHgUldVKblyXo8svL8VV18Ihlt5S 7RWAIVtr95gGS4+xZSD7n8sNUK+xN/9Siew9S+yDHjaKDiUIyb+gLmf6CYgEbUF0zDhQ2COM49319 98V2hDW6Vdjp/d1L60l/YrBs3VCmsTYxM0oaFJiiMG8RAFLr8xNu4QHXGJG2X8ZvnFEtUWXk6ooJi ptCvPns49n+GMoncPYwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPoSM-0007wf-L4; Wed, 30 Oct 2019 13:56:14 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPoSK-0007wD-NT; Wed, 30 Oct 2019 13:56:13 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 06:56:04 -0700 X-IronPort-AV: E=Sophos;i="5.68,247,1569308400"; d="scan'208";a="193975489" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 06:55:58 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id BEC0E208A0; Wed, 30 Oct 2019 15:55:27 +0200 (EET) Date: Wed, 30 Oct 2019 15:55:27 +0200 From: Sakari Ailus To: Dongchun Zhu Subject: Re: [V2, 2/2] media: i2c: Add more sensor modes for ov8856 camera sensor Message-ID: <20191030135527.GH10211@paasikivi.fi.intel.com> References: <20190910130446.26413-1-dongchun.zhu@mediatek.com> <20190910130446.26413-3-dongchun.zhu@mediatek.com> <20190910174450.GJ2680@smile.fi.intel.com> <1572440653.21623.272.camel@mhfsdcap03> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1572440653.21623.272.camel@mhfsdcap03> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191030_065612_773571_324069AD X-CRM114-Status: UNSURE ( 6.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, drinkcat@chromium.org, srv_heupstream@mediatek.com, shengnan.wang@mediatek.com, Andy Shevchenko , tfiga@chromium.org, louis.kuo@mediatek.com, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 30, 2019 at 09:04:13PM +0800, Dongchun Zhu wrote: > > > + ov8856->is_1B_revision = (val == OV8856_1B_MODULE) ? 1 : 0; > > > > !! will give same result without using ternary operator. > > > > Fixed in next release. But casting to bool will have the same effect. Integers are also not needed. I.e. this can be written as: ov8856->is_1B_revision = val == OV8856_1B_MODULE; -- Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel