From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF44CA9EC5 for ; Wed, 30 Oct 2019 15:36:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED748205C9 for ; Wed, 30 Oct 2019 15:36:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fG9Juo3p"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="VB1S7pNV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED748205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bsyKaHaGtigZSh7jSOt28xuvRBA6zMXd86DGzJPn3VA=; b=fG9Juo3pl9oSkp GsEpBzBh4PwoOHD80yg3//POScboiuNdIoyPn6vXqH5O00btTC/BcOZ46q30lwJL5i4lfFysmBxxG LeljT1p28IW8el6v+XHxCtUTibq5ItlAvVznMxnuaonBMIpW2yzpixzl1C4aBYxoIq56y/flI/Vko YbGpK8k97hR9B/1l08ziL7OylCPe8KWojMoLL5Zfjab6WRExch1x3pV/rUnbDGV3hgB37qJrl/GJ3 PAscBJqIASs+Qrwr8Jy0rdrbOpZaIXWV8pq++uf/M9u8a94A1wC5xJVXXvYJd0Tn/Twx59pFh1E// 0ZR68K6QOroplfSAPvaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPq1h-0004iC-EV; Wed, 30 Oct 2019 15:36:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPq1e-0004hd-8t for linux-arm-kernel@lists.infradead.org; Wed, 30 Oct 2019 15:36:47 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 34C27205C9; Wed, 30 Oct 2019 15:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572449805; bh=OnqREm4tm82WExRUaETf0Uzd6mEGoQvkv5iu9iS7co4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VB1S7pNVWBSSW8mCmMe8FwnwYoTrxdEHymmmcmHRm+2LPgn2k76eFGsGMO041McFL 6pK2T/FwFb0fPdZ+om4uTkcgozLEBDy+L/uL450mvU1+Dt+cv6TUG2RiiZ/5zwCsZC rB32RGh1kU8fOHWYyLFMpNUCeo9MVrZejrKO7nOE= Date: Wed, 30 Oct 2019 15:36:40 +0000 From: Will Deacon To: Joakim Zhang Subject: Re: [PATCH 1/2] perf/imx_ddr: add enhanced AXI ID filter support Message-ID: <20191030153640.GB19096@willie-the-truck> References: <20190906082356.25485-1-qiangqing.zhang@nxp.com> <20191028145436.GA5576@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191030_083646_329924_74677139 X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , Frank Li , "robin.murphy@arm.com" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Joakim, Please can you try to configure your email client correctly, so that you don't have to prefix your replies with '[Joakim]'? I use mutt, which works pretty well, but you can look at Documentation/process/email-clients.rst for hints about using other clients. On Tue, Oct 29, 2019 at 07:02:28AM +0000, Joakim Zhang wrote: > > From: Will Deacon > > On Fri, Sep 06, 2019 at 08:26:55AM +0000, Joakim Zhang wrote: > > > diff --git a/drivers/perf/fsl_imx8_ddr_perf.c > > > b/drivers/perf/fsl_imx8_ddr_perf.c > > > index ce7345745b42..5f70dbfa9607 100644 > > > --- a/drivers/perf/fsl_imx8_ddr_perf.c > > > +++ b/drivers/perf/fsl_imx8_ddr_perf.c > > > @@ -45,7 +45,8 @@ > > > static DEFINE_IDA(ddr_ida); > > > > > > /* DDR Perf hardware feature */ > > > -#define DDR_CAP_AXI_ID_FILTER 0x1 /* support AXI ID > > filter */ > > > +#define DDR_CAP_AXI_ID_FILTER BIT(1) /* support AXI ID > > filter */ > > > > Is this a deliberate change from the previous code and, if so, why? > > [Joakim] DDR PMU integrated in various SoCs may have different > features(extend more features), use BIT(1)/BIT(2)/BIT(3)... instead of > 0x1/0x2/0x4..., I think it is more easier. This deliberate change from > previous code has no functional effect. My point was that I don't think BIT(1) == 0x1. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel