From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68730CA9EC9 for ; Fri, 1 Nov 2019 08:27:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3ACAE21734 for ; Fri, 1 Nov 2019 08:27:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LQSx2VHX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bmNAWnJ4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ACAE21734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4ZGwTCiXhbtkWIFbn1+ZPyLPAUYxbRWQz4Tv0vju+R8=; b=LQSx2VHXXvYpR7 bH/HuqCT2lirbmOpREQmvaqGT2TJ9lMnQ/TwGzaolNuNVNuhLx//iHXjykIO9cRvJrcqBXa2EjK1N b0Ljl/pwu7WAA8yFpa4vXAo+qfV0WkjknZ/rnaGKmk7Cn0TX0HKDq3dIdsqkVsG1cLAVeLl7TKh+V MYWde2+mXLFDoT3g6fX8qoHuf+mTDJ4/M0ppuYdMNwWJOUe1YkwJA+kiv/9ziWO5OIKYoZhLiUPPY fk5I/sicz7+3mkPEfnpxaRt7OOsFrCbPgfGRzwzze4h2IjYw4sHZGPVa75Mjdjspj4OSM57cn7YhT QVeT8PsOLXBQJTiBuC6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQSHT-0001NG-Kh; Fri, 01 Nov 2019 08:27:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQSHQ-0001Mp-UR for linux-arm-kernel@lists.infradead.org; Fri, 01 Nov 2019 08:27:38 +0000 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93E34208CB; Fri, 1 Nov 2019 08:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572596856; bh=UGrR3iRTKwrbEPN+BHW52XhDbxZkXvMXHC6V2nHaiuU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bmNAWnJ4mnMMumb5K9Z5TPfbVMVSG14pUOCb3DPJ2XA3W3x2H1DIt1TB7ofMdQf/9 xPDRzfPxGa0pirP3JilU8xsrw6ZA13MRWl7fwDeFP0EsYSKwGnLb8Rpw92376oeBOC 5oB8tSHl21zhhbFjvyD42aR6cbPogZi4FsIaQY2k= Date: Fri, 1 Nov 2019 09:02:56 +0100 From: Maxime Ripard To: Hugo Grostabussiat Subject: Re: [PATCH v2 1/3] dt-bindings: net: bluetooth: add DT binding for Realtek controllers Message-ID: <20191101080256.gjc4tacltehro3iw@hendrix> References: <20191030224333.70241-1-bonstra@bonstra.fr.eu.org> <20191030224333.70241-2-bonstra@bonstra.fr.eu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191030224333.70241-2-bonstra@bonstra.fr.eu.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191101_012737_002693_26EFFFBC X-CRM114-Status: GOOD ( 17.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Johan Hedberg , Marcel Holtmann , linux-bluetooth@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Hugo, On Wed, Oct 30, 2019 at 11:43:31PM +0100, Hugo Grostabussiat wrote: > The rtl_bt driver already supports some Realtek controllers on ACPI > platforms. > This commit adds bindings for DT-only platforms. > > Signed-off-by: Hugo Grostabussiat > --- > .../bindings/net/realtek-bluetooth.txt | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.txt You should write that binding using a YAML description. Free-form device tree bindings are more or less deprecated now. > diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.txt b/Documentation/devicetree/bindings/net/realtek-bluetooth.txt > new file mode 100644 > index 000000000000..01d4ed146705 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.txt > @@ -0,0 +1,25 @@ > +Realtek Bluetooth controllers > +============================= > + > +This documents the binding structure and properties for the serial > +attached Bluetooth controllers from Realtek. > + > +Required properties: > +- compatible: currently, only "realtek,rt8723bs-bt" is supported > + > +Optional properties: > +- enable-gpio: gpio line controlling the power down (BT_DIS#) signal > +- device-wake: gpio line controlling the device wakeup (BT_WAKE) signal > +- config-name: postfix added to the name of the firmware file > + containing the chip configuration > + > +Example: > + > +&uart1 { > + bluetooth { > + compatible = "realtek,rtl8723bs-bt"; > + enable-gpio = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */ > + device-wake-gpio = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ > + config-name = "teres_a64_i"; IIRC, that has been discussed before and the standard "model" property was to be preferred. Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel