From: Tao Ren <rentao.bupt@gmail.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Tao Ren <taoren@fb.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] ARM: dts: aspeed: add dtsi for Facebook AST2500 Network BMCs
Date: Fri, 1 Nov 2019 10:42:57 -0700 [thread overview]
Message-ID: <20191101174257.GB13557@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <CACPK8XfebA9PcpyWkofCJ5fAZ9ddUjQ4ZeCf73KXb51+k_+N1Q@mail.gmail.com>
On Fri, Nov 01, 2019 at 10:12:10AM +0000, Joel Stanley wrote:
> On Mon, 21 Oct 2019 at 19:49, Tao Ren <taoren@fb.com> wrote:
> >
> > Introduce "facebook-netbmc-ast2500-common.dtsi" which is included by all
> > Facebook AST2500 Network BMC platforms. The major purpose is to minimize
> > duplicated device entries cross Facebook Network BMC dts files.
> >
>
> > +
> > +&mac1 {
> > + status = "okay";
> > + no-hw-checksum;
>
> Was this included to work around the IPv6 issue that Benh recently fixed?
>
> If you can test your platform with
> 88824e3bf29a2fcacfd9ebbfe03063649f0f3254 applied and the
> no-hw-checksum property removed, please send a follow up to remove
> this property.
>
> It's not doing any harm, but by cleaning it up there's less chance
> others blindly copy the same thing.
>
> Thanks,
>
> Joel
Yes. I'm planning to try the patch. Will send out a followup patch to
remove the line if everything goes fine.
Cheers,
Tao
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
> > +};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-01 17:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 19:48 [PATCH 0/4] ARM: dts: aspeed: add dtsi for Facebook AST2500 Network BMCs Tao Ren
2019-10-21 19:48 ` [PATCH 1/4] " Tao Ren
2019-11-01 10:12 ` Joel Stanley
2019-11-01 17:42 ` Tao Ren [this message]
2019-10-21 19:48 ` [PATCH 2/4] ARM: dts: aspeed: cmm: include dtsi for common network BMC devices Tao Ren
2019-10-21 19:48 ` [PATCH 3/4] ARM: dts: aspeed: minipack: " Tao Ren
2019-10-21 19:48 ` [PATCH 4/4] ARM: dts: aspeed: yamp: " Tao Ren
2019-11-01 10:08 ` [PATCH 0/4] ARM: dts: aspeed: add dtsi for Facebook AST2500 Network BMCs Joel Stanley
2019-11-01 17:40 ` Tao Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101174257.GB13557@taoren-ubuntu-R90MNF91 \
--to=rentao.bupt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=taoren@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox