From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ADFECA9ECF for ; Fri, 1 Nov 2019 17:43:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72786217D9 for ; Fri, 1 Nov 2019 17:43:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t49ahspf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j/dyk5yK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72786217D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3UH1mg8PxueKKlzpVPu5AeoW5Hz7QRk1c8Lp0jKvgBY=; b=t49ahspfJWspHz EEeyqIHMFjNIwnIBSMJNtc3b5YEGFi5h/+4XTezmUnnZEiRLhUi8r7TESQaItTnH3ClAFuXZ+yxII dfN2ZNjim7PuNeuR+1JkswKDSwU0MVDK1DLjO/iPk3RXbU7mLoD80t8SS0ztStdharhhz/gVBXZ3d 7fjYvS2NjhR0ue/yC2FuLSUIZ3gzeLd0sSAaQXvcxRXbJ7c3pIiWqRJ6cuTZLlvz90uKJ1U2M8c26 PDRbBOboI0vp9HAfxyPmWkePkb4601s+ca8xONRsh/4LNtB1HR7j4MC6iR4TMMmO4kQagpGPnLFl2 t0eCkmCR9ZAkNAuK0vXg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQawz-0006Oo-2H; Fri, 01 Nov 2019 17:43:05 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQawv-0006OC-Vc for linux-arm-kernel@lists.infradead.org; Fri, 01 Nov 2019 17:43:03 +0000 Received: by mail-pf1-x443.google.com with SMTP id c13so7532854pfp.5 for ; Fri, 01 Nov 2019 10:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QJl/9GvOTo1mXoprS9Z1FVuoJT7cvJ0SfTXW2ZwsvWU=; b=j/dyk5yKG+/Zb+2zjd8u2xn3vzhnpgHTuI0xH+uDSZ798ljUjQgKbUMa+y4AKD4szr CgKNJadkohLyHsfXr3XjvG8wEdsnapCo57hAincCLWN/bZgW/2PXLq1xqcg1W/6EWxlX 8Q0zZtGSnPhMRXK92TNutM7SdHm2GaTJT1EiOdvEbX/utf+AMfyGYxWbnAGkN6djE494 eHNyGrgpjH6Ar7SWoytBdfhd8Zbi6eiZPw1uRRTV4mx36oZ3kVA0j7mDDTgmfRf0Yty4 K1Zbd3kSgqOy/yxgWwlbo/e8LYg/9UoTPCZ6G7uHuYn0I8fmFokfdibxNpc94c4tcFJK DLVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QJl/9GvOTo1mXoprS9Z1FVuoJT7cvJ0SfTXW2ZwsvWU=; b=t+z6UOVzJBBUHxs17KGwLj2+NsrxelQQxuFy66nOY5Vj4iUX/4sRw3ga+yE9vMBq1M WeaBECk6PDiSOHEl1d8xRKmNdB0YlwJdK2AxxIS8FykZdbaUKYOzd+RqOUNywqI4AVUc DiBVrUbgMe5Ju418nGpON2uaDwUud+sUUwVBJM2VMCK4rtqZbWzrGh2ib9lUXSN0ty4i AavqFcZJMmbkgPlgnQkjzgRQkFJ5hP2e8fBG9XUqI0OUeZpM44L9iUFJPNfZnehfE+Ci XC6uWfyiZdA/9gpjaMO/62Fv/fOE0VI0VKlcg6LEm1hzhQ9zekUzMOXnO20bvQo2KYeh /K/g== X-Gm-Message-State: APjAAAV0U4QH50HRQoBqSL/MIF5/BA84iIjg6HLDDKoIgzvbVfLUnKHa sUugxgbkdzCx/sPjNktNGV0= X-Google-Smtp-Source: APXvYqzRiEfVYYVOG6O+ih3xK5Ax5k+9SP+dNi0+K0ffGqjJhG2LgDZzVmOsjy+yKL16LdvxRSyadg== X-Received: by 2002:a65:4c41:: with SMTP id l1mr14902663pgr.163.1572630180944; Fri, 01 Nov 2019 10:43:00 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 ([2620:10d:c090:200::1:e697]) by smtp.gmail.com with ESMTPSA id a6sm9045892pja.30.2019.11.01.10.43.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Nov 2019 10:43:00 -0700 (PDT) Date: Fri, 1 Nov 2019 10:42:57 -0700 From: Tao Ren To: Joel Stanley Subject: Re: [PATCH 1/4] ARM: dts: aspeed: add dtsi for Facebook AST2500 Network BMCs Message-ID: <20191101174257.GB13557@taoren-ubuntu-R90MNF91> References: <20191021194820.293556-1-taoren@fb.com> <20191021194820.293556-2-taoren@fb.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191101_104302_043717_91DF6A76 X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , linux-aspeed , Tao Ren , OpenBMC Maillist , Linux Kernel Mailing List , Rob Herring , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 01, 2019 at 10:12:10AM +0000, Joel Stanley wrote: > On Mon, 21 Oct 2019 at 19:49, Tao Ren wrote: > > > > Introduce "facebook-netbmc-ast2500-common.dtsi" which is included by all > > Facebook AST2500 Network BMC platforms. The major purpose is to minimize > > duplicated device entries cross Facebook Network BMC dts files. > > > > > + > > +&mac1 { > > + status = "okay"; > > + no-hw-checksum; > > Was this included to work around the IPv6 issue that Benh recently fixed? > > If you can test your platform with > 88824e3bf29a2fcacfd9ebbfe03063649f0f3254 applied and the > no-hw-checksum property removed, please send a follow up to remove > this property. > > It's not doing any harm, but by cleaning it up there's less chance > others blindly copy the same thing. > > Thanks, > > Joel Yes. I'm planning to try the patch. Will send out a followup patch to remove the line if everything goes fine. Cheers, Tao > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>; > > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel