From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 506D5CA9EB5 for ; Mon, 4 Nov 2019 12:46:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26EAD218BA for ; Mon, 4 Nov 2019 12:46:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PTrKtC1e"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dxf2qdCc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26EAD218BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pJInFWCjS2x8aHL1vytXCVT1nBNJaUWVNUgRVFyfL+4=; b=PTrKtC1e3zKChP VIE6pWv1V/h46bZXaXfZIFhxonHfZDztIoZW0QwE8UWdAxai3xpf2ZQFx3VzV+bhumCN/h8Q/Ll6I WJuu7TYW8nlGTsNbo2J9qOdLQsk5CwDYcw2BqXC0tKNdAsGdyG3Zz2iOSXiVejriwOWz2mrLGOD72 fj9dFk65oWu37d+iXfbJAySeCtIc8PX/fW747ztx3ciQklMjruXgJ7/9O2a7/5TkCpJBIMGM9J52g owhdSKtXCg4iO4PQMGkHMfJ/9DF/FIxCF4OaskMLsDF5oQOw3tjlUm2C1YMEV0stIc3NSEoOesIQB YJTyiE9d5jivvJ7ajQEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRbkY-0002UJ-Fd; Mon, 04 Nov 2019 12:46:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRbkV-0002Tr-DK for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2019 12:46:24 +0000 Received: from dragon (li1038-30.members.linode.com [45.33.96.30]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11BD8218BA; Mon, 4 Nov 2019 12:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572871583; bh=uu6hMcwvil/xb9dqy8jjyGW+1kTfPIrio1g2NerX6OE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dxf2qdCcOkPEg/SW5EDL+yx9RaRwjiVhtnRit11I3Y0pAfi0DJ5GvvIuch+W02iXF 1c/lS5US48HKzpmbDWvTmti++TWT0jI3XG/Vlkf6AM5BYboyPPtELDCYqzZRZKfO3O kbzIXvY/7wzA+S6xm9qMwBXQAHY3NXdT7iNrG4iI= Date: Mon, 4 Nov 2019 20:45:55 +0800 From: Shawn Guo To: Schrempf Frieder Subject: Re: [PATCH v3 09/11] ARM: dts: imx6ul-kontron-n6x1x-s: Disable the snvs-poweroff driver Message-ID: <20191104124553.GY24620@dragon> References: <20191031142112.12431-1-frieder.schrempf@kontron.de> <20191031142112.12431-10-frieder.schrempf@kontron.de> <20191104074346.GT24620@dragon> <626ad87a-eb1d-4dca-7cd3-8c5f38025aec@kontron.de> <7da30a17-d16c-3cde-12a8-430ff3eec692@kontron.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7da30a17-d16c-3cde-12a8-430ff3eec692@kontron.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_044623_490770_BCE3B2F2 X-CRM114-Status: GOOD ( 30.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Sascha Hauer , "linux-kernel@vger.kernel.org" , Krzysztof Kozlowski , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 04, 2019 at 11:18:19AM +0000, Schrempf Frieder wrote: > On 04.11.19 09:06, Frieder Schrempf wrote: > > Hi Shawn, > > = > > On 04.11.19 08:43, Shawn Guo wrote: > >> On Thu, Oct 31, 2019 at 02:24:27PM +0000, Schrempf Frieder wrote: > >>> From: Frieder Schrempf > >>> > >>> The snvs-poweroff driver can power off the system by pulling the > >>> PMIC_ON_REQ signal low, to let the PMIC disable the power. > >>> The Kontron SoMs do not have this signal connected, so let's remove > >>> the node. > >>> > >>> This seems to fix a real issue when the signal is asserted at > >>> poweroff, but not actually causing the power to turn off. It was > >>> observed, that in this case the system would not shut down properly. > >> > >> I do not quite follow on this.=A0 How does disabling snvs_poweroff fix= the > >> issue?=A0 The root cause of system not shut down properly seems to be = that > >> PMIC doesn't shut down power.=A0 This looks like a clean-up rather than > >> bug fix. > > = > > I don't know the exact reasons, but we had issues on these boards when = > > doing a "poweroff". The kernel would print something like the log below. > > Disabling the snvs-poweroff solved this. > > = > > But note that this has last been reproduced on v4.14. So I'm not sure i= f = > > this is still a problem with the current kernel. > > = > > ####### > > reboot: Power down > > Unable to poweroff system > > = > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > WARNING: halt/675 still has locks held! > > 4.14.104-exceet #1 Not tainted > > ------------------------------------ > > 1 lock held by halt/675: > > =A0#0:=A0 (reboot_mutex){+.+.}, at: [] SyS_reboot+0x14c/0x1dc > > ####### > > = > >> > >>> > >>> Signed-off-by: Frieder Schrempf > >>> Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron = > >>> i.MX6UL N6310 SoM and boards") > >> > >> If you think this is really a bug fix, it should be applied to the file > >> before renaming rather than the one after renaming. > > = > > I will try to reproduce the issue with the current kernel and depending = > > on the results either drop the Fixes tag or move the patch before the = > > renaming. > = > I just tried this with 5.4-rc5 and the issue persists. When = > snvs-poweroff is enabled without the hardware actually being able to = > power down via PMIC I get a locking WARNING from the kernel. Probably = > because the system is still running, when it's already supposed to be = > shut down by the PMIC. I still do not get it. Are you saying that with snvs-poweroff being disabled, your system is now able to be shut down properly by PMIC? Shawn > = > So this fixes a real problem and therefore I will keep the Fixes tag and = > move the patch to the proper place in this series. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel